#foswiki 2011-12-08,Thu

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
***pharvey has joined #foswiki [00:58]
EnriqueCadalso has joined #foswiki [01:12]
.... (idle for 17mn)
pharvey has quit IRC (Ping timeout: 252 seconds) [01:29]
pharvey has joined #foswiki
pharvey has quit IRC (Changing host)
pharvey has joined #foswiki
[01:37]
jayenorev: in the create new web page, though, isnt' there an option for copying from another web? [01:42]
***EnriqueCadalso has quit IRC (Read error: Connection reset by peer)
EnriqueCadalso has joined #foswiki
Plazma-Rooolz has quit IRC (Read error: Connection reset by peer)
Plazma-Rooolz has joined #foswiki
Plazma-Rooolz is now known as Plazma
[01:47]
Plazma has quit IRC (Read error: Connection reset by peer)
Plazma has joined #foswiki
[02:00]
..... (idle for 21mn)
khnz has joined #foswiki
khnz_ has quit IRC (Ping timeout: 268 seconds)
[02:22]
gac410 has joined #foswiki [02:33]
........ (idle for 36mn)
tsnfoo has quit IRC (Quit: tsnfoo)
tsnfoo has joined #foswiki
[03:09]
............. (idle for 1h0mn)
orev has quit IRC (Quit: Leaving.)
wdenk1 has quit IRC (Ping timeout: 240 seconds)
[04:10]
wdenk1 has joined #foswiki [04:26]
..... (idle for 22mn)
pharveygac410, SvenDowideit, Babar: perverted expect_failure a little... Foswikirev:13323 :) [04:48]
FoswikiBothttp://trac.foswiki.org/changeset/13323 [ Changeset 13323 – Foswiki ] [04:48]
gac410cool! [04:49]
pharveyd'oh! it's actually not_using and with_dep, not: notusing and dependency
the code/comments/doc are correct, but the commit message is misleading
Eg. $this->expect_failure('Requires ADDTOZONE feature', not_using => 'ZonePlugin', with_dep => 'Foswiki,<,1.1' );
[04:49]
gac410you've been busy [04:50]
pharveygetting mongo to work, and shooting towards our production site have all the tests pass means this is necessary, I think [04:51]
gac410That will be a big improvement to the unit tests.
Hm. How about a similar function $this->check_environment( .... ) returns true/false without actually setting the expect failure.
[04:51]
pharveythat's already there, I documented in test/unit/FoswikiTestCase.pm
it's check_using and check_dependency
[04:54]
gac410Ah ... great!
Shows how closely I read your commit ;-)
[04:54]
pharveyyeah, the commit message could've been better
too distracted :P
[04:55]
gac410no prob. [04:55]
pharveypharvey increasingly helping colleagues outside his team to do perl stuff :)
.net guy's reaction: "ew, elsif has no 'e'?!" :)
[04:56]
***GithubBot has joined #foswiki [05:02]
GithubBot[foswiki] foswiki pushed 2 new commits to master: http://git.io/As6dWQ
[foswiki/master] Item11332: expect_failure([$reason,][%conditions]) - PaulHarvey
[foswiki/master] Item11332: Use the new expect_failure feature a bit - PaulHarvey
[05:02]
***GithubBot has left [05:02]
FoswikiBothttp://foswiki.org/Tasks/Item11332 [ Item11332: Make it easier for tests to =expect_failure_using('something')= ] [05:02]
....... (idle for 31mn)
***sezuan has quit IRC (Ping timeout: 252 seconds)
joelio has quit IRC (Ping timeout: 252 seconds)
uebera|| has quit IRC (Ping timeout: 252 seconds)
uebera|| has joined #foswiki
sezuan has joined #foswiki
dj_segfault has quit IRC (Quit: Leaving.)
joelio has joined #foswiki
[05:33]
uebera|| has quit IRC (Changing host)
uebera|| has joined #foswiki
uebera|| has quit IRC (Excess Flood)
uebera|| has joined #foswiki
[05:48]
..... (idle for 22mn)
gac410 has left [06:11]
........ (idle for 36mn)
GithubBot has joined #foswiki [06:47]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/mPt_YA
[foswiki/master] Item11332: List tests in summary (not just modules) - PaulHarvey
[06:47]
***GithubBot has left [06:47]
FoswikiBothttp://foswiki.org/Tasks/Item11332 [ Item11332: Make it easier for tests to =expect_failure_using('something')= ] [06:47]
***pharvey has quit IRC (Quit: ChatZilla 0.9.87 [Iceweasel 8.0/20111109081537]) [06:52]
jayencan someone test http://trunk.foswiki.org/Sandbox/JayenJQueryAjaxHelper on a browser of their choice and put their results in http://foswiki.org/Tasks/Item11335#edittable2 ? [06:52]
FoswikiBot[ Item11335: JQueryAjaxHelper examples are broken on 1.1.4-RC2 ] [06:52]
***MartinCleaver_ has joined #foswiki
MartinCleaver has quit IRC (Ping timeout: 240 seconds)
MartinCleaver_ is now known as MartinCleaver
[07:01]
........ (idle for 35mn)
ArthurClemen has quit IRC (Quit: Leaving...)
pharvey has joined #foswiki
pharvey has quit IRC (Changing host)
pharvey has joined #foswiki
[07:38]
CDot has joined #foswiki [07:55]
ModAcOst has joined #foswiki [08:00]
..... (idle for 23mn)
denisr has joined #foswiki [08:23]
........ (idle for 38mn)
dnel has joined #foswiki
GithubBot has joined #foswiki
[09:01]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/uibTCg
[foswiki/master] Item10328: writeDebug tweaks - PaulHarvey
[09:01]
***GithubBot has left [09:01]
FoswikiBothttp://foswiki.org/Tasks/Item10328 [ Item10328: use the writeDebug, luke! ] [09:02]
CDotpharvey: did you ever manage to merge to the unicode branch on github?
CDot doesn't have time to work on it right now, but is keen that it is kept up to date
[09:05]
pharveyCDot, yeah, last weekend I think [09:06]
CDot:-) thanks! [09:06]
pharvey4 days ago according to github
the tests ran up to RCSTests before I killed them, not sure if I broke much :-)
[09:06]
CDotgreat. I haven't run through all the tests myself yet. Seemed in reasonably good shape last time I looked.
really needs more testing input (hint, Babar)
CDot takes a deep breath and dives back into ActionTrackerPlugin
[09:12]
pharveyI'm curious what the source of the memory leak could be [09:15]
...... (idle for 28mn)
CDotwhat memory leak? [09:43]
pharveyCDot: do the tests run to completion for you? I never got them to finish (even prior to the merge) [09:51]
CDotno, but I have never allowed them to finish IIRC.
you reckon there's a memory leak? ouch.
[09:51]
.... (idle for 15mn)
something has changed so that .htpasswd.lock is left lying around. is that expected?
CDot is working in trunk
[10:06]
......... (idle for 40mn)
***GithubBot has joined #foswiki [10:47]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/tz0FyQ
[foswiki/master] Item11340: fix macro expansion in notify template - CrawfordCurrie
[10:47]
***GithubBot has left [10:47]
FoswikiBothttp://foswiki.org/Tasks/Item11340 [ Item11340: macro not expanded in HTML mail ] [10:47]
............ (idle for 58mn)
***JulianLevens has joined #foswiki
GithubBot has joined #foswiki
[11:45]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/al8Jzg
[foswiki/master] Item11332: Make the summary less annoying - PaulHarvey
[11:45]
***GithubBot has left [11:45]
FoswikiBothttp://foswiki.org/Tasks/Item11332 [ Item11332: Make it easier for tests to =expect_failure_using('something')= ] [11:45]
***JulianLevens has quit IRC (Ping timeout: 268 seconds) [11:52]
GithubBot has joined #foswiki [12:02]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/FRwmSQ
[foswiki/Release01x01] Item11332: expect_failure([$reason,][%conditions]) - PaulHarvey
[12:02]
***GithubBot has left [12:02]
...... (idle for 27mn)
dj_segfault has joined #foswiki
Colas has quit IRC (Quit: Ex-Chat)
[12:29]
Colas has joined #foswiki [12:43]
GithubBot has joined #foswiki [12:48]
GithubBot[foswiki] foswiki pushed 3 new commits to Release01x01: http://git.io/eEdIDQ
[foswiki/Release01x01] Item11332: Sync trivial changes from trunk - PaulHarvey
[foswiki/Release01x01] Item11332: Use the new expect_failure feature a bit - PaulHarvey
[foswiki/Release01x01] Item11324: perltidy them all - PaulHarvey
[12:48]
***GithubBot has left [12:48]
FoswikiBothttp://foswiki.org/Tasks/Item11332 [ Item11332: Make it easier for tests to =expect_failure_using('something')= ]
http://foswiki.org/Tasks/Item11324 [ Item11324: perltidy them all ]
[12:48]
***dj_segfault has quit IRC (Quit: Leaving.) [12:53]
.... (idle for 18mn)
ArthurClemens has joined #foswiki
pharvey has quit IRC (Ping timeout: 248 seconds)
MartinRowe has joined #foswiki
GithubBot has joined #foswiki
[13:11]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/0pYyVg
[foswiki/master] Item11341: add cog icon - ArthurClemens
[13:15]
***GithubBot has left [13:15]
FoswikiBothttp://foswiki.org/Tasks/Item11341 [ Item11341: Add cog icon ] [13:15]
.......... (idle for 45mn)
***gac410 has joined #foswiki
GithubBot has joined #foswiki
[14:00]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/8hdy6w
[foswiki/master] Item11140: fixes resulting from more testing - CrawfordCurrie
[14:01]
***GithubBot has left [14:01]
FoswikiBothttp://foswiki.org/Tasks/Item11140 [ Item11140: JS is painfully slow with large numbers of table cells. ] [14:01]
.... (idle for 17mn)
SvenDowideitoh dear, pharvey merged from trunk to store2 again.
he's really way too damned helpful
and if he's not careful, er, i dunno :)
[14:18]
***GithubBot has joined #foswiki [14:30]
GithubBot[foswiki] foswiki pushed 2 new commits to master: http://git.io/-ESbzg
[foswiki/master] Item10309: make WORKFLOWLAST* accept topic and web parameters. - GilmarSantosJr
[foswiki/master] Item11335: Fix JQueryAjaxHelp examples - GeorgeClark
[14:30]
***GithubBot has left [14:30]
gac410I'm going to pull the JQuery 1.7 and 1.7.1 code into Release 1.1.4. I won't make it the default version, but it seems to fix most of the AjaxHelper issues on Firefox. [14:30]
FoswikiBothttp://foswiki.org/Tasks/Item10309 [ Item10309: WORKFLOWLAST macros do not accept topic parameter ]
http://foswiki.org/Tasks/Item11335 [ Item11335: JQueryAjaxHelper examples are broken on 1.1.4-RC2 ]
[14:31]
gac410FoswikiBot: seen MichaelDaum [14:38]
FoswikiBotgac410: MichaelDaum was last seen in #foswiki 1 days 22 hours ago joining the channel. [14:38]
***Colas has quit IRC (Ping timeout: 244 seconds) [14:39]
gac410trunk has more changes than just 1.7.1 - so I don't know if it's 1.7.1 or some changes to a new loader that fixes firefox :-(
So do I sync trunk JQuery to 1.1.4 at this late date, or just ship with busted Ajax examples on Firefox
[14:40]
On Trunk, all of the JQueryAjaxHelper examples are now working - Thanks to jayen for finding a missing quote. [14:45]
***tsnfoo has quit IRC (Quit: tsnfoo)
GithubBot has joined #foswiki
[14:45]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/CMpKHw
[foswiki/Release01x01] Item11335: Fix JQueryAjaxHelp examples - GeorgeClark
[14:47]
***GithubBot has left [14:47]
Colas has joined #foswiki [14:55]
...... (idle for 25mn)
CDotgac410: no response from MichaelDaum yet? [15:20]
gac410no
Trunk actually looks good, plus jayen helped a lot - found a pesky missing quote,
But looking at the commit for 1.7.1 on trunk, there are a lot of changes. Just studying a diff of the master: and release11: JQuery directories.
So with trunk on firefox, all of the examples work. Still differences from the 1.1.3 version - especially the requirement for a 2nd click or enter in the jumpboxes. But at least it works.
Unfortunately the commit of 1.7.1 is a mish-mash of syncing release changes into trunk, and other stuff. So I can't cherry-pick.
Git is incredibly helpful, but commits need to be better focused into units that can be committed across branches.
If there were separate commits: Implement 1.7 and 1.7.1, Sync with release branch, Improve JQLoader, etc. ... I'd be done.
I'm also very concerned about that recursion error in search reported yesterday: http://irclogs.foswiki.org/bin/irclogger_log/foswiki?date=2011-12-07,Wed&sel=480#l476
but no task or details yet :-(
[15:20]
CDotgac410: y. I get the perception this is a major prob with the way we are using git [15:28]
gac410I wouldn't say major, just we could be a bit smarter to make it easier to pass commits between branches.
I expect that recursion error is an easy fix - just a missing no warnings 'recursion';  somewhere.
[15:29]
...... (idle for 28mn)
SvenDowideitCDot wrt populateWeb
i'm still concerned about how we do things in the unit tests
when FoswikiFnTestCase creates a user web, it uses the default
which _should_ mean that all the adduser to group tests and rego tests should really fail hard
mmm, ok, just the addgroup ones
as adduser is supposed to require a template topic that is in the main web
_but_ 1.1 (i really can't comment about 1.0 atm) the tests quietly and somewhat horribly succeed
[15:59]
***GithubBot has joined #foswiki [16:01]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/8mmIHA
[foswiki/master] Item11332: sort the summary list so that we can see all the verify_tests failures grouped - SvenDowideit
[16:01]
***GithubBot has left [16:01]
FoswikiBothttp://foswiki.org/Tasks/Item11332 [ Item11332: Make it easier for tests to =expect_failure_using('something')= ] [16:01]
gac410I thought the template were all defaulted in system now, so users could copy to Main to customize without risk of overlay [16:02]
SvenDowideitI _guess_ that i need to make the FoswikiFnTestcase setup make a more complete usersweb, but ...
gac410 yeah - thought
i thought so too, but it seems that we didn't do so for the grouptemplate
as in store2 those tests fail (now that you can't Foswiki::Meta::new and it just succeeds
[16:02]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Meta [ (Foswiki login) PerlDoc ] [16:03]
SvenDowideitSvenDowideit is dithering, cos he's not sure that there are no issues with the approach i'm taking :( [16:04]
gac410So for the Group template - might be better to make that one default to a System topic as well. [16:04]
SvenDowideityes, it definitly would , but thats not the issue that is worrying me atm
the bigger issue is that the unit tests that use FoswikiFnTestcase get a usersweb amd testweb taht contain _only_ webprefs
and that now that i'm making load(missing topic) die rather than create a new non-saved to disk meta, i find some (hopefully benign) surprises
i'm almost positive that this has been the case since before CDot created the unit test system
which is why i'm hesitating to blow it away :/
[16:04]
CDotwhat has been the case? [16:07]
SvenDowideitthat the core and now unit tests assume that some topics exist, and it 'just works' because when they are not there, the core just gives us a new, unsaved meta
whereas store2 is retentive, and insists that if you call load, that the topic exists
[16:08]
CDotI don't think the core assumes any topics (maybe rego?) [16:09]
SvenDowideitlots
specifically, FoswikiFnTestCase creates a USERSWEB containing only WEBprefs
[16:09]
CDotthe unit tests cetainly do; and
I'd expect them to
[16:09]
SvenDowideitand that kills lots of unit tests [16:09]
CDotI tried to create the absolutely minimum i could get away with [16:10]
SvenDowideitbut prior to store2, those tests succeeded because the core just gave them an unloaded new obj
y, and that minimum succeeded, but imo was an incorrect success
[16:10]
CDotgotcha. [16:11]
SvenDowideiti'm not looking for reasons why, i'm hoping that you can help me feel ok about changing it :) [16:11]
gac410For things like rego tests, the test setup probably ought to make sure that the required topics shipped with the contrib are present.
And if critical topics are missing then things really should fail
[16:11]
SvenDowideitbasically, 50% of the problem is that i'm stepping through the tests in the debugger one statememnt at a time, and keep finding things that succeed, but make no sense at all
cos we either re-do them, throw away half the work, or just ignore it and do it again a different way
[16:12]
***denisr has quit IRC (Quit: Parti) [16:12]
SvenDowideitgac410 ok, so i count you as a vote to retain the retentive-ness of store2 :)
(at least in DEBUG mode)
SvenDowideit was thinking of trying to get a professional security audit some day, just out of the same principle
[16:13]
gac410I think so. I suspect that we occasionally have inconsistent / surprising results. Really if I say "load blah" and blah doesn't exist, there should be an error. [16:14]
SvenDowideitin store2, it either throws, or atm dies
its been painful, but i'm fundamentally astounded to have gotten so far without having to redesign
ok, CDot i'd love to know if you think i'm being mad having the store&meta change so dramatically - but would rather a considered response rather than a fast one
as i did see you do rely on making a non-saved meta quite a bit :(
[16:15]
***GithubBot has joined #foswiki [16:17]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/xdFvYg
[foswiki/Release01x01] Item10646: Need propset if $Rev$ is to work - GeorgeClark
[16:17]
***GithubBot has left [16:17]
FoswikiBothttp://foswiki.org/Tasks/Item10646 [ Item10646: Documentation updates for 1.1.4 ] [16:17]
SvenDowideit(something i see as a fundamental flaw in how our core goes about its business, but i don't know how/if its solveable) [16:17]
CDotSvenDowideit: y, i was using a non-saved meta as an address object. But I'm quite happy for it to go; I was never totally happy with it, but had so many other things to do..... [16:18]
SvenDowideitnono not the addr use
i mean the 'i need a random meta to render something' or to compare meta
[16:19]
CDotCDot has added a REST handler to EditRowPlugin to support access to arbitrary rows/cols of tables in topics [16:19]
SvenDowideit_noce_
or (i have no idea what other reasons people have found to create a meta obj that will never hit disk
[16:19]
CDotoh yeah, the old "random meta to render something because the stupid f***ing render code expects a meta but hardly uses it and what's it need to know that shite anyway oh god I'll have to rewrite 500 lines of Render.pm OK I'll just use a meta-fake object" scenario. [16:21]
SvenDowideitgiggle
once upon a time it was easy, we just threw arounf $web and $topic and some disk activity happened >:}
[16:21]
CDotpffffffffffffttttttttt [16:22]
SvenDowideitnow, ficked if i know what store2 does :)
oh, shit have to wake girls
time to go - laters :)
[16:22]
***dnel has quit IRC (Quit: Leaving.) [16:25]
GithubBot has joined #foswiki [16:32]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/elz_9g
[foswiki/master] Item11342: added REST handler to give r/w access to individual rows/cols of tables. used it to access cell content for text and textarea - CrawfordCurrie
[16:32]
***GithubBot has left [16:32]
FoswikiBothttp://foswiki.org/Tasks/Item11342 [ Item11342: Per cell editing of TML saves expanded HTML ] [16:32]
***GithubBot has joined #foswiki [16:45]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/ybDZvQ
[foswiki/master] Item11342: doc corrections - CrawfordCurrie
[16:45]
***GithubBot has left [16:45]
MartinRowe has quit IRC (Quit: Leaving.)
ModAcOst has quit IRC (Remote host closed the connection)
GithubBot has joined #foswiki
[16:55]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/okl1wg
[foswiki/master] Item11342: duh - make sure all files are in the package - CrawfordCurrie
[17:03]
***GithubBot has left [17:03]
FoswikiBothttp://foswiki.org/Tasks/Item11342 [ Item11342: Per cell editing of TML saves expanded HTML ] [17:03]
***TJCRI has joined #foswiki [17:06]
...... (idle for 25mn)
GithubBot has joined #foswiki [17:31]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/3V0IZg
[foswiki/master] Item11342: disable cache - CrawfordCurrie
[17:31]
***GithubBot has left [17:31]
ArthurClemens has quit IRC (Ping timeout: 240 seconds)
terceiro has quit IRC (Quit: Ex-Chat)
CDot has quit IRC (Quit: Leaving.)
[17:41]
..... (idle for 24mn)
Colas has quit IRC (Quit: Ex-Chat)
ColasHome has quit IRC (Remote host closed the connection)
ColasHome has joined #foswiki
[18:08]
.... (idle for 17mn)
LynnwoodI've got a couple of relatively new installations running 1.1.3 where every once in a while (several times a day), when i go to save a topic I get the warning about possible problem (the stikeone message) and regardless of which option I choose, I am then redirected to login. But it's clear that I did nothing to trigger this. It's annoying. I did a search of f.o. but don't really see anything about this. Have others run into this? [18:32]
............. (idle for 1h0mn)
SvenDowideitnot me :/
the thing is (as i grok it), the strikeone goes to the login script, so it might be that something then goes screwy with the session data
SvenDowideit hasn't spent time with that code tho
[19:32]
***terceiro has joined #foswiki [19:34]
...... (idle for 28mn)
ArthurClemens has joined #foswiki [20:02]
.......... (idle for 45mn)
gac410Hi ArthurClemens - any thoughts on installing JQuery 1.7.1 for Foswiki 1.1.4? Michael has not been around, and the latest JQuery seems to fix the firefox 7 issues on the AjaxHelper page.
I'm mostly done with locally merging Michael's 1.7.1 changes into 1.1.4 - but not committing for now.
[20:47]
***pharvey has joined #foswiki [20:57]
ArthurClemenshmm, I haven't used that version yet [20:57]
gac410I switched trunk to 1.7.1
MichaelDaum updated it a while ago, but configure was still set to 1.6.4
[20:57]
.... (idle for 17mn)
ArthurClemensfunny that {JQueryPlugin}{JQueryVersion} list is not sorted [21:15]
pharveyLynnwood: I've had this when the site gets confused between http & https. Switching from one to other makes you lose your SID cookie (session ID)
POST to http -> apache redirects to https -> loss of session cookie
[21:18]
Lynnwoodnot the case for me. both of these sites only use http [21:19]
pharveyhmm. would be useful to know if the FOSWIKISID cookie is changing value when this happens
is there any reliable way to reproduce?
[21:19]
Lynnwoodnot that i know of. Seems random [21:20]
pharveyif so, install firebug+firecookie and watch the FOSWIKISID value... alternatively believe there are some TRACE or MONITOR constants in the session code that will emit this detail in the logs [21:20]
Lynnwoodok. thanks. i'll try it
thanks so much for the lead! This has mystified me.
[21:21]
SvenDowideitpharvey i don't like your unit test summary changes :P
but i'm now distracted again, so harumpf
[21:24]
***GithubBot has joined #foswiki [21:33]
GithubBot[foswiki] foswiki pushed 2 new commits to Release01x01: http://git.io/YeHQuQ
[foswiki/Release01x01] Item11335: Need JQuery 1.7.1 for Firfox 7 compat - GeorgeClark
[foswiki/Release01x01] Item11335: Sync the TOPICINFO to trunk - GeorgeClark
[21:33]
***GithubBot has left [21:33]
FoswikiBothttp://foswiki.org/Tasks/Item11335 [ Item11335: JQueryAjaxHelper examples are broken on 1.1.4-RC2 ] [21:33]
gac410My "master:" branch is missing ... JQueryPlugin/pub/System/JQueryPlugin/ui/jquery-ui.js File is only in the release branch
Anyone know - is this an error in master, or has that file been deleted. It's still listed in the manfiest
[21:42]
Babargac410: Foswikirev:6360
it's generated from the .src or something
[21:46]
FoswikiBothttp://trac.foswiki.org/changeset/6360 [ Changeset 6360 – Foswiki ] [21:46]
Babarso the MANIFEST will generate it for you, sorry the build.pl or pseudo-install.pl [21:46]
gac410ug. So I just added it. I'll remove it. Strange that it was in the release1.1 branch though. [21:47]
***GithubBot has joined #foswiki [21:47]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/EQEyfw
[foswiki/Release01x01] Item11335: Missed one topic in sync to trunk - GeorgeClark
[21:47]
***GithubBot has left [21:47]
gac410I did a git clean to remove all derived files. Then a find JQueryPlugin/ -type f -exec git --no-pager diff release11:{} master:{} \;
on release11 and master. Kept getting errors about that file existing in release1.1 but not in master.
[21:47]
Babarmaybe Micha forgot to remove it from the release branch?
anyway, you have the commit :)
[21:49]
gac410yup - thanks. Must be generated from jquery-ui.uncompressed.js
I'll revert my trunk commit and remove the file from release11
[21:49]
Babaryeah, sounds like the right thing to do [21:50]
***pharvey has quit IRC (Ping timeout: 252 seconds) [21:52]
gac410Anyway, JQueryAjaxHelper works *much* better with JQuery 1.7.1
or maybe I should just say that it works. On FF7 almost all the examples were dead.
Thanks for finding that changeset. Is there a trick on git to finding a changeset that removed a file?
[21:52]
Babaryes :)
--
git log -- JQueryPlugin/pub/System/JQueryPlugin/ui/jquery-ui.js
git tells you, but in its own way
it tells you that it doesn't know what you mean by JQueryPlugin/pub/System/JQueryPlugin/ui/jquery-ui.js, without the --, so that you should separate path with arguments with --
so...
[21:56]
***GithubBot has joined #foswiki [22:04]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/wePICA
[foswiki/Release01x01] Item11335: jquery-ui.js is derived from uncompressed - GeorgeClark
[22:04]
***GithubBot has left [22:04]
FoswikiBothttp://foswiki.org/Tasks/Item11335 [ Item11335: JQueryAjaxHelper examples are broken on 1.1.4-RC2 ] [22:04]
gac410thanks Babar Learn something every day. [22:05]
***MartinCleaver has quit IRC (Quit: MartinCleaver)
MartinCleaver has joined #foswiki
[22:13]
jayengac410: i fixed up the extra click for the jump boxes [22:17]
gac410oh - great. [22:17]
jayenis it not working for you? [22:17]
gac410well I don't have your fix. [22:18]
jayenthe page on trunk in sandbox i sent out
it has all the fixes
i don't htink any of them are 1.7 specific, so thye might work on 1.6.4 as well
[22:18]
gac410Oh ... no I have not been tracking that. [22:18]
jayenthere's a link from Item11335 [22:19]
gac410okay - looking [22:19]
jayenshould be able to just copy the page on top of the existing JQueryAjaxHelper page
hey foswikibot, where's my link to Item11335?
i fixed the spinner, too
and the web name in the global jump box
as it was before
[22:19]
Babarjayen: the bot said the link like 15 min ago [22:20]
***Babar sets mode: +v FoswikiBot [22:20]
jayenoh, i see. it doesn't repeat
cool
[22:20]
Babarwon't say it again before another 15 min
nah, he's a clever bot
(pharvey requested that feature, iirc)
[22:20]
gac410jayen - I thought the spinner was enabled by using the jquery foswiki theme [22:20]
Babar((and I coded it :))) [22:21]
jayenyeah it is. i added the css to the page, though. it should be part of the example if people want to use it
i think the spinner is a common thing for people to want, i mean
[22:21]
gac410That's part of the theming - If the theme is set in configure, then you get the spinners. [22:22]
ArthurClemensgac410: I don't see any problems with jquery 1.7.1 [22:22]
jayeni think you should get the spinners with any theme [22:22]
gac410okay great ArthurClemens thanks for checking. It seemed to be looking good for me too. And I'm pretty sure Micha sent me an offline comment saying it was working for him - back when he added it to trunk. [22:23]
***MartinCleaver_ has joined #foswiki
MartinCleaver has quit IRC (Read error: No route to host)
MartinCleaver has joined #foswiki
MartinCleaver_ has quit IRC (Ping timeout: 240 seconds)
[22:27]
jayeni tried copying my trunk page over to f.o. all the examples that don't rely on autocomplete.init.js seem to be working. not sure why the others don't, though. [22:31]
gac410f.o is on jq 1.6.4 - may be the difference [22:35]
jayeni doubt it. the ui libraries are both 1.8.16 [22:36]
***pharvey has joined #foswiki
pharvey has quit IRC (Changing host)
pharvey has joined #foswiki
[22:36]
pharveySvenDowideit: too noisy? [22:36]
gac410Right now in my local svn checkout, all of the examples are working. I had applied your missing quote. I'll look at merging your changes, but there are a lot of differences as the formatting of the topic has changed. [22:37]
jayengac410: take a look at my page at how i fixed the global jump to include the web name and the local jump to not include it. it's much closer to the way 1.1.3 was [22:37]
gac410I'm working through the diff now - I need to check the topic in using git / svn [22:38]
jayenyeah, ok. the diff shouldn't be that big. i kept editing the wiki text and didn't use ht ewysiwyg
git's word diff is very handy
and git diff coloring
can you turn on jqueryplugin-debug on f.o so i can figure out if it is jquery 1.6.4 or something else we're doing wrong
[22:39]
gac410Not sure why, but there are big differences in wordwrap of the examples. It will take a bit. [22:40]
***TJCRI has quit IRC (Remote host closed the connection) [22:41]
jayengit diff --word-diff
git diff --word-diff=color
git diff --color-words
[22:41]
pharveygac410, Babar - btw - any feedback on the TestRunner summary changes?... [22:45]
gac410I have not run testrunner in a day or so, [22:45]
pharveyhttp://fosiki.com/Foswiki_trunk/Foswiki-UnitTests.log
ah, that's an old run... the output is slightly different now.
I had trouble remembering how many expected-passes were actually in a normal run, so if you get any failures, the x of y passes seems to be a lot lower than you expect
er, expected-failures
sven had a per-module summary. But I usually want to know exactly which tests are failing.
[22:45]
gac410jayen: figured it out. Pasting the topic into vim I ended up word wrapping everything. Not you. :-( [22:49]
Babarpharvey: not yet [22:50]
jayengac410: emacs, ftw!
or "nano -w"
[22:54]
gac410or ?raw=all file->save-as [22:55]
pharveygac410, reviewed differences in UnitTestContrib last night between trunk & Release01x01. I feel a lot better about working towards syncing these up to be the same as each other with the new features. I reckon I could do Fn_SEARCH and QuerySearch, the others seemed to be partly some changes that haven't made it into Release01x01 yet. [22:57]
***jomo has quit IRC (Read error: Connection reset by peer)
jomo has joined #foswiki
[23:03]
gac410jayen: What's the change ... window.location.href="%SCRIPTURLPATH{"view"}%/ all about? [23:04]
jayenthat's the jump without a second click
it's what 1.1.3 had
[23:04]
gac410Ah. okay great.
gac410 wonders why Michael removed that.
Jayen - I'll check it in - I need to head out.
[23:04]
jayenok, thanks [23:05]
gac410jayen: Just commited your changes to release11 branch and trunk. So trunk.foswiki.org should have your changes within 15 minutes. [23:08]
jayenok, cool
i'll test it out
[23:08]
gac410I'm not sure of impact to everyone else by enabling debug on foswiki.org - I can't hang around to test. [23:09]
jayenn oworries
c ya
[23:09]
gac410Maybe Babar can help
;-)
[23:10]
***gac410 has left [23:10]
jayenhey Babar, any reason why autocomplete-init.js works on t.f.o but not f.o? george was suggesting it's the different jquery versions, but i don't think so [23:10]
***GithubBot has joined #foswiki [23:17]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/FDqgDw
[foswiki/Release01x01] Item11335: Fix JQueryAjaxHelper - GeorgeClark
[23:17]
***GithubBot has left [23:17]
FoswikiBothttp://foswiki.org/Tasks/Item11335 [ Item11335: JQueryAjaxHelper examples are broken on 1.1.4-RC2 ] [23:17]
***GithubBot has joined #foswiki [23:31]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/JRb6_w
[foswiki/master] Item11335: Fix JQueryAjaxHelper - GeorgeClark
[23:31]
***GithubBot has left [23:31]
MartinCleaver has quit IRC (Quit: MartinCleaver) [23:39]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)