#foswiki 2012-01-07,Sat

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
gac410HtPasswdUser.pm caches the password file. Any performance concerns with doing a file stat to see if the file timestamp has changed before trusting the cache? I recall comments that stat is very costly. [00:12]
............ (idle for 59mn)
Hi all - See Question1001 - F114 upgrade issues - taint problem cleaning up dead CGI session files - I don't get it.
Really strange - LoginManager.pm didn't change from 1.1.3 to 1.1.4.
[01:11]
The filename is untainted just a couple of lines prior to the unlink. [01:28]
........ (idle for 36mn)
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/YkN5IQ
[foswiki/Release01x01] Item11409: Flush password cache, move lockfile - GeorgeClark
[02:04]
***GithubBot has left [02:04]
FoswikiBothttp://foswiki.org/Tasks/Item11409 [ Item11409: HtpasswdUser issues when shared between multiple Foswiki instances ] [02:04]
Babargac410: no, I disagree with your change...
it shouldn't be $htpasswd.lock...
as for example, the .htpasswd might reside in a directory where the webserver user doesn't have write access
only to the password file
[02:08]
gac410ugh.
make it a configurable location then so two Foswiiki installations can define a common lock?
good poing.
er.. point.
[02:09]
Babaryes, some advanced config value, with the default being what you put, or maybe what it used to be [02:10]
gac410yeah - where it used to be is fine. Except in unusual situations like us with trunk and f.o
I'll change it. Thanks.
[02:11]
.... (idle for 17mn)
Babar - fixed. Hopefully that looks better. ;-) [02:28]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/Incwgw
[foswiki/Release01x01] Item11409: Make location of lockfile configurable - GeorgeClark
[02:30]
***GithubBot has left [02:30]
.... (idle for 17mn)
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/arRbsw
[foswiki/master] Item11409: Flush password cache, move lockfile - GeorgeClark
[02:47]
***GithubBot has left [02:47]
FoswikiBothttp://foswiki.org/Tasks/Item11409 [ Item11409: HtpasswdUser issues when shared between multiple Foswiki instances ] [02:47]
Babarlooks good to me [02:53]
gac410great. Thanks. btw did you see Foswiki:Support/Question1001 ... really strange [02:54]
FoswikiBothttp://foswiki.org/Support/Question1001 [ Question1001 ] [02:54]
BabarI agree with your questions, and Paul's remark [02:59]
gac410The question is what else changed :-D [03:00]
Babarweird
ok, nap time for me, it's past 4am :)
[03:02]
gac410g'night ... or is it almost g'morning [03:02]
Babarexactly ;)
thx
[03:02]
.... (idle for 19mn)
MarianBanicahello. can anybody tell me how to remove a web
i mean i've moved to trash
but from trash...?
[03:21]
gac410ah - we don't have any way - just delete it from the file system.
What some do is have a cron job run a script to tar and rm all the trash files.
[03:22]
MarianBanicayou mean from FTP or there is also other way? [03:22]
gac410Don't you have shell access or some tool to delete files on the server? [03:23]
MarianBanicai do. is ok
Foswiki is too nice to not have this option to remove webs :)
but we can wait :)
[03:24]
gac410Actually it's anything in trash - once you move it there we don't have any tool for the next step. [03:25]
MarianBanicaok then.
i like very much this template
http://www.facebook.com/photo.php?fbid=72961546040&set=a.72961151040.96286.63456981040&type=3&theater
from where i can have it
?
i mean not that template but at least something similar with that from which to start to modify
:d
[03:25]
pharveyYou can work from PatternSkin, but I prefer WidgetsSkin [03:27]
MarianBanicais not better to place on the first page on the top menu a link to "skins" and to move all skins to a new "web"
?
[03:30]
pharveysorry, I don't understand your question
there's a Foswiki:System.SkinBrowser
[03:34]
FoswikiBothttp://foswiki.org/System.SkinBrowser [ SkinBrowser ] [03:34]
pharveySvenDowideit: fix home.org.au! :) [03:35]
MarianBanicaok [03:39]
dj_segfaultHey, folks. Just want to verify quickly: If I Set DENYWEBCHANGE = WikiGuest, then only logged-in users will be able to change the wiki, but that won't stop others from reading it, right? [03:41]
pharveydj_segfault: correct [03:42]
gac410yes - though the AuthScripts setting in configure also prevents edit by unauthenticated users. [03:42]
dj_segfaultIs it safe to do that in Main? If I do that will new account pages get set correctly? I screwed myself over by restricting webchange on Main to Admin because some users were creating topics there instead of the web they were supposed to. Now they can't change password, etc because their home page does not exist so it doesn't have their password (I may ask more questions on fixing that later)
Sounds like AuthScripts may be safer. Lemme look at that...
[03:44]
gac410huh. home page doesn't have passwords - they are in .htpasswd
Are you using ApachAuth or TemplateAuth?
Main needs to be changable by RegistrationAgent for users to register to the site.
The default setting for AuthScripts - edit and save should require login - along with a bunch of other scripts.
[03:45]
dj_segfaultgac410: That's true. What the affected users are seeing is that they are trying to reset their passwords and it's saying it doesn't have an email address for them. I was assuming it needs to get that from the user form on the user page. Is that not the case? [03:47]
gac410No - email addresses should be stored in .htpasswd.
Depending on password hash chosen, file is formatted loginname:passwordhash:email@address
[03:47]
dj_segfaultHm. checking... [03:48]
MarianBanicagood night [03:48]
gac410If you try maintiaining .htpasswd with the apache htpasswd utility you will wipe out your email addresses.
Goodnight MarianBanica
[03:48]
dj_segfaultgac410: In this case I can just edit it to put in the email address. I see many accounts are missing the email address. Could not being able to create/edit in Main cause that? [03:50]
gac410maybe? be very careful - if you edit and someone registers or resets password while editor is open ... boom [03:51]
dj_segfaultthey all know they can't do squat till I fix the problem. No pressure, eh? [03:52]
gac410chmod -w to make the file read-only. Foswiki should disable password reset, registraiton, etc. [03:53]
dj_segfaultIf I do that they won't be able to change their password. O you mean temporarily. Yeah, that's a good idea
So not having a user form on the user's page shouldn't cause problems? Though I'll try to fix that too.
[03:54]
gac410You are better off with a user form
But more important are WikiUsers topic. and .htpasswd file.
WikiUsers is the file used by the mapper.
[03:55]
dj_segfaultThere's a li entry for them but the page doesn't exist. It's got a ? next to it. [03:57]
gac410I *think* that is okay - I'd push in an email address and then see if they can change / reset password [03:58]
dj_segfaultSo I guess I should go to those links to create the pages. Presumably there's some magic that will add the user form to them [03:58]
gac410Should work fine without a user topic. Just deleted one and things still work. [04:00]
dj_segfaultWait, is the email address used in the hash for the password in .htpasswd? Is it safe to edit the file and put that in? I doubt it is, but just asking. [04:00]
gac410what type of hash?
no - email is not used. The hashes are all apache compatibile. It doesn' t know about email
Just the file format - we "extend" it with an added field for email. Colon delimited
[04:00]
dj_segfaultmd5 [04:01]
gac410yeah pretty sure that is still safe - just append :email@address
(But back up the file :-)
[04:02]
dj_segfaultSweet. here it goes. Thanks as always, gac410. Your help (and others) has been immesurable
Yes, already backed up. Been there done that.
[04:02]
gac410When you click the ? to create a missing user - it puts you in edit - down on the bottom right of the screen is a button to Add a form. Add the System.UserForm. [04:04]
dj_segfaultWill do.
Wait, I think I know why the email thing happened! I had asked previously how I can authorize new accounts, and someone told me the only way to do it was to change it so the confirm emails go to me instead of the new user signing up. I think because of that it doesn't have the user's email address. Now I have to remember how I did that and undo it.
[04:04]
gac410No - that's just the confirmation email - The user still enters their real email. [04:06]
dj_segfaultAh, and I see the email addresses are in the registration request email.
Maybe they didn't enter it? No that can't be because the email address is in the "Registration request by Foo Bar" emails. So this is going to be an ongoing problem until I figure it out.
[04:07]
gac410if you can figure out why the emails are not written to .htpasswd, you might have found a bug. but failures writing topics, etc. might break other stuff. [04:08]
dj_segfaultTrue. I'll fix the permissions on Main after I fix .htpasswd, then try creating a new account (I have my own mail server so I have unlimited email addresses) [04:10]
gac410you can even use the same address over and over. No limit on sharing email addresses between accounts. [04:10]
dj_segfaultOh, I thought it had to be unique. That's handy. [04:11]
gac410I suppose that would be a nice feature though - setting to require unique email. [04:12]
......... (idle for 43mn)
dj_segfaultgac410: I fixed permissions on Main and put in the passwords and creating a new test account worked perfect! All betta. Thanks again. [04:55]
gac410great. yw. [04:55]
dj_segfaultIs it safe to have .htpasswd chmod to 640? [05:03]
gac410Foswiki needs read/write. Group might be needed for apache if cgi user is different.
so 640 sounds okay. assuming nobody in the group that can read the file is going to be evil
[05:06]
.... (idle for 18mn)
***gac410 has left [05:25]
..................................................... (idle for 4h22mn)
ChanServ sets mode: +o Babar [09:47]
...... (idle for 25mn)
padraig_lennonHi all.. Just wondering what is the best approach to debugging slow searches? Since I upgraded to 1.1.4 my search statements (mainly query) are quite slow.. Don't know how to debug the issue however..
Any suggestions?
[10:12]
pharveycan you give an example ? [10:13]
padraig_lennonhttp://pastebin.com/FViWFwGj - Can't really quantify it.. It used to be quite quick but now takes about 10s to search ~400 topics..
Thats just an example of a typical one..
[10:15]
pharveythere were some fixes that better handle mangled .txt files that are inconsistent with ,v file
that's the only concern for slowness I was aware of... but I didn't measure any big problems... but maybe I didn't test properly. Hrm.
padraig_lennon: are you using RcsWrap or RcsLite? Try swapping
are you using fcgid/mod_perl?
[10:16]
padraig_lennonRcsWrap - will swap it now.. How could I go about testing it? Just general tips would be great..
No mod_perl/fcgi kept crashing on the search pages for me..
[10:17]
pharveytimeouts?
RcsLite is (sometimes much) faster than RcsWrap as long as ,v files aren't huge
for big histories, RcsWrap is faster
FWIW I'm curious why you've got "fields[name='Status'].value='NEW'" instead of just "Status='NEW'"
[10:18]
padraig_lennonThat didn't really work.. ~18 secs now for the same page.. Yes it was timeouts on the searches.. [10:19]
pharveyAre your WebNotify topics very large? SubscribePlugin appears to be quite slow on foswiki.org, but most people don't have much in WebNotify... and it hasn't changed much since 1.1.3 [10:21]
padraig_lennonWas using examples from http://foswiki.org/System/QuerySearch [10:21]
pharveyd'oh, the example below THOSE examples are more idiomatic QuerySearches :) [10:22]
padraig_lennonNope.. Quite small actually.. Only about 20 topics in the same web as the search.. [10:22]
pharveyouch [10:22]
padraig_lennonidiomatic? [10:22]
pharveyer, typical, I should say
you've used the "long form"
[10:23]
padraig_lennonIt would be great to get some more examples in QuerySearch.. [10:23]
pharveybut it should evaluate to the same logical query anyway [10:23]
padraig_lennonHow would you rewrite it?
Don't mind about the format part..
[10:23]
pharveyjust "Status='NEW'"
I'd also use more newlines
padraig_lennon: do you have a large .htpasswd file (how many lines/users?)
assuming you us HtPasswdUser
[10:24]
padraig_lennon283 [10:25]
Babarpadraig_lennon: you could always try to profile it using NYTProf, but I doubt that will be much helpful [10:25]
pharveyI'd be interested in its output :)
I'm concerned we've optimized for fcgid/mod_perl and perhaps we're doing something expensive for plain old cgi users
padraig_lennon: any faster if you omit order="created" reverse="on" ?
[10:26]
padraig_lennonBabar - Will check out http://foswiki.org/Support/NYTProfDebugging [10:27]
pharveyoh - what does the DataForm look like? Does it contain any SEARCHes? [10:27]
padraig_lennonpharvey will try now.. [10:27]
pharveyhi ArthurClemens [10:27]
padraig_lennonpharvey - That might be something to look at.. I'll give NYTProf a go and report back.. [10:29]
pharveyk [10:29]
padraig_lennonpharvey "I'd also use more newlines" what do you mean by that? [10:35]
pharveypadraig_lennon: http://pastebin.com/SYyzewn4 [10:39]
padraig_lennonFoswiki::Sandbox::CORE:readline (opcode) seems to be the culprit.. [10:39]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Sandbox::CORE [ (Foswiki login) PerlDoc ] [10:39]
padraig_lennon92 2 1 39.8s 39.8s Foswiki::Sandbox::::CORE:readline Foswiki::Sandbox::CORE:readline (opcode) [10:39]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Sandbox [ (Foswiki login) PerlDoc ] [10:39]
pharveywell, that's a very low-level function - need to see what's calling those, and higher and higher until we see why there's so much rcs chattiness [10:40]
padraig_lennonI do have a task open about a Query match.. Obviously something is messed up.. [10:40]
pharveyreally? Which task? [10:40]
padraig_lennonhttp://foswiki.org/Tasks/Item11386 [10:41]
pharveyAh. Did you follow the work-around?
Anyway, you're not using =~ in this query
[10:41]
padraig_lennonI have checked it again against the Foswiki.spec and it is the same in Localconfig
The newlines look much better all right.. Thanks
[10:41]
pharveypadraig_lennon: if there's any way you could share your nytprof output, I'd love to look at it [10:44]
padraig_lennonCould I send it privately? [10:45]
pharveyalso, did you establish if your DataForm(s) contain any SEARCHes or other macros
sure
[10:45]
padraig_lennonIt does yes.. I will try to rework them.. [10:45]
pharveywell, that's unfortunate - 1.1.4 shouldn't be *that* much slower. Any way you can confidently benchmark it?
I've often used time ./view -topic Web.Topic -foo bar -baz blah
on the command line
[10:45]
............................... (idle for 2h33mn)
SvenDowideithey pharvey how's unicode :p
SvenDowideit might actually have time for foswiki in a week or so :D
[13:19]
............ (idle for 59mn)
gac410hm. Thinking about my .htpasswd cache reset changes. Does is apply on a single foswiki with fcgi/fastcgi? Each foswiki.fcgid would have it's own local password cache, correct? [14:18]
.............................................................................................. (idle for 7h47mn)
ArthurClemenserm. because text blocks are not put inside p tags, :last-child doesn't pick the text but the element above it [22:05]
pharveySvenDowideit, unicode branch? Dunno - I did try a store2 merge a few weeks ago but got called away [22:15]
SvenDowideitArthurClemens i've been mulling making out p blocks useful for f2.0 :)
i have an inkling of an idea, and its not gone away over the flight
pharvey harumpf :p
[22:16]
pharveyI've been poking at a Foswiki::DOM over my holidays [22:17]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::DOM [ (Foswiki login) PerlDoc ] [22:17]
SvenDowideitbooooooo [22:17]
pharveybut now you're back I'll try a merge today [22:17]
SvenDowideiti don't expect to do much on store2, but i have actually run the FoswikiSuite yesterday, so never know [22:17]
pharveycool [22:18]
SvenDowideit266 more failures to fixorate [22:18]
pharveyI know, it's w00t-tastic, just need to avoid these things going stale, and er, need to replace a bunch of things with Foswiki::Func::readTopic [22:18]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Func [ (Foswiki login) PerlDoc ] [22:18]
SvenDowideitoh, its way past stale :) [22:19]
pharveyon svn-trunk
hence how long my last aborted merge took :/
[22:19]
SvenDowideitgrin
SvenDowideit dissappears again - was awake since 3am - bloody possums
[22:21]
ArthurClemenshttp://foswiki.org/Tasks/Item11316 has a patch that needs to be unitested [22:23]
gac410ArthurClemens: I assume that will break a bunch of unit tests - since it changes rendering around - Does it need new tests, or just patch, and then patch the tests to work again. [22:25]
pharveyI hope it's just fixing up other tests
but reading the patch might inspire some new simple tests
[22:27]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)