#foswiki 2012-01-12,Thu

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
pharveygac410, Babar - what is your understanding of UnitTestContrib wrt the Foswiki singleton/session - tests shouldn't depend on one being there already? Or should FoswikiTestCase create one for you in set_up?
SvenDowideit ^
[00:09]
Babarhum... I think when one needs a session, one creates it [00:10]
pharveyright [00:10]
Babarthe famous my $fatwilly = new Foswiki::Session; or something [00:10]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Session [ (Foswiki login) PerlDoc ] [00:10]
pharveySvenDowideit added $this->createNewFoswikiSession(), which urgently needs to be used in place of the $fatwilly mess - I've been trying to clean up inconsistent $Foswiki::Plugins::SESSION
as I clean up, I'm just finding a bunch of tests that seem to assume there's a left-over {session} lying around from somewhere else
and.. the bigger question... do we ever want to have more than one Foswiki session instantiated at a time.. should Foswiki->finish() undef $Foswiki::Plugins::SESSION
I think it should, because there's a bit of code in Foswiki.pm which does $Foswiki::Plugins::SESSION = $this, so I think anybody calling Foswiki->new() has to expect that $Foswiki::Plugins::SESSION is going to be clobbered
[00:11]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/DM3iag
[foswiki/master] Item10244: menu.css has been moved to JQueryMenuSkinBarDefault - PadraigLennon
[00:17]
***GithubBot has left [00:17]
FoswikiBothttp://foswiki.org/Tasks/Item10244 [ Item10244: Enhancements to JQueryMenuSkin ] [00:17]
........ (idle for 35mn)
gac410MichaelDaum, anyone else using alternative UserMappers - I've changed the API a bit to expect the mapper to throw errors when something goes wrong, rather than returning a oh-so-uninformative return code zero.
Also all messages now are "maketext" so that the mapper interface can be translated.
checked into trunk for now.
[00:52]
MichaelDaum - Looking at LdapUserMapping.pm - I don't think it implements the functions that I changed to throw errors. [00:59]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/LlEpLw
[foswiki/master] Item11196: Better feedback from UserMapping - GeorgeClark
[01:00]
***GithubBot has left [01:00]
FoswikiBothttp://foswiki.org/Tasks/Item11196 [01:00]
pharveyoh jeez
Foswiki::UI creates a new Foswiki session?!
[01:14]
gac410hi pharvey [01:14]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::UI [ (Foswiki login) PerlDoc ] [01:14]
pharveythat's ok
don't panic... :)
pharvey going a bit mad
[01:14]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/lKmdfg
[foswiki/master] Item11196: perltidy and misc. cleanup - GeorgeClark
[01:15]
***GithubBot has left [01:15]
pharveyhi George [01:15]
Babarjeez, pharvey is up
time for me to disappear :)
[01:16]
pharveyhehe [01:16]
gac410g'night Babar [01:16]
Babarn8 George, good day Paul :) [01:16]
pharveyon the bright side, I think I'm reducing the number of times we create new Foswiki sessions needlessly [01:17]
gac410Are you changing them to ::new() at the same time? [01:18]
Babaroh George, one thing I noticed and forgot to tell you... your unit test modification for HtPasswd have side-effects on the config, that's bad
I don't remember exactly what, but you're setting some variables
one day we should reset $Foswiki::cfg when instantiating a new test :)
[01:18]
pharveyI'm removing all ->new() and ->finish, replacing with $this->createNewFoswikiSession()
Babar: I think we already do reset them
if it inherits from FoswikiTestCase, set_up saves the config into $this->{__FoswikiSafe} and tear_down restores it
[01:20]
gac410right - I've run full suite as well as password tests - no side effects that I could see unless I set GlobalCache in my real LSC - which is why I turned it off in FoswikiTestCase setup [01:22]
............................................. (idle for 3h41mn)
***gac410 has left [05:03]
........................... (idle for 2h10mn)
ChanServ sets mode: +o MichaelDaum [07:13]
................. (idle for 1h22mn)
Babar sets mode: +oooo AndreU Colas JulianLevens LarsEik
Babar sets mode: +oo Lynnwood pharvey
[08:35]
Babaroh Julian... I never finished my email reply to you :( [08:35]
JulianLevensWell hurry up then ;) [08:37]
Babarsent.
not sure it will help though
JulianLevens: and checking my /usr/lib/ruby/vendor_ruby/chef/provider/git.rb is interesting :)
JulianLevens: in case you read the logs, it's doing a git ls-remote from the checked out directory
[08:44]
JulianLevensBabar: it will at least keep me thinking [08:56]
.... (idle for 16mn)
***Babar sets mode: +ooo Colas CDot JulianLevens [09:12]
......................... (idle for 2h0mn)
CDotSvenDowideit: give some thought to http://foswiki.org/Development/AddPackageNavigationToPerlDoc please [11:12]
......................... (idle for 2h3mn)
***ChanServ sets mode: +o OliverKrueger
OliverKrueger sets mode: +ooo AndreU MartinCleaver terceiro
[13:15]
........ (idle for 38mn)
alice|wlhello, I have a problem with spans in the wysiwyg editor. They get added around wiki words and I dont know why [13:54]
kind of this bug: http://foswiki.org/Tasks/Item8690 but for every wiki link as the spans get added on every second save [14:01]
........ (idle for 35mn)
CDotalice|wl: what is in the spans? [14:36]
alice|wl<span class="WYSIWYG_LINK">SpanSpan</span> test</p>
they get added on second save in wysiwyg. The tml is: SpanSpan test
[14:38]
padraig_lennongac410 - Thanks a million for the tip yesterday to touch all .txt and .txt,v files. Performance has drastically improved since I did this..
http://irclogs.foswiki.org/bin/irclogger_log/foswiki?date=2012-01-11,Wed&sel=354#l350
[14:43]
gac410excellent padraig_lennon - that tells us that it is rcs that was your culprit. [14:46]
padraig_lennonLooks like it all right... Thanks again.. [14:47]
gac410(Of course that means that foswiki now trusts the TOPICINFO meta which is most likely out of date on your system. [14:47]
padraig_lennonHmm.. I think thats something I can live with though.. [14:48]
gac410So the next save of a topic in this condition might not be correctly handled in revision tracking. [14:48]
padraig_lennonTo be totally honest the revision tracking is VERY rarely used.. [14:49]
gac410if someone changes a "touched" topic that had stale rcs info, and then reverts, it *might* revert back to the last rcs version which would remove the external edits. Not really sure. [14:51]
CDotalice|wl: sounds like a glitch in the converter. What rev of WysiwygPlugin (and |TinyMCEPlugin) are you using? (look at the bottom of their respective topics in your System web)
gac410: a *save* should be handled OK. I won't speak for anything else, though!
CDot notes that when the .txt is more recent than the .txt,v, then the .txt is *not* trusted
[14:57]
gac410right. he had a huge search performance problem on 1.1.4 - but had large number of topics with "untrusted" externally modified txt files.
touching all the files to get consistent timestamps fixed search performance.
[15:00]
CDotgotcha. [15:11]
***OliverKrueger sets mode: +v WikiRingBot [15:22]
MichaelDaumjust got an email foswiki has reached the preselection process applying for the call for projects [15:36]
OliverKruegercool. [15:37]
MichaelDaum"call for projects" is done by linux new media sponsoring a free booth on the cebit fair
OliverKrueger, I forwarded the email to you
[15:37]
OliverKruegerWe need more people. [15:38]
***OliverKrueger sets mode: +o gac410 [15:38]
OliverKruegerthanks. [15:38]
MichaelDaumI will email to foswiki-discussion
now
[15:38]
gac410MichaelDaum: did you see my mapper changes - I think Ldap is safe - the added "throw" were all in the group management code. [15:38]
MichaelDaumgac410, seen the diff, had no time to dig into it deeper. [15:38]
gac410Ldap doesnt do add/delete group membership - at least I didn't see it in the code. [15:39]
MichaelDaumright. no it doesnt. [15:40]
gac410so my changes are probably inconsequential for ldap anyway. [15:41]
MichaelDaumldap directories are managed by a separate staff.
for the better or worth
[15:41]
gac410right. often the AD staff now :( [15:42]
OliverKruegerMichaelDaum: I'll try to contact Renee from the Perl staff, maybe he's got some hints, since they were picked last time. [15:43]
MichaelDaumlong term goal is to implement a PluggableUserMapper and have connectors to all sorts of authorities: topics, ldap, sql, openid, oauth.
pluggable user mapper will cache users as they are checking in first time by fetching and caching a person record from the respective backend
these go into a single central db for fast access
[15:43]
gac410in the back of my head is thoughts of creating a mapper for Sympa email list manager, group becomes equivalent to mailing list. And move some of the email code into the list handler. [15:45]
.... (idle for 17mn)
MichaelDaumtough question: how many people are contributing to foswiki?
I think there's no single number for that
[16:02]
gac410yeah difficult - imo people who take the time to open tasks, request enhancements, etc. are contributors as well in their own ways. [16:04]
OliverKruegerwe have some oloh stats. [16:04]
MichaelDaum(1) number of people that contributed to the current code base (2) number of people with checkin rights (3) number of people that contributed to any foswiki release (4) number contributors active within the last 6 months [16:04]
OliverKruegerplus contributors to the f.o. (without checkin rights) [16:05]
MichaelDaumgac410, right. (5) number of users registered on foswiki.org [16:05]
alice|wl(6) number of users idle in irc [16:06]
gac410translators on t.f.o [16:06]
OliverKruegerlets ask the T guys. They know how to do marketing. ;) [16:07]
alice|wlCDot: thats WysiWyg: Topic revision: 1 (29 Nov 2009 - 22:03:41) adn TinyMce: Topic revision: 5 (02 Dec 2009 - 11:44:35) [16:07]
OliverKruegeralice|wl: sounds old. [16:07]
alice|wlit is, and I dont think I can update easily :/ [16:08]
OliverKruegeralice|wl: which version of foswiki? [16:08]
CDotCDot suspects alice|wl isn't looking in the right place. The Version/Release is what we need.
*not* the topic revision.
[16:08]
gac410System/InstalledPlugins is the place to look [16:08]
alice|wlTinyMCEPlugin (25 Nov 2009, $Rev: 5629 (2009-11-25) $): Integration of the Tiny MCE WYSIWYG Editor --- WysiwygPlugin (18 Sep 2009, $Rev: 5356 (2009-10-22) $): Translator framework for Wysiwyg editors
Foswiki-1.0.6, Sun, 21 Jun 2009, build 4272
[16:11]
OliverKruegerWhat keeps you from updating? [16:12]
alice|wlI offerd but they refused, there are some custom modules that broke when I tried on testenv [16:14]
OliverKruegerYou can update TMCE and WYSIWYG seperately. [16:15]
gac410Do the plugins go that far backwards with compatibility? I don't think you should try to install any updates to the plugins - was this span issue always there? If not, I wonder what changed.
Latest TMCE needs latest JQuery, iirc
hm. there are no compat warnings though on either of them.
It could also be an issue with a new version of JavaScript in a browser update having issues with the old version of TMCE
[16:16]
MichaelDaumguys, please help out at http://foswiki.org/Community/FoswikiCeBIT2012#Some_numbers_required [16:23]
CDotalice|wl: I'm afraid the only answer I have is "update the plugins" [16:24]
alice|wlyes, makes sense. I probably hoped for a hint where to hack this. [16:25]
CDotno, it's not that simple. IIRC it was a very complex fix. [16:25]
OliverKruegerMichaelDaum: we should probably point out, that we have an association behind our project. [16:31]
MichaelDaumy [16:31]
BabarMichaelDaum: trying to come up with some figures, but the translators are maybe not counted if I count only the commits [16:36]
OliverKruegercommitters vary between 7 and 21. [16:37]
CDotMichaelDaum: added some (though not all) numbers [16:39]
MichaelDaumBabar our git nerd ... lovely [16:41]
OliverKrueger:) [16:41]
MichaelDaumCDot, do these numbers include twiki contributions as well? [16:41]
OliverKruegerBabar: you missed the T times. [16:41]
MichaelDaumtea times [16:41]
CDotup to the point of the fork, yes [16:41]
MichaelDaumCDot, perfecto [16:42]
BabarOliverKrueger: I can run the same thing on t-time :p [16:42]
OliverKrueger;) [16:42]
MichaelDaumCDot, where do you have this number from ... 197? [16:42]
BabarOverall: 10851 commits, 103 committers on this branch
but I would need to get rid of a few years :)
[16:42]
CDotsort AUTHORS | uniq | wc (roughtly) [16:42]
MichaelDaumokay. so some numbers include plugins, some are core only ... like AUTHORS. [16:43]
CDotright. Problem with that? [16:43]
OliverKruegeroh, I still have a T wiki url in AUTHORS. [16:44]
CDotOliverKrueger: so do a lot of folks who are in both lists [16:47]
gac410Have we made any attempt to keep AUTHORS up to date? [16:49]
OliverKruegerno, I dont think so. [16:49]
gac410SvenDowideit: Did you see the pending request to checkin? [16:49]
CDotgac410: nope. IMHO automation ought to do it. [16:52]
gac410would be nice. [16:52]
CDotwhich makes the current exercise interesting.... [16:52]
gac410We really need a solution to allow doc updates on <gasp> the wiki. [16:53]
CDotaye; I looked out the scripts I wrote, but there are some flaws [16:53]
gac410Might bring in some more contributors who can't face the SVN hurdle. [16:53]
CDotCDot checked them into tools, but no-one has touched them since AFAIK [16:54]
gac410Figure we'd need a checkout of System, and then a script to copy changed files from public System to shadow System and do the checkin
Copy should also reset the TOPICINFO
[16:54]
CDotthat's sorta what the scripts did, IIRC, but with some extra smarts [16:55]
gac410gac410 goes to look. [16:55]
CDotto allow keeping a comment discussion on the doc page on f.o [16:55]
OliverKruegershall I check AUTHORS lines against Foswiki:Main/WebTopicList and rewrite AUTHORS? [16:55]
FoswikiBothttp://foswiki.org/Main/WebTopicList [ WebTopicList ] [16:55]
gac410oh - that would be nice.
Probably bigger issue with AUTHORS is the list of committers on svn who never added themselves.
[16:55]
CDotgac410: tools/mergeDoc.pl [16:56]
OliverKruegerDo we have such a list?
yes, AUTHORS is just cosmetics.
[16:57]
gac410commiters who are not in authors? no idea. Can we grep the author names from the svn log? Or maybe Sven has a list of who has checkin authority [16:58]
CDotCDot has that list [16:58]
gac410(though authorized list doesn't mean that they have actually authored something. [16:59]
CDotright; or done so recently
better to analyse the repo
[16:59]
gac410CDot: has mergeDoc ever been used? [17:02]
CDotnope [17:03]
gac410Sven added a DocumentationGroup to f.o to allow selected users to update the System web. [17:03]
CDotI wrote it, tested it, try to pass it on to hwsnbn - who ignored it, and continued complaining about the lack of a solution. [17:03]
gac410:-)
Maybe we can get it running - that would make it *much* easier to improve the core documentation.
[17:03]
CDotI think it's overcomplicated TBH. But the prob with the topics on f.ois the auditing of the content [17:04]
gac410the commit emails would make manual auditing possible - Like Babar and is "you didn't perltidy" audits :-)
(and his ... not is)
[17:05]
MichaelDaumif I am not countign wrong there've been roughly 22 active comitters during the recent 6 months [17:06]
CDotthat sounds about right [17:07]
MichaelDaum62 contributed to foswiki
since the fork
[17:08]
CDotwow; amazing sunset tonight. The skies on fire, and a fleet of alien saucers is holding station over Chester :-) [17:08]
OliverKruegerOliverKrueger still fights with svn/grep/wc to verify the numbers. ;) [17:10]
MichaelDaumreading AUTHORS - cutting out some lines - gives me 114 "authors"
that's almost 115, the number of people with checkin rights.
[17:11]
OliverKruegerok, got 62, too. [17:16]
MichaelDaum6 comitters active on the other project during the last 6 months. most recent commit september '11. [17:17]
OliverKrueger21 comitters since 2011-07-13. [17:23]
Babargac410: you also have the list of people having checkin authority, as you have access to foswiki.org :) [17:23]
CDotgac410: /home/svn/nextwiki.access is what you want [17:32]
gac410ah - thanks. Navigating around other than foswiki itself is a bit challenging. [17:33]
.......... (idle for 45mn)
gac410 wonders - could we do something like Foswiki:Extensions/Testing/PackageViewTemplate in a "Documentation" web that parallels System. One tab %INCLUDES the "System document" and another for local discussion / feedback and notes. [18:18]
FoswikiBothttp://foswiki.org/Extensions/Testing/PackageViewTemplate [ PackageViewTemplate < Extensions/Testing < Foswiki ] [18:18]
gac410If user is member of DocumentationGroup, then include an edit button for the included System topic, otherwise edits / comments collect on the Documentation.blah topic.
Or maybe a view template for System?
[18:20]
........... (idle for 51mn)
Hm. With TABPANE - is there anything to put in the uri like an anchor, or other parameter to navigate to a specific tab? Trying to use CommentPlugin with the "return" template, and a post always returns to the first tab. [19:12]
***alice|wl has left [19:18]
Plazmahmm.. i'm finding a weird issue with my css and foswiki.. css works fine on other tests sites .. but when i have <a href="#" class="myclass"> and paste that into the raw html editor.. save it.. it doesn't seem to work
ahh
when viewing the source, it seems class="foswikiCurrentTopicLink" overwrites my class for link formatting
for my <a href>...
hmm.. it's interpreting it as a list it seems wehn i don't necessarily want it to
[19:18]
...... (idle for 29mn)
pharvey_Plazma: what's the actual markup you've entered into Foswiki? [19:51]
I *think* alice|wl should be able to update WysiwygPlugin by itself on 1.0.6 ... or at least I'm not aware of any API dependencies that would prevent it. I seem to recall that TMCE had some adjustments to match it, though... [20:00]
SvenDowideitpharvey_, you don't sleep do you [20:02]
pharvey_I fell asleep 19:30 yesterday, so I'm up early :) [20:03]
SvenDowideitfriggen :p
went to sleep at 21:30, woke at 0400
[20:03]
pharvey_gac410, awesome find touching those files to help padraig's 1.1.4 perf [20:03]
SvenDowideitwhich is a 2 hour improvement on yesterday [20:03]
pharvey_d'oh :)
it has been so cold here
wearing jumpers, even fired up the heating yesterday
[20:04]
SvenDowideithehe :)
33 degrees yesterday
and i'm back to finding 21 degrees a ilttle cold
mad.
[20:04]
pharvey_down to 6 C yesterday, about 20 max :) [20:04]
SvenDowideitonly 4 weeks ago, i went out in shorts and tshirt, because it was a hot 7 degrees [20:05]
pharvey_hehe [20:05]
SvenDowideitit amazes me how relative temperature is [20:05]
pharvey_pharvey_ wonders when Canberra's summer will start... probably next year [20:05]
SvenDowideityou had it
on wednesday
or was that tuesday
[20:05]
pharvey_pff [20:06]
SvenDowideit(or so i'm reliably told on the mtb-oz mailing list)
font of potification and mindless banter since the dawn of, well, mtb-oz
[20:06]
pharvey_oh, SvenDowideit - I've been meaning to ask someone who might know - do we ever have two Foswiki objects instantiated simultaneously [20:07]
SvenDowideiti really really hope not
as that is broken on store2
[20:07]
pharvey_er, the design I mean [20:07]
SvenDowideitand imo risky in fw / tmwiki
as there are hidden globals around
[20:08]
pharvey_it's only in the unit tests it happens... I've been ironing it out
but seem to have a chicken/egg problem in some of the Foswiki::UI tests
[20:08]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::UI [ (Foswiki login) PerlDoc ] [20:08]
SvenDowideitcourse, cdot uses it havily in the unit tests, but that is dissappearing fast, as store2 makes those tests fail
look at what store2 does
as i think i've fixed those
[20:08]
pharvey_ok [20:09]
SvenDowideityou're sadly re-producing some things i've already done in there
but its all useful i think
[20:09]
pharvey_I only wanted to fix the one thing I'm indirectly working on
and got sucked into a lot more
hrm
[20:09]
SvenDowideitsounds like life :) [20:09]
pharvey_good to be back home? Or was it too much fun over there? [20:10]
SvenDowideitboth :)
got such a huge backlog its not funny tho, so its quite discombobulating
[20:11]
pharvey_speaking of backlog
it occurred to us we couldn't remember the last time mongo crashed
hehe
[20:13]
SvenDowideitWOW [20:13]
pharvey_'course, we're using a some-months-old version of trunk [20:13]
SvenDowideitvery sensible, cos if it works... [20:14]
pharvey_but yeah, I haven't had to poke it since... since probably september [20:14]
SvenDowideitSvenDowideit needs nbn :/ [20:16]
pharvey_d'oh :) [20:16]
SvenDowideitsexy!
can you get temi to join g+ and :)
[20:16]
pharvey_it's a phylogeny which mixes wiki-data (the character features of the nodes) with a newick tree phylogeny, and various external data sources
g+, I can barely convince him to join IRC :P
[20:16]
SvenDowideitgrin
get garry to get you and him webcams
and then we can do a hangout with garry and make it part of the fun
[20:17]
pharvey_finally! a use for office webcams! [20:18]
gac410SvenDowideit: Did you see the recent request for checkin authority [20:18]
SvenDowideitwith that kind of tool, workplace location really becomes pointless
gac410, yup
[20:18]
gac410okay - [20:19]
SvenDowideitwill do it today
unless someone else gets there first >:}
[20:19]
gac410sometimes they slip through the cracks - figured worth a quick pointout [20:19]
SvenDowideityup
SvenDowideit should really write a plugin to do it, so we can just click a button
[20:19]
gac410Anyone know how to craft a url to open a topic onto a particular tab? [20:19]
SvenDowideitSvenDowideit wrote a list of things i want to do this year...
ran out of paper
particular tab?
[20:19]
gac410yeah - experimenting with a view template for System that would let anyone post feedback into a tab. But post from comment always returns to the first tab. [20:20]
SvenDowideiti think you can't influence that as its transparent
oh, you mean jquery tab?
[20:20]
gac410yeah [20:20]
SvenDowideitthat really does need to exist
cos the websearch tabs are busted that way too
though ArthurClemens might ahve done something in there...
[20:21]
pharvey_gac410: if you give the tab an ID, you can say #ID
IIRC
[20:21]
gac410That's what I thought but it doesn't seem to work for me. [20:21]
pharvey_well, it used to. Raise a task [20:21]
Plazmapharvey_: hey sorry.. i'm not entering any actual markup into the wiki.. just raw html in the HTML edit [20:22]
SvenDowideitoh dear [20:22]
pharvey_Plazma: I ask because, if you indent with three spaces, sometimes Foswiki thinks you're entering a <dl> list [20:22]
Plazmahmm [20:22]
gac410There is a #!JqTab23453 random link but it changes with every load. [20:22]
Plazmai do use a lot of whitespace.. maybe that's it
worth a shot at least
4 space tabs..etc
[20:22]
pharvey_Plazma: wrap such code in <literal></literal> to prevent [20:23]
Plazmaeven in raw html edit? [20:23]
ArthurClemensSvenDowideit: there is an open task about the tab ids [20:23]
pharvey_to prevent the renderer from looking for TML markup [20:23]
gac410ah - great - thanks ArthurClemens [20:23]
ArthurClemensbothers me as well [20:23]
pharvey_"raw html edit" - I'm not sure what that is [20:23]
Plazmapharvey_: there's a view/editor for just html
wiki markup, html, and wysiwg
[20:23]
ArthurClemensMichaelDaum has provided a jquery code to address the tab, but it is not a final fix [20:24]
Plazmathat's what i'm attempting to refer to.. [20:24]
SvenDowideitArthurClemens, ta :) thought you'd know [20:24]
pharvey_you must have a different wiki to me - I only get WYSIWYG and raw :)
raw/wikitext
[20:24]
gac410There is a html button in TMCE that opens a html view - is that what you are referring to? [20:24]
pharvey_regardless, it's not the editing that counts, it's the display. Foswiki will try to interpret TML formatting codes in all the markup it displays, unless you wrap it in <literal> or <verbatim> [20:25]
Plazmagac410: yep [20:25]
pharvey_ah
you're the 3rd person I've ever heard of using that button on purpose :)
[20:25]
Plazmahehe [20:25]
ArthurClemenshttp://foswiki.org/Tasks/Item10918 [20:25]
Plazmai do like the wiki edit better, but i think i screwed something up in it with a stylesheet and didn't have a previous rev :P
it wasn't important, just a sandbox page
[20:25]
pharvey_beware of TinyMCE - it is extremely strict about producing XHTML-strict markup - so I guess it might mangle some tags/markup it doesn't know about [20:26]
gac410For System web - thinking about a SystemViewTemplate. Remove edit button except for members of documentation group. Use a feedback tab to collect general input. Let DocumentationGroup edit, and try to implement CDot's tools/mergeDoc.pl
so a continuation of what Sven started earlier last year
[20:26]
pharvey_<sticky><whatever><markup><you><want></sticky> is the way to get WYSIWYG out of the way of mangling stuff you don't want it to mangle
gac410, tried addressing an anchor within the tab you want to open?
[20:27]
gac410yeah - didn't seem to help. though might have done it wrong.
The anchor in tab2 on a reload seems to open to bottom of Tab1
[20:28]
pharvey_pharvey_ needs a new brain
is my google chrome localizing its preferences pane? It used to say "under the hood", now it says "under the bonnet"
[20:32]
SvenDowideitlol [20:34]
gac410ArthurClemens: I noticed many of the buttons have span class="foswikiRequiresChangePermission" ... Is there some magic way to use that to remove/disable any links that can't be used by the current user? [20:34]
SvenDowideitmy easter bonnet
gac410, yes
i use tmpl magic
there is (or i requested there to be) a hasChangePriv context
and then in either famfamfam or widgets
[20:34]
Plazmapharvey_: ahh the <literal> did make things a bit better but for some reason my css class isn't working [20:35]
SvenDowideiti use that context to switch things off [20:35]
ArthurClemensundocumented of course [20:35]
gac410any example you can point to? I know how to do it by modifying templates. Figured the css might make it easier. [20:35]
SvenDowideitArthurClemens, really? :( [20:35]
Plazmabut i need to check something first [20:35]
ArthurClemenswell, I'm creating new docs anyway [20:35]
SvenDowideitArthurClemens, >:} [20:36]
ArthurClemensah, this one is documented [20:36]
SvenDowideithttp://foswiki.org/System/IfStatements#Context_identifiers
where? i might be blind
[20:36]
ArthurClemensAppendix [20:37]
gac410I know about context id's - but need to do that button by button / link by link ... [20:37]
ArthurClemensI did find many undocumented classes in distributed topics [20:37]
SvenDowideitargh.
gac410, oh boy
you mean you need a DOM on the server
and thus it goes pop
[20:37]
Plazmahmm.. yea it's still not working like i expect it.. i just have a simple css class that sets text to 5em [20:38]
SvenDowideitlooks like there's no hasChangePerm context doccoed
might not exist
[20:38]
Plazmathe rest of the css file works.. just weird [20:38]
ArthurClemensPlazma: got code? [20:39]
pharvey_Plazma, is there some other style/css overriding it? What does firebug say? [20:39]
gac410Okay - AppendixCSS documents that .foswikiRequiresChangePermission exists. Any hints on how to make it actually do something? :-D [20:40]
pharvey_pharvey_ been pretending to write a Foswiki::DOM - after looking at MoinMoin & Confluence APIs :) [20:40]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::DOM [ (Foswiki login) PerlDoc ] [20:40]
SvenDowideitpharvey, it does not exist unless theres a github branch [20:42]
pharvey_I said I was pretending [20:42]
gac410.foswikiRequiresChangePermission is not defined anywhere in any css file anywhere in release11 ... according to grep. [20:42]
pharvey_I haven't convinced myself my approach is even feasible :P [20:43]
SvenDowideitpharvey, you won't know until you stop pretending and fail [20:43]
pharvey_SvenDowideit: https://github.com/csirac2/core/tree/dom [20:45]
SvenDowideitoh dear, now i have another git tree to clone
i blame myself
are you actually using the DOM class for rendering in there atm?
[20:46]
pharvey_SvenDowideit: it's not much code yet, not really worth cloning
no, the first part was lexing, then parsing to a tree
[20:47]
SvenDowideitoh. [20:47]
pharvey_then there will be Foswiki::DOM::Writer::XHTML and so on [20:47]
SvenDowideithave you looked at marpa? [20:47]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::DOM::Writer::XHTML [ (Foswiki login) PerlDoc ] [20:47]
pharvey_Foswiki::DOM::Writer::JSON etc. [20:48]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::DOM::Writer::JSON [ (Foswiki login) PerlDoc ] [20:48]
SvenDowideitits alegedly a nice strong and permissive parser that uses a gramma thingy thing
SvenDowideit needs sleep, neurons are impeededededd
[20:48]
pharvey_doing a gramma thing for Foswiki is "interesting"... my approach was to use regexes to mark regions of the input, rather than modify it, then use an interval tree of those ranges to make the DOM hierarchy
Eg. https://github.com/csirac2/core/blob/dom/lib/Foswiki/DOM/Parser/TML/Verbatim.pm
[20:49]
gac410ArthurClemens: Thanks for pointing out Item10918 - the urlparam solution works great. [20:50]
FoswikiBothttp://foswiki.org/Tasks/Item10918 [ Item10918: I need to address a tab by id ] [20:50]
SvenDowideitoooo, interesting approach too [20:50]
Plazmapharvey_: / ArthurClemens http://jsfiddle.net/6jNcT/ [20:50]
pharvey_SvenDowideit, I've got some tests, hang on.. [20:50]
Plazmait seems to work fine outside of foswiki [20:50]
gac410So i take it in my SystemViewTemplate, somehow I need to define the .foswikiRequiresChangePermission class to hide it? [20:51]
pharvey_https://github.com/csirac2/UnitTestContrib/tree/dom/test/unit [20:51]
SvenDowideitoh dear, i have to use your one git per module thing
SvenDowideit faints and goes to have a lie down
[20:53]
pharvey_haha
sorry :P
git clone git@github.com:/foswiki/core && cd core && ./pseudo-install.pl
[20:53]
SvenDowideitna, too hard, have to go anyway [20:54]
pharvey_k, g'nightmorning [20:54]
SvenDowideitsee you laters :) [20:54]
gac410ArthurClemens: so somehow %IF{"'TOPIC' allows 'ACCESS'" then="THEN" else="ELSE"}% needs to set .foswikiRequiresChangePermission to have the attribute display:none
except allows "CHANGE"
[20:58]
ArthurClemensthat should be a class written to the body tag [20:59]
gac410using ADDTOZONE? [21:00]
ArthurClemensno, in a template
so foswiki.tmpl and derivates
like we do with foswikiNoJs
[21:00]
gac410gac410 goes to look [21:01]
ArthurClemensthen ajax calls can remove it from the body if someone logs in
I mean js code called after login through ajax
[21:01]
gac410tbh it sounds it will be easier just to delete the buttons.
ajax and js just to hid the edit button?
gac410 goes back to perl. At least I somewhat understand that.
[21:02]
ArthurClemenssorry I am jumping too fast
without ajax, so page reload, the body tag will have a class foswikiHasNoChangePermission if the user is not logged in
that is the ELSE clause
THEN could either be nothing or foswikiHasChangePermission
in css we will have: .foswikiHasNoChangePermission .foswikiRequiresChangePermission { display: none; }
Plazma: I don't see anything wrong. do you have a page on foswiki to see the effect?
[21:12]
PlazmaArthurClemens: yea,, the foswiki page isn't liking that class for some reason even when in <literal>
i've worked around it by using an inline style for just that element (which is probably better anyway)
[21:17]
ArthurClemensshould not be better
literal should work against rendering of spaces to bullet lists
in your comment you write morelinks, with s
the code says morelink, without s
[21:18]
Plazmathat's in the comment though, and it's correct in the class statements in the html [21:20]
ArthurClemenssure, but perhaps you made a typo when in foswiki
the ids really ought to be classes, but that is just Good Style
[21:21]
Plazmayea
i'm not really a designer or web guy.. so
and it looks like IE pukes on it :P
ie 9 at least
[21:21]
it needs a lot of work yet but it's getting there
need to figue out if there's a way for it to somehow know about the edges of the page.. so i can anchor them down when they float
[21:27]
profElmHi all. [21:36]
gac410ArthurClemens: If I have <body class=" ... foswikiHasNoChangePermission ..." won't that hide the whole body if it's defined as display:none [21:37]
ArthurClemensyou hide foswikiRequiresChangePermission only. that's why there are 2 classnames in this line:
.foswikiHasNoChangePermission .foswikiRequiresChangePermission { display: none; }
Plazma: float?
[21:37]
Plazmacss float
my 2 columns are floating next to eachother
but when you make it narrow it forces the sidebar underneath
[21:45]
gac410ArthurClemens: Thanks - I'm getting there - have the body rendering the correct classes - now to just define them. [21:46]
ArthurClemensPlazma: you should take a look at column layouts [21:49]
***profElm has left [21:50]
ArthurClemenstwitter-bootstrap has colums, and 960.gs of course
here is a simple one: http://www.vanseodesign.com/css/2-column-layout-code/
[21:50]
gac410wohoo! Thanks ArthurClemens - worked like a charm.
should .foswikiHasNoChangePermission .foswikiRequiresChangePermission { display: none; } be defined in one of the base css files?
[21:51]
ArthurClemensit should
but I'm not entirely sure if it should always be hidden
it would mean that you don't see edit buttons, right?
[21:52]
gac410right. It has to be optional. [21:53]
ArthurClemensso some might want to have it display a lock or grayed out
of course that can all be done in css
I'm just not sure what the best default should be
up to now we have made it visible
[21:53]
gac410But it only happens if you add the css to the body tag. So it would be safe to define it. Maybe with cookbook examples on none vs. locked,
Added the following to my SystemViewTemplate, and magic - it worked.
%TMPL:DEF{"bodyclassname"}%patternViewPage%IF{"'TOPIC' allows 'CHANGE'" then=" foswikiHasChangePermission" else=" foswikiHasNoChangePermission"}%%IF{"defined raw" then=" patternRawViewPage"}%%TMPL:END%
[21:54]
ArthurClemensy, but that code should go in the default template [21:57]
gac410Though it doesn't hide the buttons for raw view - so raw must not use that particular template. [21:58]
ArthurClemenswe could leave the css empty
.foswikiHasNoChangePermission .foswikiRequiresChangePermission { }
to be implemented by subskins
[21:58]
gac410Ah - so rather than changing template, you change the css. would that make it harder to do this per web? [21:59]
ArthurClemensyes [21:59]
gac410Showing the edit button for non-logged-in users is much more inviting for change.
If not logged in, or logged in with change permission, show buttons. If logged in without change, hide them. For foswiki.org, I was figuring the only place to hide the edit buttons is in the System web.
[22:00]
ArthurClemensgood thinking [22:03]
So: .foswikiHasNoChangePermission .foswikiLoggedIn { display: none; }
typo
if both are on the body tag, they should be concatenated: .foswikiHasNoChangePermission.foswikiLoggedIn { display: none; }
[22:14]
gac410Ah - I added a conditional if wikiguest to the template. [22:15]
ArthurClemensfoswikiLoggedIn is also new of course [22:16]
gac410I didn't include the periods. Followed example where it added " patternRawViewPage" appending with a space. [22:18]
ArthurClemenssure, but in css there should be periods [22:20]
pharveygac410, ever used the perl debugger much? I'm having trouble understanding the watch feature... not working as my understanding of watches from gdb [22:23]
gac410pharvey - nope.
ArthurClemens: I remove the space - .foswikiHasNoChangePermission.foswikiRequiresChangePermission { display: none; } and it stopped working. Need the space between the two classes
[22:23]
pharveymaybe I'm going crazy, but it seems if you watch $foo, it's going to break whenever any variable in any scope called '$foo' changes.. rather than just the $foo I care about [22:24]
gac410sounds like it's watching just by name rather than name & scope. [22:25]
ArthurClemensgac410: .foswikiHasNoChangePermission.foswikiRequiresChangePermission is not what I meant or wrote
it would mean you have both classes at the same time on the body tag
[22:26]
gac410Sorry - I obviously have no idea what I'm doing. [22:27]
ArthurClemens.foswikiHasNoChangePermission.foswikiLoggedIn
that is css talk of your idea
if logged in AND no change permission
[22:27]
gac410I changed base.css to have .foswikiHasNoChangePermission.foswikiLoggedIn {display: none; } and it broke. Feel free to scream [22:30]
ArthurClemensbreak like? [22:30]
gac410Edit button displays Or do I need to add the foswikiLoggedIn class to the body tag using %IF [22:31]
ArthurClemensonly if you want to hide the buttons
so yes
without that class it will just display
so not-logged in users will see the buttons
[22:31]
gac410oh- okay. nvm. I thought foswikiLoggedIn was set somehow automagically [22:32]
pharveyFoswikiBot: corelist Data::Dumper [22:43]
FoswikiBotpharvey: Data::Dumper was first released with perl 5.005 (released on 1998-07-22) [22:43]
........ (idle for 39mn)
gac410ArthurClemens: well I tried to change to foswikiLoggedIn and Im backed to non-functional. Template contains:
%TMPL:DEF{"bodyclassname"}%patternViewPage%IF{"'TOPIC' allows 'CHANGE'" then=".foswikiHasChangePermission" else=".foswikiHasNoChangePermission"}%%IF{"context authenticated" then=".foswikiLoggedIn"}%%IF{"defined raw" then=" patternRawViewPage"}%%TMPL:END%
and css is defined as: .patternViewPage.foswikiHasNoChangePermission.foswikiLoggedIn {display: none;}
brower shows in view css: html > body .patternViewPage.foswikiHasNoChangePermission.foswikiLoggedIn foswikiJs >
[23:22]
ArthurClemensthe period should not be in the template
only in css
use a space instead of the dot
[23:28]
gac410yeah - I've gotten rid of all of them in the template. Getting a bit closer.
I changed css to be: .foswikiHasNoChangePermission .foswikiRequiresChangePermission .foswikiLoggedIn { display: none; } */
if I remove the .foswikiLoggedIn, from the css, then it works as expected for logged in users with/without permission, but not for logged out.
[23:28]
ArthurClemensin the css there should be no spaces
space = hierarchy, like a div inside the body
literally:
.foswikiHasNoChangePermission.foswikiLoggedIn { display: none; }
[23:36]
gac410Okay - I'll play with it some more.
Don't I also need to have foswikiRequiresChangePermission - which is the class on the elements we want to hide?
[23:37]
ArthurClemensah right
its getting late here
[23:39]
gac410oops - that's for sure - blank screen now. [23:39]
ArthurClemens.foswikiHasNoChangePermission.foswikiLoggedIn .foswikiRequiresChangePermission { display: none; }
so a space before foswikiRequiresChangePermission: that are elements inside the body
[23:39]
gac410Ah... maybe it's sinking in now. [23:40]
ArthurClemenstime to search for my bed
good luck
[23:41]
gac410thanks - I suspect I'll need it :-D
good luck on your search
Wohoo .... .got it finally
now... on to CDot's script to sync System web back into SVN
[23:41]
.... (idle for 15mn)
For syncing System -> SVN should we consider an afterSaveHandler to do the commit to svn using the identity of the Wikiuser? or a cron job that syncs aggregated changes using a WikiGnome type id?
CDot's script does file merging but doesn't address the svn part. And I suspect a generic WikiGnome id might be better in that we don't have the userid/password to log in individual users into svn during commit.
[23:58]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)