#foswiki 2012-03-17,Sat

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
flexibeastSo i've mangled ControlWikiWordPlugin to produce AcronymDefinitionsPlugin - would anyone be willing to review what i've done before i package it up? [00:03]
gac410did you check it into svn? [00:05]
flexibeastNo, not yet.
Wasn't sure if i should do that in this particular case.
Since my dev set up is broken wrt being able to do svn updates of plugins.
[00:05]
gac410Up to you on whether or not you think the plugin would be useful to others. Ah yeah, you need a trunk checkout to do plugin development [00:07]
flexibeastWell, i believed i'd done the trunk checkout.
i do think the plugin might be useful to others.
i guess that means i need to solve this svn update problem.
But i can't understand what's happened, since i've just followed the standard instructions for setting stuff up ....
[00:07]
gac410having a fully functional svn or git env. is pretty important for development. Unfortunately I don't have any idea what went wrong for you. [00:09]
flexibeast*nod* Agreed on importance.
The only solution i could think of is, would it work to get a copy of someone else's .svn for the dev root?
[00:10]
gac410gac410 hates it when he looses a file. **Somewhere** I have a text file of all the commits against 1.1.5 with X marking those that are also marked in Tasks web as applying to 1.1.5.
I don't have a svn checkout of trunk root. Only the Release01x01 branch.
I use git for most things now. SVN checkout is hangin around just to do the official builds.
[00:11]
flexibeastOh okay. i personally use git for managing my emacs config file.
So, okay, maybe i should just try the whole process from scratch?
[00:13]
gac410Don't know. If you are comfortable with git, you could do the full git svn checkout. But that takes FOREVER. Or use the procedures for github, though I can't help you there, I'm using the full git svn checkout.
I'd love to know how pseudo-install broke your checkout.
[00:15]
flexibeastWell, might do the git svn checkout, see if that's more successful. [00:17]
gac410imho, git has some huge advantages. little things, like the automatic pager for things like "log" ... to major things like git bisect - to identify which commit broke something. and cherry-pick to copy commits from branch to branch. and git stash to save work in process.
as far a git svn v.s. github ... pharvey is the better one to talk to.
[00:19]
flexibeastYes, prior to discovering FW, one thing i was considering was if there wasn't some way my org could do document revision control via git .... the problem wasn't git itself, it was finding a sufficiently 'user-friendly' UI to it for non-developer-users. [00:24]
gac410yeah unfortunately git does have a bit of a learning curve. At times I think we've all been pulling our hair on more than one occasion. [00:25]
flexibeastIn any case, i'm partial to learning how to make use of git-svn, as a "gaining experience" thing.
*nod*
[00:25]
gac410The downside of using git for foswiki development, is that keyword variables like $rev$ don't have any equivalence in git. [00:26]
flexibeastSorry, i don't follow .... ? [00:27]
gac410svn has the concept of a repository wide revision. r13125, next commit r13126 ... You can expand that in the code on "checkout" by including $Rev$ in the source and setting some attributes.
We use it in our code. for example view foswiki.org/System/WebHome and see " build 14148, " which came from the $rev$ during checkout.
[00:33]
flexibeastAh, i see.
i guess it would be theoretically possible to use git tag to emulate $Rev$ somehow .... ?
[00:36]
gac410They are managed using "svn propset" and "propget" ... for ex. "svn proplist core/lib/Foswiki.pm" shows Properties on 'core/lib/Foswiki.pm':
LASTBUILD
svn:keywords
And propget on svn:keywords shows "Release, Date" corresponding to the $rev$ and $date$ keywords expanded during checkout.
I think our plan is to eventually just abandon them. Too much trouble to try to emulate in git.
[00:38]
flexibeast*nod* [00:38]
gac410we used to even include the $Rev$ keyword in the TOPICINFO metadata of every topic. We abandoned all that prior to 1.1.4 [00:39]
flexibeastWas that a point of pain to do so? [00:42]
gac410not too bad - just a perl program to loop through all of them and sanitize the TOPICINFO. buildcontrib had to remove it all anyway when building a release. this just made it permanent.
I think the original intention was when running from an svn checkout you could see the svn rev of any topic.
[00:43]
flexibeastAh, okay, makes sense. [00:46]
............. (idle for 1h3mn)
Just did the git clone, took <10 minutes.
(On an ADSL2+ connection.)
[01:49]
gac410off of github?
or from svn?
[01:52]
flexibeastSorry, cloned from github. [01:53]
gac410ah yes - much faster [01:53]
....... (idle for 30mn)
flexibeastgac410: So, git svn fetch has just completed.
Should i expect to see a .svn in foswiki/ ?
[02:23]
gac410no. it's all managed by git.
no svn commands will work. Use git commands. plus "git svn rebase" to pull from svn, and "git svn dcommit" to commit back into svn
[02:23]
flexibeast*nod* Groovy. [02:24]
gac410For "trunk" changes you can just work in master - or create a new branch for your work. git checkout -b somenewbranch
The Foswiki:Development/HowToUseGit has a lot of tips and hints
[02:25]
FoswikiBothttp://foswiki.org/Development/HowToUseGit [ HowToUseGit ] [02:26]
flexibeastYeah, been working from that page, following the instructions. :-) [02:26]
gac410it does take a bit of getting used to ... but imho it's well worth it. [02:27]
.... (idle for 15mn)
flexibeast*nod*
i've just tried to access configure in this new setup
And i'm getting a taint error.
"Insecure $ENV{PATH} while running with -T switch at /home/alexis/src/perl5/foswiki/core/lib/Foswiki/Configure/Checker.pm"
[02:42]
gac410Can't get into configure at all?
Is your LocalSite.cfg already built or is this a completely new start?
[02:43]
flexibeastCompletely new. [02:44]
gac410I did make some changes in that area ... added some code to sanitize the ENV PATH.
foo.
:(
[02:44]
flexibeastThe above is the error i try to get when requesting the configure page. [02:45]
gac410yeah. you are on trunk? or release01x01 branch
If on trunk, just for fun, try "git checkout 42a77c99d045f84da0a886f50db5963c01ada1b7" then run configure again. That will set you back to before my SafeEnvPath changes.
[02:45]
drats - found a bug in the Tasks web. It searches for tasks for release notes using the "StandardReleaseComponent" flag If a task uses components like "FoswikiIterator, or FoswikiUIRender" ... they get skipped. [02:52]
flexibeastWell, git status tells me i'm on branch master, which i presume is trunk? Or do i need to specifically checkout a trunk branch? [02:53]
gac410no. master is trunk. So if you checkout a "commit" you will end up in a "detached head" state, you can run a quick test, and then git checkout master to resume [02:54]
flexibeast*nod* /Think/ i understand. :-)
The above git checkout command didn't work for me: "fatal: reference is not a tree".
[02:55]
gac410hm. strange. try a "git log" and search for Item4777 [02:57]
FoswikiBothttp://foswiki.org/Tasks/Item4777 [ Item4777: {SafeEnvPath} deserves a decent default ] [02:57]
flexibeastThat returns two results. [02:58]
gac410hm. So somehow you didn't get the full history when you created your repo. [02:58]
flexibeastWell, i followed HowToUseGit pretty much to the letter, i believe .... [02:59]
gac410There are multiple methods. git clone + svn doesn't get the full history. "git svn clone" is the nasty one that pulls the complete history from r1 on.
well... back to the taint issue.
What line in /core/lib/Foswiki/Configure/Checker.pm
[03:01]
flexibeastAh okay, i did the git clone + svn method, of course.
426.
[03:05]
gac410looking
Could you remove the -T from the shebang line of bin/configure, so we can see what it thinks your ENV is set to?
[03:05]
flexibeastSure, moment.
Okay, so removed it, now in the configure ui.
[03:08]
gac410Look at the "Web Server Environment" tab down at the bottom
Original Path and Current Path
[03:09]
flexibeastOriginal: "/usr/local/bin:/usr/bin:/bin"
Current: "/usr/local/bin:/usr/bin:/bin"
[03:11]
gac410The error is when the checker tries to run the rcs command to discover the version.
wow. That looks totally safe to me. No relative paths, no ~user path, no "." current path.
[03:11]
flexibeast*nod* [03:12]
gac410This doesn't make sense. That's exactly what my path is as well.
Hm Just for fun. in lib/Foswiki/Configure/Checkers/BasicSanity.pm
Insert a line: ($ENV{PATH}) = $ENV{PATH} =~ m/^(.*)$/; just before the line: delete @ENV{qw( IFS CDPATH ENV BASH_ENV )};
That will untaint the ENV string.
Oh - and restore the -T switch
[03:12]
flexibeastThat worked, with -T. :-)
(Thankfully!)
[03:18]
gac410Okay... now though ... why does it work here and fail there. And is a brutal untaint acceptable.
I'd say yes, because after the first run, the ENV PATH will be replaced with SafeEnvPath setting.
[03:19]
flexibeastflexibeast doesn't feel qualified to comment. [03:21]
gac410I think I'll change that ... if SafeEnvPath not set, then do the untaint, otherwise assign the SafeEnvPath to the PATH. [03:22]
AlexisHazellSo, should i remove that line from BasicSanity.pm for now? [03:23]
gac410yes. I'll check in a fix and if you would, please remove LocalSite.cfg after you git svn update and re-test for me? I'll commit shortly. [03:24]
AlexisHazellOkay. [03:25]
gac410Just committed r14356 (If you are using github, I believe there is a 15 minute delay.) I'd normally run "git svn rebase" to grab the fix, but I dont' know about the github env. [03:28]
AlexisHazellOkay, will wait 15, then rebase.
After which i remove lib/LocalSite.cfg, then re-test without a lib/LocalSite.cfg in place?
[03:29]
gac410Right. [03:30]
AlexisHazellOkay. :-) [03:30]
gac410You could try the rebase. Need to get the commit for svn r14356 [03:31]
AlexisHazellLooks like i got it. :-) [03:31]
gac410SvenDowideit: broke Meta.pm on release branch. Missing right curly or square bracket at /var/www/foswiki/trunk/core/lib/Foswiki/Meta.pm line 3859, at end of line [03:31]
AlexisHazellgac410: Yes, that worked.
So i can now regenerate LocalSite.cfg?
[03:32]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/M2AcOw
[foswiki/master] Item10648: Taint issue found for ENV Path - GeorgeClark
[03:32]
***GithubBot has left [03:32]
gac410okay great. I'll cherry-pick it into the release branch, and also fix Sven's issue.
Hopefully yes. go for it.
[03:32]
FoswikiBothttp://foswiki.org/Tasks/Item10648 [03:32]
AlexisHazellgac410: That also worked. :-) [03:34]
gac410great. [03:34]
AlexisHazellYay! Inching closer to being able to commit my plugin. ;-) [03:34]
gac410SvenDowideit: I can't figure out how you broke Meta.pm. But it's toast. [03:40]
..... (idle for 22mn)
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/E16oeg
[foswiki/Release01x01] Item10648: Taint issue found for ENV Path - GeorgeClark
[04:02]
***GithubBot has left [04:02]
FoswikiBothttp://foswiki.org/Tasks/Item10648 [04:02]
AlexisHazellOdd. Just went to create first user and FW is claiming JavaScript is disabled. [04:12]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/2nbn0w
[foswiki/Release01x01] Item11624: Fix mismatched { } - GeorgeClark
[04:15]
***GithubBot has left [04:15]
FoswikiBothttp://foswiki.org/Tasks/Item11624 [ Item11624: reprev comment and number persists in TOPICINFO long after the event. ] [04:15]
AlexisHazellOh! Is it perhaps saying JavaScript isn't enabled due to Meta.pm being broken? [04:18]
gac410AlexisHazell: no idea. I just checked out master again - reconfigured from scratch, and everthinig is fine. [04:18]
AlexisHazellArgh. [04:19]
gac410no - not broken on master. only release01x01 [04:19]
AlexisHazell*nod* [04:19]
gac410Do you have a javascript blocker [04:19]
AlexisHazelli do - ScriptNo, in Chromium - but it's definitely set to allow localhost.
It's saying JS is allowed when i go to topic pages.
[04:19]
gac410But UserRegsitration say no JS. jeeze, no idea. [04:20]
AlexisHazelli mean, no pages outside of configure are rendering properly either, which i assume is the same issue.
Looks like no stylesheet(s) are being applied.
[04:21]
gac410You did to pseudo-install developer, right? [04:22]
AlexisHazell*nod*
(After i did a pseudo-install default.)
[04:23]
gac410hm. Just did a pseudo-install -u developer, pseudo-install developer, and registered a user using chromium no problem. [04:25]
AlexisHazellThe CSS files are gzipped, aren't they? What if my Web server wasn't gunzip'ing them?
Although HTTP_ACCEPT_ENCODING has the value 'gzip,deflate,sdch'
[04:29]
gac410the server doesn't unzip, the client does. [04:31]
AlexisHazellAh yes, oops.
Looking at the Apache logs
For some reason it's looking for /var/www/foswiki/pub, which of course doesn't exist - /var/ww/foswiki/core/pub does.
[04:34]
gac410Ah... check your pub path in bin/configure
ere. no... In the apache config.
[04:35]
AlexisHazellNo, you were right, i'd missed it in bin/configure. :-) [04:37]
gac410configure *should* have guessed it correctly. [04:38]
AlexisHazellWell, configure had lots of references to foswiki/lib, foswiki/bin etc. rather than foswiki/core/lib, foswiki/core/bin etc. [04:39]
gac410hm. strange. I've never had to touch the paths. they "just work". [04:40]
AlexisHazellHm. [04:41]
gac410Did you edit bin/LocalLib.cfg?
(you should not have to ... just checking )
[04:41]
AlexisHazelli changed $foswikiLibPath appropriately, yes.
Hm, unless ....
[04:41]
gac410And it's correct with core? [04:42]
AlexisHazell*nod* [04:42]
gac410I think you'll find that in most cases you can just ignore that file. Though as a developer it's useful to enable the ASSERT setting to do more extensive error checking. [04:43]
AlexisHazellBut, i've not specified it as /var/www/foswiki/core/lib, but as ~/src/perl5/foswiki/core/lib - /var/www/foswiki symlinks to ~/src/perl5/foswiki
Yes, i've enabled that too.
(Not that i use an actual tilde in the above paths, i put in the explicit path of my home dir.)
[04:43]
gac410maybe it confused the guesser. [04:45]
AlexisHazell*nod* [04:45]
gac410if you get some spare time once your extension is done, you might try to track down why it guessed wrong. Or open a task reporting in as much detail as possible about the incorrect guess. [04:47]
AlexisHazellOkay. [04:48]
gac410there are so many different environments it's really tough to find all these little subtle issues. [04:49]
AlexisHazellYes indeed. [04:50]
***gac410 has left [05:01]
AlexisHazellNight, sleep well! [05:01]
......................... (idle for 2h2mn)
SvenDowideithumm [07:03]
AlexisHazell*sigh*
Just had to restart my box.
Now my dev FW install isn't working again.
:-/
Trying to access configure:
[07:03]
SvenDowideityou're having er, the luck of the irish? [07:04]
AlexisHazell"Access Denied: Attention: The '(Missing or illegal web)' web does not exist" [07:04]
SvenDowideitthat means you have an apache rewrite that is mistakenly throing that request to view [07:05]
AlexisHazellTrying to set up this dev install has been .... trying.
Hm, okay.
[07:05]
SvenDowideitwhat url are you using to get to configure? [07:05]
AlexisHazelllocalhost/foswiki/core/bin/configure [07:05]
SvenDowideitso when you goto localhost/foswiki/core/bin/view
what do you get?
[07:06]
AlexisHazellSame message. [07:06]
SvenDowideitwhat about localhost/foswiki/ [07:06]
AlexisHazelli get Main.WebHome, but without styles applied. [07:07]
SvenDowideitit feels like your shorterUrl apache setup is makeing a mess
what about localhost/foswiki/bin/configure
or maybe
[07:07]
AlexisHazellOddly, that works. [07:08]
SvenDowideityou shoudln't add core? (i'll keep guessing for a bit) [07:08]
AlexisHazellLet me try removing the short urls section from foswiki.conf, moment. [07:08]
SvenDowideitthen your apache conf is set up to direct /foswiki/bin to /home/you/foswiki/core/bin
i dont thing its the shtorturl thing anymore :)
bet there are no 'core' mentions in the URL parts of your apache
return q for everyone
[07:08]
AlexisHazellWell, removing those lines means e.g. localhost/foswiki/core/bin/configure now works.
But what's bizarre is - i had a working install, finally.
[07:09]
SvenDowideithow do you set the default value for a checkbox in a dataform: http://foswiki.org/System/DataForms [07:09]
AlexisHazellAnd then i rebooted.
And then all this.
[07:09]
SvenDowideitthen you probly hacked your conf but forgot to restart apache :)
happens to lots of us, at least, er once per month per conf setup (or some other random made up number)
mmm, looks likt its time for me to go :/
i really wish that there was a avahi cpan module we could use to hook foswiki to
[07:09]
AlexisHazellActually, looks like what's happened is that changes i made in configure haven't 'stuck'. [07:11]
SvenDowideitso any installed foswiki on your network would just turn up in your network browser
lies :)!
[07:11]
AlexisHazelli wish!
i can only guess i've inadvertently done /something/ wrong, but i have no idea what!
'kay, so things are back where they were.
And i've used BuildContrib to set up an AcronymDefinitionsPlugin directory.
Changed the System.AcronymDefinitionsPlugin.txt doc file.
About to modify the MANIFEST file.
Should i somehow check all this in?
[07:12]
SvenDowideityou need to make a task :)
and then commit with a message that starts with "Item12341: bananas are tasty"
[07:17]
FoswikiBothttp://foswiki.org/Tasks/Item12341 [07:17]
SvenDowideitdepressing.
The field value will be used to initialize a field when a form is created, unless specific values are given by the topic template or query parameters. The first item in the list for a select or radio type is the default item. For label, text, and textarea fields the value may also contain commas. checkbox fields cannot be initialized through the form definition
seems, possibly untrue
[07:18]
AlexisHazellSvenDowideit: Sorry, i'm confused - sorry to be a pain.
Within foswiki/core, i have an AcronymDefinitionsPlugin directory, and a hierarchy under that.
[07:20]
SvenDowideitno pain, i'm sure the docco tells you everything in 20 different and confusing ways :/
ok, you shouldn't
you shoudl have
foswiki/core
and foswiki/*
and foswiki/AcronymDefinitionsPlugin
and in foswiki dir
svn add AcronymDefinitionsPlugin
then svn commit -m "Item12354: bananas are best"
[07:20]
FoswikiBothttp://foswiki.org/Tasks/Item12354 [07:21]
SvenDowideitor gitwise
git add AcronymDefinitionsPlugin ; git commit -m "Item12354: bananas are best"
and then git svn dcommit to throw it at us :)
[07:21]
AlexisHazellHm, so i should have been in foswiki dir, then run core/create_new_extension.pl? [07:22]
SvenDowideityeah - thats one awkward thing
you can do it elsewhere, so we allow it :/
[07:23]
AlexisHazell*nod* Okay, so can i now just move the AcronymDefinitionsPlugin hierarchy that i've created out of foswiki/core and up into foswiki/? Or will that break somethings? [07:24]
SvenDowideitto general a q
it will be ok wrt AcronymDefinitionsPlugin
but if you succeeded in pseudo-installing it from there
[07:24]
AlexisHazelli hadn't done that yet. [07:25]
SvenDowideitthen those links will be toast - re-running pseudo-install possibly with the remove option should fix that tho [07:25]
AlexisHazellOkay, so: move it up; run pseudo-install; create a task on f.o; git commit; git svn dcommit. Correct? [07:26]
SvenDowideitsounds right [07:26]
AlexisHazellThanks. :-) [07:26]
SvenDowideiti'll wander back later to help in case
gotto check up on one independant 3yo - the other's still sleeping
[07:26]
AlexisHazellFair enough - thanks again! [07:27]
..... (idle for 20mn)
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/TXDBxQ
[foswiki/master] Item11667: Addition of AcronymDefinitionsPlugin to trunk - AlexisHazell
[07:47]
***GithubBot has left [07:47]
FoswikiBothttp://foswiki.org/Tasks/Item11667 [07:47]
................................................... (idle for 4h13mn)
***ChanServ sets mode: +o MichaelDaum [12:00]
............................................................................. (idle for 6h23mn)
gac410ping SvenDowideit - you around? [18:23]
.................. (idle for 1h27mn)
kip3fHi gac410, PublishedAPI is coming along nicely. When are you going to cut the 1.1.5 rc1, I'd like to get it all checked in before. See bottom of http://foswiki.org/Development/AddPackageNavigationToPerlDoc [19:50]
gac410I was going to do a beta sometime this weekend as a final check before public RC1 on Tuesday. Waiting for Sven to show up as his recent changes have badly broken 1.1.5 - mismatched { } in Meta.pm
I reverted locally, but figured I'd wait to check them in until I hear from him.
[19:51]
kip3fOK I will check in what I have now
I'd like to wait for more feedback, but it's certainly good enough to go to war with
[19:53]
gac410I was looking at the trunk version. Concerned that way too much is flagged as public. Nobody should really use anything in Foswiki.pm for example. [19:54]
kip3fLook at the table at the bottom of the URL that I just posted [19:55]
gac410Yes that's much better,. Have to ask CDot about Foswiki::UserMapping, Foswiki::Users::Password, Foswiki::LoginManager I think they are public, in that custom mappers, etc. implement/override the methods in those modules. [20:02]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::UserMapping http://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Users::Password http://trunk.foswiki.org/System/PerlDoc?module=Foswiki::LoginManager [20:03]
kip3fSure, if there is any controversy it's better to just exclude them for now [20:03]
gac410Adding to your proposal for CDot / others to review. [20:07]
kip3fok [20:07]
everything is checked in to both branches [20:14]
gac410Comments saved. I think that the confusion might be "Public" meaning usable by plugins, which is a much narrower focus, than when expanded to include the pluggable features like Mappers, Login and Password managers. [20:16]
kip3fum, I updated MANIFEST in 1.1 to include PublishedAPI. I should update it in trunk as well right? [20:17]
gac410Yes definitely.
To me, Public implies a contract that says we are not going to change the API. It can be extended, and deprecated, but not changed without warning. Maybe "Published" vs. "Public" is a better term.
[20:17]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/NhWM9Q
[foswiki/Release01x01] Item11437: Update Published API - KipLubliner
[20:19]
***GithubBot has left [20:19]
gac410IE if you call a Foswiki.pm method, don't be surprised if it just stops working in the next release. [20:19]
kip3fhmm -- so "Published" should mean "should be used by foswiki plugins / contribs". "Public" should mean "should be used by other foswiki classes" [20:19]
FoswikiBothttp://foswiki.org/Tasks/Item11437 [20:19]
gac410Yes. [20:19]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/KvlAcw
[foswiki/master] Item11437: Update Published API - KipLubliner
[20:19]
***GithubBot has left [20:19]
kip3fI think that I will remove the checkbox altogether right now
having the link to PublishedAPI is much clearer, anyway
[20:19]
gac410Usually non-public methods are named with a leading underscore, _someFunction() but that is not consistent unfortunately. [20:20]
kip3fright now there is no standard for how "Public" and "Internal" are to be differentiated
even on the package level
e.g. http://foswiki.org/System/PerlDoc?module=Foswiki::Store::RcsWrap vs http://foswiki.org/System/PerlDoc?module=Foswiki::Store::RcsWrap
[20:20]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Store::RcsWrap [20:21]
kip3fsorry, Foswiki::Store::RcsWrap vs Foswiki::Store [20:22]
gac410I think store is moving to be pluggable. That's 1.2 and 2.0 refactoring. [20:23]
kip3fI did an update and now I can't even view PerlDoc! I assume this must be the same problem that you found with Sven's checkin
Meta.pm line 993
[20:26]
gac410release01x01? [20:26]
kip3floadVersion
yes
well, it does compile
[20:27]
gac410yup he broke it good.
I checked in a fix that resolves the complile error but obviously has other problems.
hand on I'll revert his changes.
[20:27]
kip3fok, do you want me to post a stack trace?
what's that website that lets me do that?
[20:28]
gac410nah [20:28]
kip3fok [20:28]
gac410okay - svn up - should be working again. [20:28]
kip3fok
yes it works now, thanks!
[20:29]
gac410great. [20:30]
GithubBot[foswiki] foswiki pushed 3 new commits to Release01x01: http://git.io/yPfl0Q
[foswiki/Release01x01] Revert "Item11624: Fix mismatched { }" - GeorgeClark
[foswiki/Release01x01] Revert "Item11624: perltidy" - GeorgeClark
[foswiki/Release01x01] Revert "Item11624: reprev comment and number persists in TOPICINFO long after the event" - GeorgeClark
[20:32]
***GithubBot has left [20:32]
FoswikiBothttp://foswiki.org/Tasks/Item11624 [ Item11624: reprev comment and number persists in TOPICINFO long after the event. ] [20:32]
gac410SvenDowideit: You've been reverted. :p [20:33]
kip3fin release01x01 - I see %IF{ directly after the breadcrumbs
and the page content starts on the same line as the breadcrumbs
[20:37]
ok I checked everything in. I improved PerlDoc page [20:50]
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/34R1ag
[foswiki/Release01x01] Item11437: Change PerlDoc page to include link to PublishedAPI. Remove 'public only' checkbox - KipLubliner
[21:01]
***GithubBot has left [21:01]
FoswikiBothttp://foswiki.org/Tasks/Item11437 [21:01]
***Cervator has left [21:05]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/zS1MFA
[foswiki/master] Item11437: Change PerlDoc page to include link to PublishedAPI. Remove 'public only' checkbox - KipLubliner
[21:16]
***GithubBot has left [21:16]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/tQ8v1A
[foswiki/master] Item11437: update trunk MANIFEST - KipLubliner
[21:30]
***GithubBot has left [21:30]
........................... (idle for 2h13mn)
SvenDowideitgac410, oh god.
i have that same fix you made... but it must still be un-dcommited
[23:43]
gac410Hi Sven - I gave it a quick try to fix it but only made things worse.
Moved the fail from meta compile errors into Store.
[23:43]
SvenDowideity, i realised aftera bit that this needs tests first [23:44]
gac410I was going to leave it be for you to fix but kip3f was having trouble testing his changes. [23:44]
SvenDowideitbetter this way :)
i thought this was a 3 day flu, but everyone's else has had it almost a week
and i've not hit the bit symptoms yet
[23:44]
gac410I *hate* when we fix things on trunk extensions and then someone syncs the extension but doesn't update any of the "waiting" tasks. [23:45]
SvenDowideitok, think about that like the tasks system is a db
and that the db system is what you're actually developing
[23:46]
gac410Still finding stuff WaitingForRelease on 1.2 or 2.0., that were synced to release1.1 But have to compare source to find out if it really made it. [23:46]
SvenDowideitsurely you don't
in that...
we should be able to update the task-commit updator script to have brains
does the f.o git repo Babar setup know that a commit is a cherry-pick from another branch?
[23:46]
gac410I see a task "Sync from trunk" and a whole mess of changes. Elsewhere on another task is a commit. I have no idea if the "Sync" was really done for the whole extension, or if it was a merged cherry-pcick or .... Some I'f found are actually not synced even though it appears it would. [23:48]
SvenDowideity - you're thinking like a human
trigger1: commits to a branch that is earlier than the 'waiting for release' branch name
[23:48]
gac410But I find tasks that are actually not synced even though the logs seem to indicate that it would be. [23:49]
SvenDowideitand then add more triggers to increase the coverage from that one task to any others changed from A to B
but yes, when someone large scale merges an entire extension from trunk to release
then that mergerer has lots of tasks they should be kicking
and so i recon - kick that person to write the script/SEARCH to show them what they need to do :)
(it was cdot, and not paul, so i'm happy to add to his insane workload >:})
[23:50]
gac410unfortunately it's not necessarily "their" tasks. Arthur commits, Micha merges, Tasks are a mess [23:51]
SvenDowideity, which is why it needs automation
at minimum as a helper
if you merge a full plugin, it should be easy to find all changes between release branch and the source commit - so long as the source control tracks 'from rev'
[23:52]
gac410And some ... Task for the UserReg stuff made changes to the js and css that got synced, cuz they were in an ext. But not the UserReg topics that are not. I have no idea at this point. [23:53]
SvenDowideitwhich svn does not
but git does
y - automation won't catch everything
but it'll reduce the eyeball watering mess
[23:53]
gac410y. Generally we are in pretty good shape. Except for the css and js. [23:54]
SvenDowideiti hope that i'll have time to find and merge f.o topic changes
i keep noticing PaulC (or is it E) editing topics
mmm, 10am, i need to go contact some people, back later
[23:54]
gac4108 pm ... gotta do some shopping before stores close [23:56]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)