#foswiki 2012-07-20,Fri

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
gac410pharvey - were you able to get the JQPlugin branch from github? [01:28]
...... (idle for 29mn)
***ChanServ sets mode: +o Babar [01:57]
........... (idle for 54mn)
gac410SvenDowideit: Should JSPopupPlugin be deprecated, replaced by JQuery and POPUPWINDOW? Seems it is reported to break 1.1.x [02:51]
***ChanServ sets mode: +o Babar [02:55]
...... (idle for 27mn)
ChanServ sets mode: +o Babar [03:22]
........... (idle for 54mn)
gac410 has left [04:16]
..................................................... (idle for 4h23mn)
borgfishjast, i tracered it. fucktards at M$
http://stackoverflow.com/questions/6032046/sharepoint-2010-search-cannot-crawl-mediawiki-site
[08:39]
.... (idle for 18mn)
***borgfish has left [08:57]
........ (idle for 35mn)
fsfshmm, users should never be added to NobodyGroup (and trying to do so results in a line in error.log), but still NobodyGroup can be selected when registering a new user (with REGISTRATIONGROUPTYPE = multiple). Is that the same everywhere, or a result of outdated stuff in my Main web? [09:32]
...................................... (idle for 3h5mn)
***ChanServ sets mode: +o Babar [12:37]
................ (idle for 1h16mn)
fsfsso this seems to be because GROUPINFO returns all groups that the user has write access to. In my wiki, only members of the AdminGroup may add new users, and it seems that NobodyGroup has ALLOWTOPICCHANGE set to AdminGroup
I don't see how System.DefaultUserRegistration could be easily changed to exclude NobodyGroup even if the user has write access to it
[13:53]
gac410Probably an oversight in the TML that renders the UserRegistration page. You are correct, NobodyGroup should not be listed. And even if you select it, the internals should prevent the addition. [13:54]
fsfs11:32 <@fsfs> hmm, users should never be added to NobodyGroup (and trying to do so results in a line in error.log), but still NobodyGroup can be selected [13:55]
gac410yeah that page gets complicated. [13:55]
fsfswhen registering a new user (with REGISTRATIONGROUPTYPE = multiple). Is that the same everywhere, or a result of outdated stuff in my Main web
^^ don't know if you saw that?
[13:55]
gac410yeah I went back in the logs ... but didn't read it very thoroughly. Not enough coffee. [13:56]
fsfsI wonder if changing ALLOWTOPICCHANGE for NobodyGroup would be a solution?
don't know how that was created, and if it could be limited to ... RegistrationAgent or something?
[13:56]
gac410No - I don't think so. If you are admin, then you can always change.
Admin trumps the access controls
[13:58]
fsfsso it needs to be changed in the UserRegistration page, and that needs a lot of TML foo or a new function / new filter option to GROUPINFO, methinks
gac410: do you want to look into that further, or should I file a quick bug?
[13:59]
gac410Up to you. I consider it cosmetic, seems like a lot of effort when admins should know not to check that box. [14:00]
fsfsyes, I think nobody ever checked it on purpose, and it would perhaps be more helpful to display the groups in neat columns, so that it's always clear if you want the checkbox before or after the group name... [14:04]
gac410That feature unfortunately still needs a bit of polishing. [14:05]
..... (idle for 21mn)
fsfsfiled as Item12006, quoting your last two sentences (hope you don't mind) [14:26]
FoswikiBothttp://foswiki.org/Tasks/Item12006 [ Item12006: UserRegistration should not list NobodyGroup ] [14:26]
gac410np fsfs: Actually in this case, since GROUPINFO asks the mapper if change is allowed, really NobodyGroup should just deny change, admin or not. [14:35]
fsfs... I have another issue: I cannot create a new topic from a topic that has + in its name. I get a "'One Two' is not a valid value for the 'topicparent' parameter" error [14:47]
gac410+ is an encoded space in most url parameters. Do we officially support + in topic names? [14:47]
fsfsobviously, the + got url-unescaped without having been escaped in the first place
good question. where would I find the officially supported characters list? :-)
[14:47]
gac410There is a filter-out regex in Foswiki config for Web and Topic names. + is not filtered out. So I guess it's supported. [14:49]
jasthmm, another bug in an extension found. this has been a productive week. ;) [14:50]
gac410If I manually create a file As+Df.txt ... it works for view. [14:50]
fsfsbin/edit is called with ?topicparent=Main.One+Two, but the + is missing in the hidden field on that page [14:50]
gac410And for edit. [14:50]
fsfsyupp, but it won't work as a parent
and that might be a new bug, or we would have stumbled over that a long time ago
[14:51]
gac410It's surprising how many of these little glitches are found. I've said that on some other bugs and traced them all the way back to t* code. [14:52]
jastvoilĂ , another item opened
by the way, I've been thinking about WysiwygPlugin some more
[15:00]
gac410How is the new version working out? [15:01]
jastI haven't actually used the new version yet, since the only problems we're actually facing are not related to the recent changes [15:01]
gac410Ah. you use CKEditor too? [15:01]
jastthe main issue at this point is that, due to the overall design, line breaks ("\n") are prone to disappearing somewhere in the conversion process
yes
[15:02]
gac410SvenDowideit has been tinkering with html5 live editing [15:02]
jastI've started cleaning up our CKE code so we can contribute it back, but it's a long road ;)
html5 is not an option for us, unfortunately
[15:02]
gac410jast: the disappearing \n was one of the big things I worked on in the new versions. [15:02]
jastoh... I must have missed that
jast checks again
[15:03]
gac410Item11819 [15:04]
FoswikiBothttp://foswiki.org/Tasks/Item11819 [ Item11819: Wysiwyg / TMCE eats whitespace - hiddden newline spans are not preserved ] [15:04]
jastwhen were those HIDDENWHITESPACE things introduced?
I'm beginning to believe our version has some really screwed up history
oh, no... we already have that
[15:05]
gac410I think that it appeared in trunk first. CDot did a big "sync from trunk" just before 1.1.5 release, but the trunk stuff was broken. [15:06]
jast_hideWhitespace [15:07]
gac410Yeah, Wysiwyg was interleaving <p> <div> </p> </div> iirc, causing tmce to discard all of the hide whitespace divs.
So the hide whitespace was there, but strict html validation by tmce discarded every bit of it.
[15:07]
jastI have this right at the start of _getRenderedVersion: http://paste.debian.net/179959/
kind of defeats the purpose of _hideWhitespace :)
at least for newlines
oh, well, actually it just fixes the top and bottom
seems my brain has already started leaking out through my ears
[15:09]
gac410;) [15:10]
jastanyway, the interesting thing is that the newlines are mangled even in <sticky> areas... which (as I understand it) shouldn't be touched at all
I guess that's the part I care about most
to be clear: we may not be using all of your fixes
[15:10]
gac410Just tried a sticky with newlines, and they seem to be preserved okay. [15:13]
jastwell, I guess I'll have to bisect it or something
which is going to be an absolute joy because our version forked off ages ago and the history is all different
[15:13]
gac410Try http://foswiki.org/Sandbox/TestStickyBlock [15:14]
jastI wish I knew exactly what changes we've got in it, so I could just contribute them back, make them configurable, and nuke our version from orbit
yeah, it obviously works fine there
let's see what happens if I put the same page in our version...
... yeah. completely broken. bah.
[15:15]
gac410A lot of the fixes I did to TMCE was to address issues with link handling opened for CKEditor purposes iirc. [15:17]
jasteach newline got replaced by space (0x20)
the leading spaces in each line did get preserved, though
the other fascinating part is that the beginning of the sticky block gets 2 tab characters added to it
[15:17]
gac410on foswiki, or your version? [15:19]
jastmy version
I'm definitely not going to blame you or foswiki or anyone but us :)
[15:20]
gac410Depending on when you forked there are some huge changes on foswiki. MichaelTempest did a lot of work on trunk with the preserve whitespace code.
And all that trunk work got pulled into 1.1.5 (unfortunately)
[15:20]
jastI did merge from trunk a month or two ago
hmm, could this be related to _convertIndent?
it seems to be called on divs sometimes
nope.
[15:21]
gac410The trunk version was making a huge mash of tag ordering for a while, opening and closing paragraphs in all sorts of places where they should appear.
should NOT appear.
[15:23]
jastokay, I seem to have determined that the mangling happens in tml->html... which is weird
hmm, looking at this, it might actually be CKE's fault
or, more specifically, our plugin for (not) rendering sticky blocks
[15:24]
gac410The unit tests can be really handy. [15:25]
jastmore specifically, CKEditor's createFakeParserElement function... perhaps... [15:26]
gac410Tricky to figure them out, but very good at ensuring that WysiwygPlugin manages to roundtrip tml -> html -> tml, [15:26]
jastyeah, it's official now. WysiwygPlugin is innocent.
it's CKE.
[15:26]
gac410The difficult part is when the js code makes changes that the tests can't handle. [15:27]
jastand here I thought it would be easy for CKE to not mangle something when not even rendering it. [15:27]
gac410pharvey had selenium set up to do full round-trip browser testing, but that got broken. [15:27]
jastI suspect CKE's code for fake elements doesn't care about whitespace much [15:28]
..... (idle for 21mn)
hooray... CKE has its own input filtering layer
and it mangles whitespace in everything except <pre> and <textarea>
it's hardcoded into the editor core, too
if ( !inPre && !inTextarea ) text = text.replace( /[\t\r\n ]{2,}|[\t\r\n]/g, ' ' );
... I think it's time for weekend :)
[15:49]
fsfsgac410: do you know of a way to expand Macros in such a way that the expanded value is also url-escaped? [15:58]
gac410no idea [15:59]
fsfsRender.pm::_renderNonExistingWikiWord() calls $topicObject->expandMacros('<span class="foswikiNewLink">$text<a href="%SCRIPTURLPATH{"edit"}%/$web/$topic?topicparent=%WEB%.%TOPIC%" ...') and only %WEB% and %TOPIC% in all that should be url-escaped... [16:00]
gac410wrap it inside the ENCODE macro? [16:00]
fsfsinteresting idea... [16:01]
gac410Except that will encode everything
My solution would be to add + to the NameFilter :p
[16:01]
I suspect using characters in topic names that need to be url-escaped expose more issues here and there. [16:09]
fsfsno, ENCODE actually works when I just use it on %TOPIC% in NEWLINKFORMAT [16:09]
gac410cool [16:10]
fsfsso I guess I should commit a change to System.DefaultPreferences to ENCODE the %WEB% and %TOPIC% in NEWLINKFORMAT, no? [16:12]
gac410Not really sure. Makes sense, but I suspect there will be other places. [16:16]
***mohitr has left [16:21]
...... (idle for 26mn)
fsfsok, Item12008 is filed and I'll call it a week, too... [16:47]
FoswikiBothttp://foswiki.org/Tasks/Item12008 [ Item12008: cannot create topic when topicparent contains a '+' in its name ] [16:47]
........................................ (idle for 3h15mn)
GithubBot[foswiki] foswiki pushed 1 new commit to Release01x01: http://git.io/PlTqSQ
[foswiki/Release01x01] Item12006: Don't claim NobodyGroup can be changed - GeorgeClark
[20:02]
***GithubBot has left [20:02]
FoswikiBothttp://foswiki.org/Tasks/Item12006 [ Item12006: UserRegistration should not list NobodyGroup ] [20:02]
GithubBot[foswiki] foswiki pushed 1 new commit to master: http://git.io/Z8i1hQ
[foswiki/master] Item12006: Don't claim NobodyGroup can be changed - GeorgeClark
[20:03]
***GithubBot has left [20:03]
................... (idle for 1h33mn)
ChanServ sets mode: +o Babar [21:36]
gac410 has left [21:41]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)