#foswiki 2013-04-23,Tue

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
***gac410 sets mode: +o jast
gac410 sets mode: +o gmc
[00:33]
........................................ (idle for 3h18mn)
gac410SvenDowideit: About your use of Class::Load - could you implement your Store}{ImplementationClasses} stuff without it? [03:52]
SvenDowideiti have no idea [03:57]
gac410The cpan deps for Class::Load are awful. XS stuff, no debian packages. :P [03:57]
SvenDowideiti was under the impression that there was a nonXS version [03:58]
gac410The issue is when system has some deps installed for other reasons, you get a mix of system versions and Foswiki versions, and the XS modules are expected and not found.
That's what's causing the night build HTML validation issue. Can't find a plugin because Class::Load XS issues on debian.
[03:59]
SvenDowideiti thought Babar had fixed those things, but even there, no idea [03:59]
gac410no idea. Oh... and your .deb / .rpm packages don't appear to pick up the settings related to http://foswiki.org/Download/FoswikiRelease01x01x08#New_setting_needed_for_PatternSkin
yesterday, I had a user run configure and make a bogus change & save and it fixed an issue. It was a new rpm install of 1.1.8
[04:02]
SvenDowideityes, my rpms and debs require a user to use configure
until configure can be run form the cmd line
[04:04]
gac410:( okay. [04:06]
***gac410 has left [04:09]
......... (idle for 42mn)
ChanServ sets mode: +o CDot [04:51]
.................... (idle for 1h38mn)
MichaelDaumah now I know I have to open stack http://www.youtube.com/watch?v=KHqzTBPQYl8 [06:29]
....................................................... (idle for 4h32mn)
***ChanServ sets mode: +o Lynnwood [11:01]
..... (idle for 21mn)
MichaelDaumis the docu wrong or is it an error in URLPARAM: http://foswiki.org/Sandbox/UrlparamTest
default="..." Default value in case parameter is empty or missing
as things are, an %URLPARAM{"q" default="foo"}% won't return the default value on a http://...?q= url
this is so basic, I wonder why this is wrong
[11:22]
http://foswiki.org/Tasks/Item12478 [11:31]
.... (idle for 18mn)
CDotThe doc is wrong. An empty ?q= is assigning the empty value to q, which is a valid value. [11:49]
.... (idle for 15mn)
MichaelDaumbtw have you seen my comments at http://foswiki.org/Tasks/Item12466 ? [12:04]
CDotI hadn't. The reason is that renderForFisplay has to be able to display either the raw value or the mapped value. Both are *display* values.
*displayed*
as my original comment pointed out, the function was misnamed and frankly should never have been used in that context. But once it was, it became very hard to get rid of :-(
[12:11]
MichaelDaumaccessing the raw value should not use renderForDisplay
the name of the function is okay as long as it does what it says
it seems to be in use where it should not in the SEARCH code.
it would be better to read the $meta obj then, instead of going through a $form view
or there should be a different function: something like getValue() seems straight forward
but renderForDisplay(,,,,, display=>1) is odd
anything renderXXX really is there to render a visual representation. it is NOT there to access the data model.
[12:15]
CDotI agree. There are a lot of places where a bit of recoding wouldn't go amiss, but like this particular case there are no unit tests covering that code (which is why I didn't want to risk mucking any more with it) [12:18]
MichaelDaumthere are unit tests for forms being displayed at the page bottom ... which you changed as well [12:19]
CDotremember, the concept of +values was tacked on retrospectively, and the tackers-on (1) didn't write any tests and (2) didn't think through all the implications
yes - which is why I'm surprised to hear you say it has changed. It shouldn't have. :-/
and the fact that the unit tests pass I took as evidence of that
[12:20]
MichaelDaumI deliberately wrote a bug item for formfields not displaying correctly. I fixed that to display the display value.
couple of years ago
[12:21]
CDotdid you analyse why the unit tests didn't show up a bug? [12:21]
MichaelDaumwhich bug [12:22]
CDotyou say in http://foswiki.org/Tasks/Item12466 that it is not displaying the mapped value in forms
which is a bug (change in behaviour)
[12:22]
MichaelDaumright [12:23]
CDotthe code I wrote should *only* affect .... i forget, the macro which gets the value [12:23]
MichaelDaumI once fixed those html matching asserts testing the way forms are displayed.
for +value formfields
[12:23]
CDotmy changes should *only* affect %SEARCH [12:24]
MichaelDaumthese tests either are lost or have been changed [12:24]
CDotand %META
unless.... is %META being used to display forms?
or %SEARCH?
[12:24]
MichaelDaum%ROWVALUE%, %A_VALUE% and those pretties
template-only
these are used in form.tmpl
[12:25]
CDotCDot is reading code
OK, I see from the code that %A_VALUE% should have had display=>1 to get the mapped value
so, why did the unit tests pass?
[12:26]
MichaelDaumthese tests either are lost or have been changed
I remember well staring at these piles of html match codes
[12:27]
CDotRenderFormTests, I assuem [12:28]
***ChanServ sets mode: +o gac410 [12:28]
CDotcrap, it's my error. Apologies. [12:30]
MichaelDaumno problem [12:32]
GithubBot[foswiki] FoswikiBot pushed 2 new commits to master: http://git.io/LbYpiQ
foswiki/master d4c4a2d CrawfordCurrie: Item12466: reverted to check for mapped value in +values in form HTML...
foswiki/master 93a000f CrawfordCurrie: Item12466: A_VALUE needs to expand to mapped value...
[12:45]
***GithubBot has left [12:45]
FoswikiBothttp://foswiki.org/Tasks/Item12466 [ Item12466: SEARCH formfield method returning label instead of value in select+value fields ] [12:45]
GithubBot[foswiki] FoswikiBot pushed 2 new commits to Release01x01: http://git.io/mkeiUQ
foswiki/Release01x01 c15da21 CrawfordCurrie: Item12466: reverted to check for mapped value in +values in form HTML...
foswiki/Release01x01 12fe9ad CrawfordCurrie: Item12466: A_VALUE needs to expand to mapped value...
[12:45]
***GithubBot has left [12:45]
...... (idle for 29mn)
grzesagHi, I am looking for information how to install FosWiki, multiple installation, that run from the same code - I am using debian PPA for installation of FosWiki [13:14]
MichaelDaumgrzesag, use VirtualHostingContrib for that
not sure whether you'll be able to run such a setup from a ppa-ish install
there are some requirements on the directory layout using VirtualHostingContrib
see the docu for that ...
as well as http://foswiki.org/Support/LighttpdBestPractice
[13:18]
grzesagThanks I am experimenting
I am using ppa to make installation of foswiki and plugins easier, and hope that it will make easier to perform upgrades to new release
[13:24]
.................... (idle for 1h39mn)
TarboxHello. ImagePlugin type="thumb" doesn't work because there isn't a template for thumbnails in the template directory. I could add one, but I'm curious if there's anything I should know before (for example) just copying image:plain. [15:04]
MichaelDaumTarbox, I am unsure whether this type is actually useful.
it more or less seems to be a leftover of ancient code.
[15:07]
TarboxI probably misunderstood what it was intended for then. [15:08]
MichaelDaumyea me too
any %IMAGE{"my.gif" size="48"}% is already quite thumbnailish
[15:09]
TarboxWell what I'm really looking for is the user friendliest way to resize an image to something comfortable for the page. And I realize that's vague. [15:15]
................. (idle for 1h20mn)
rhysMain.SitePreferences. I have "Set WIKILOGOIMG = %ATACHURLPATH%/file.png
it doesn't work.
[16:35]
jastit's ATTACH, not ATACH [16:35]
rhystypo here.
when i hit 'save' it converts it to ' /foswiki/pub/Main/SitePreferences/file.png'
still fails to display it
[16:36]
jastwhat does it do instead? display the default? display nothing? [16:37]
rhysjust displays the link to the file.
doesn't display the file itself, doesn't display it in the top corner, nothing
[16:37]
jastit shows a link in the place where the logo is supposed to?
*be
[16:37]
rhysshows just text in the place the logo is supposed to go [16:37]
jastif you right-click on that and choose 'show image' (or whatever your browser calls it), do you get the right URL in the URL bar? [16:38]
rhysok. So this is the default. %PUBURL%/%SYSTEMWEB%/ProjectLogos/foswiki-logo.gif This currently displays fine
Attachment 'System/WebTopBarExample/file.png' does not exist
right click on the top bar. 'show image'
[16:38]
jastoh, right. looks like you can't use '%ATTACHURLPATH%' since it's taken to be relative to whichever topic the image is included in
you might want to use %PUBURLPATH%/Main/SitePreferences/file.png instead
[16:40]
rhysThat works correctly
thanks
[16:40]
***rhys has left "Leaving" [16:44]
rhyslol. except it changes the image for the SitePreferences page only [16:45]
jastmaybe there's a conflicting pref in WebPreferences?
WebPreferences has a higher priority
[16:45]
rhysthis is a brand new install
i haven't changed anything really
this is the first thing I'm trying to chang
WIKILOGOIMG = %PUBURLPATH%/Main/SitePreferences/file.png WEBLOGOIMG = %WIKILOGOIMG%
[16:46]
so yeah. unless something else is messed up (installed from the RPMs) this guide is inaccurate. http://foswiki.org/System/InstantEnhancements#Change_the_logo_in_the_top_left_corner [16:55]
.................... (idle for 1h39mn)
Tarbox:\ It worked for me just a few weeks ago. [18:34]
......... (idle for 40mn)
***ChanServ sets mode: +o pharvey [19:14]
..... (idle for 24mn)
ChanServ sets mode: +o pharvey [19:38]
............................. (idle for 2h23mn)
rhysyeah. any changes made to the SitePreferences don't apply outside that single page [22:01]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)