#foswiki 2013-11-08,Fri

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
***ChanServ sets mode: +o SvenDowideit [01:25]
............. (idle for 1h1mn)
gac410Hm... Another blocker for 1.1.9 I suspect: Item12650 There's no mechanism to clean up JQuery plugins from the configuration once the plugin module is removed. [02:26]
FoswikiBothttp://foswiki.org/Tasks/Item12650 [ Item12650: Foswiki.org loging errors: Can't locate Foswiki/Plugins/JQueryPlugin/THEMESWITCHER.pm in @INC ] [02:26]
........................ (idle for 1h57mn)
pharveyI know have %! htmltidy, %! jstidy, %! jsontidy, %! csstidy, %! yamltidy, %! perltidy all working in vim :)
I now*
[04:23]
gac410directly in vim.... cool [04:23]
pharvey7,58! htmltidy - tidies just those lines
w00t
[04:24]
gac410That would be much easier than edit / commit / dcommit / curse / tidy / ... [04:24]
pharveyhehe
%! perltidy works as-is FWIW
the other things were quite a pain
and involved node.js/npm projects
which were incredibly difficult to compile on CentOS 5.0
'course, I now have a 300MB home dir on all the servers I mess with, but meh
[04:24]
gac410:)
Did you see Item12649 ? ugly. I don't see though how it happens. :(
[04:25]
FoswikiBothttp://foswiki.org/Tasks/Item12649 [ Item12649: Error log flooded with view: Use of uninitialized value in integer ne (!=) at /var/lib/foswiki/lib/Foswiki/UI/View.pm line 452 ] [04:26]
pharveypharvey clickies [04:27]
gac410gac410 wonders if it's a search engine whacking away at illogical links.
I've checked f.o logs, but didn't notice anything like it. Of course found another crash that I opened as a 1.1.9 blocker :(
[04:27]
pharveyI'm having trouble understanding how this can be [04:33]
gac410yeah ... that was my conclusion.
My only other thought was what perl release is he on. Maybe some strangeness there.
[04:33]
pharveymust RDiff [04:34]
gac410The code gets hit when you include a ?rev= on the view, and I think it also generates the rev list at the bottom of each topic.
hm... corrupted rcs file?
[04:34]
pharveythis is why I hate 800-line functions [04:36]
gac410:)
Unless we can recreate it I don't want to consider it for 1.1.9.
[04:36]
pharveyneed the corresponding access log entries [04:37]
gac410I'm tempted to treat Item12650 as a release-note item too, though I hate asking people to edit LocalSite.cfg [04:37]
FoswikiBothttp://foswiki.org/Tasks/Item12650 [ Item12650: Foswiki.org loging errors: Can't locate Foswiki/Plugins/JQueryPlugin/THEMESWITCHER.pm in @INC ] [04:37]
pharveygac410: an undefined $showRev might happen in the assignment that's supposed to prevent it in line 162 of View.pm
$maxRev is set on line 132 further up with
$maxRev = $revIt->next();
so as you say
corrupted RCS file
[04:41]
gac410Do you have time to comment on the task? [04:42]
pharveysure [04:42]
gac410Hm... There is an ASSERT there line 131, So enabling asserts might find the bad topic [04:43]
pharveygood point [04:43]
gac410: commented [04:48]
gac410thanks pharvey [04:48]
......... (idle for 43mn)
***gac410 has left [05:31]
.............. (idle for 1h9mn)
ChanServ sets mode: +o CDot [06:40]
................ (idle for 1h19mn)
ChanServ sets mode: +o MichaelDaum [07:59]
..................... (idle for 1h44mn)
HendrikKoehler%FOREACH{"topic" in="%TOPICLIST{"$topic,"}%"}%
%INCLUDE{"%ENCODE{"$topic" old="$comma, $CHAR(32)" new=""}%"}%
%NEXT{"topic"}%
i'm trying to include every topic in the current web but this code throws a "Can't INCLUDE 'Topic', path is empty or contains illegal characters." for every topic.
[09:43]
..... (idle for 23mn)
MichaelDaumHendrikKoehler, try FilterPlugin and then FORMATLIST{"$percntTOPICLIST{...}$percnt" format="$percntINCLUDE{\"$item\"}$percnt"}% [10:06]
HendrikKoehlerthx i'll try it [10:06]
MichaelDaumor a %SEARCH{"1" format="$percntINCLUDE [10:07]
JulianLevensMichaelDaum: ref http://foswiki.org/Development/AddConcatOptionToAttrs, at first I though your suggestion looked better and worked beautifully. Alas on closer inspection my numbers were centred rather than right aligned, the '\' approach loses trailing whitespace and breaks things [10:13]
MichaelDaumdid you add two white spaces after the last pipe?
the current solution adds backslashes before the last pipe. try escaping newline _after_ the closing pipe.
[10:14]
HendrikKoehlerMichaelDaum, where exactly does your code go?
I'm getting really weird errors
[10:15]
MichaelDaumnext best thing is: don't use TML tables unless you really need sorting by column. even then using JQDataTablesPlugin is preferable.
JulianLevens, as soon as you use format="<table class='foswikiTable'>...</table>" you can split it across as many lines as you like, nicely formatted maintainable by the wiki champions following you ;)
[10:15]
HendrikKoehlerNow I get what your code is supposed to do :)
Unfortunately the first one does nothing and the second one does this: http://pastebin.com/fmqjmJnt
[10:23]
JulianLevensMichaelDaum: I wont change to <table>... now. I consider the work done, in any case I need to better understand the downsides of doing so. However for future reference what does class='foswikiTable' buy me? [10:25]
MichaelDaum| A | TML | Table | is rendered as <table class='foswikiTable'>...</table>... see the HTML markup ;)
the only downside of not using TMLtables is that TablePlugin and EditTablePlugin won't be able to access it.
as your table isn't meant to be editable, the second one is out anyway.
TablePlugin brings two features to TML tables: styling and sorting
HendrikKoehler, what's the code producing http://pastebin.com/fmqjmJnt
[10:27]
HendrikKoehler%SEARCH{"1" format="$percntINCLUDE"}% [10:31]
JulianLevensTo be honest I keep thinking that the whole table display and management needs reworking. Or maybe I just mean from %SEARCH. I keep think I'd like to able to specify something like column1_header="*Column 1*" column1_cell=" $formfield(MyField)". Or even better column1="MyField" and for Foswiki to be able to create sensible defaults. I haven't really though this through though [10:32]
Now I re-read your initial response (11:28 & 11:29) today. I'm wondering if you misunderstood. My table display basically ok it's just alignment within some columns that's borked. As I read your response (and may I misunderstood) you're suggesting a solution to total breakage of the table output.
Oh, and where are the docs describing \ continuation I cannot find it!
[10:40]
..... (idle for 24mn)
MichaelDaumJulianLevens, nor can I :)
HendrikKoehler, the code fragment %SEARCH{"1" format="$percntINCLUDE isn't meant to be run as is. you have to modify it to your needs.
JulianLevens, TML tables are hopelessly overused for all sorts of stuff. The biggest weakness is its fragility wrt newlines .... something you are fighting with as well. There are only a few very limited cases when I'd recommend TML tables in dynamic tables.
they do have their use case for manually crafted tables
as part of the wiki markup
but are more of a culprit for wiki apps when things suddenly break in unforeseeable ways.
rule of thumb: don't use them whenever you can. only use them when you absolutely need them.
[11:05]
JulianLevensA key question for me is: will the person following me by html conversant. The table formatting is simpler, albeit not a lot [11:10]
MichaelDaummeanwhile I am about to fix JQDataTablesPlugin. SvenDowideit here's a bit of feedback so far http://foswiki.org/Tasks/Item12651. do you mind me fixing & releasing it? [11:10]
JulianLevensDo I lose column sorting with <table> stuff? [11:11]
MichaelDaumyes
as long as JQDataTablesPlugin is broken
[11:11]
JulianLevensSo much to learn :'( :D [11:12]
MichaelDaumfrankly, server side table sorting is lame, isnt it. [11:12]
JulianLevensYes
Presumably the client side has smarts to read extra pages via Ajax with large, paged output
[11:15]
MichaelDaumJQGridPlugin does that for instance
it would be good to have JQDataTablesPlugin as an alternative.
see these examples: http://www.datatables.net/examples/
JQGridPlugin can interface with Foswiki's SEARCH (limited capabilities), Solr and DBCachePlugin as backend connectors. There's a connector api for it part of the plugin to add others.
[11:16]
JulianLevensI look forward to it. The speed of sorting is great and many many options to improve the Ux. [11:24]
...... (idle for 29mn)
SvenDowideitMichaelDaum, goforit [11:53]
MichaelDaumwildo [11:53]
HendrikKoehler%FORMATLIST{"%TOPICLIST{"$topic;"}%" split=";" format="%INCLUDE{"$1"}%" exclude="IncludeAllTopics"}%
this SHOULD work
but it even ignores the exclude="IncludeAllTopics"
which I added so the topic doesn't include itself
%FORMATLIST{"$percentTOPICLIST{"$topic;"}$percent" split=";" format="$percentINCLUDE{"$1"}$percent" exclude="IncludeAllTopics"}%
and this SHOULD do the same thing as the line above but doesn't
the first one does this:
http://pastebin.com/Guw8iLLZ
and the second one this:
http://pastebin.com/200xgTUG
[12:01]
ModAcOst%FORMATLIST{"%TOPICLIST{"$topic;"}%" split=";" format="$percentINCLUDE{$1}$percent"}% should work (untested) [12:05]
HendrikKoehlerit does the same thing as the first line
something must be broken there
i have spent the last two days reading documentation and finding nothing
[12:07]
ModAcOstIt works on my system. The only thing I can imagine going wrong is that you use it in a web which has an illegal name. [12:19]
HendrikKoehlerI'm trying it in the Sandbox web [12:26]
CDotdon't forget that $percent is expanded at different times, so the macros get invoked differently [12:27]
MichaelDaumHendrikKoehler, %FORMATLIST{"$percntTOPICLIST{\"$topic \"}$percnt" format="$percntINCLUDE{\"$1\"}$percnt" split=" " exclude="IncludeAllTopics" separator="$n"}% [12:28]
CDotif you use the first version, the %INCLUDE is included before the FORMATLIST is expanded
so you end up with a topic expanded in the middle of the FORMATLIST parameters.
and as MichaelDaum has just pointed out, quotes can't be nested
(must use \" to escape them when used in conjunction with $percent. You can also use $quot, which I find more readable).
[12:28]
HendrikKoehlerCool, that works, thank you so much MichaelDaum :) [12:30]
MichaelDaumproblem was that $percentTOPICLIST{"$topic;"}$percent produced a list with an empty element at the end as indicated by the last ; [12:31]
HendrikKoehlernow i get it
pretty confusing :)
[12:33]
CDotnah, you just have to think recursively. [12:36]
HendrikKoehlerwhich I have a hard time doing
now i need to learn regular expressions to filter out topics i don't want on the page
[12:37]
............ (idle for 59mn)
***ChanServ sets mode: +o Lynnwood [13:37]
ChanServ sets mode: +o gac410 [13:42]
............ (idle for 57mn)
gac410Hi MichaelDaum ... that error occurs on the JQueryPlugin page by default. So even though it's removed, something is still requiring it,
I was still looking a bit last night to find it but got distracted :)
[14:39]
MichaelDaumHi George. Got an url where that error is visible? [14:40]
gac410Not visible. Just logs the error when visiting foswiki.org/System/JQueryPlugin
I think it's in one of the %INCLUDE topics ... I was stepping through them last night
Have to view each one while tailing the apache error log :(
[14:40]
MichaelDaumgrepped thru the JQueryPlugin and haven't found it either, hm. [14:42]
gac410yeah ... that's why I made it a blocker. I don't like mysteries :) [14:42]
MichaelDaumhave you looked at fo's LocalSite.cfg?
I can't repro it over here looking at System.JQueryPlugin
[14:43]
gac410Yes, Themeswitcher IS enabled, but not visible in bin/configure.
I didn't edit the LSC to remove it until there is more of an explanation.
I know there are some hosted sites where it's challenging to edit files. The stale logger config cleanup was a challenge for some.
[14:43]
MichaelDaumah now I can repro
MichaelDaum going into heads down mode
[14:44]
gac410gac410 wonders if its related to the JQPLUGINS macro that attemps to show all plugins. [14:45]
MichaelDaumyep
it calls getPlugins which does a load() per plugin enabled in configure
[14:46]
gac410I'll poke at configure later to see if there is some way to make cleanup easier.
If nothing else, this is worth a comment in the release notes. Maybe suggest that people disable the plugin in the config prior to upgrade, not that anyone reads the release notes :)
[14:47]
MichaelDaumwe will put the same burdon on users the next time deprecated modules are removed [14:49]
gac410It's just one of my sanity checks before building a release. Is the foswiki.org error log clean, or explainable [14:49]
MichaelDaumit might be better to have some kind of checker that disables them automatically. is that possible? [14:49]
gac410I'll look at it. Either disable, or at least ensure they are visible. That's how we handle regulare plugins. Enabled but missing show up at the end of the list flagged with an error. [14:50]
MichaelDaumI can't see how to distinguish a module gone from a genuin plugin error ... which should be reported of course. [14:50]
gac410Yeah... I'll dig into configure. It should be fixable. [14:51]
MichaelDaumone thing on upgraders: they will still have the THEMESWITCHER.pm in place. don't they?
how have these files been cleaned up on f.o.?
[14:51]
gac410Hm... good point. On Foswiki.org, I use FoswikiUpgradeCheck script with "-r" to remove files from the install that were removed from the manifest.
Somewhat duplicates what others have done. Fresh install, then copy over LSC, I think Lavr did moto that way.
I should probably do upgrades both with and without the -r remove flag. Because stale code can also cause issues, esp in templates.
But once they are gone ... :D
Okay, so this makes it much more of a corner case. Only impacts upgraders who "clean" their system of files removed from the distro. Probably nobody ;)
[14:52]
..... (idle for 22mn)
***JulianLevens has left [15:17]
........................... (idle for 2h14mn)
GithubBot[foswiki] FoswikiBot pushed 2 new commits to master: http://git.io/FwzlqA
foswiki/master 248c266 MichaelDaum: Item12651: ...
foswiki/master 7f869be MichaelDaum: Item12651: removing backup files; fixing the MANIFEST...
[17:31]
***GithubBot has left [17:31]
FoswikiBothttp://foswiki.org/Tasks/Item12651 [ Item12651: javascript errors and 404s on pages loading datatables module ] [17:31]
.................. (idle for 1h29mn)
GithubBot[foswiki] FoswikiBot pushed 2 new commits to Release01x01: http://git.io/9lpJSA
foswiki/Release01x01 72c8010 GeorgeClark: Item12651: Reveal EXPERT Items with warnings...
foswiki/Release01x01 3947491 GeorgeClark: Item12650: Improve handling of deprecated plugins...
[19:00]
***GithubBot has left [19:00]
FoswikiBothttp://foswiki.org/Tasks/Item12651 [ Item12651: javascript errors and 404s on pages loading datatables module ]
http://foswiki.org/Tasks/Item12650 [ Item12650: Foswiki.org loging errors: Can't locate Foswiki/Plugins/JQueryPlugin/THEMESWITCHER.pm in @INC ]
[19:00]
gac410Oh darn... Item12651 ... should have been Item12652 [19:01]
............ (idle for 59mn)
***JulianLevens has left [20:00]
........... (idle for 51mn)
donbarryin #astronomy [20:51]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)