#foswiki 2014-03-19,Wed

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
***ChanServ sets mode: +o pharvey [00:05]
......... (idle for 41mn)
gregg4567 has left [00:46]
..................................................................... (idle for 5h43mn)
ChanServ sets mode: +o CDot [06:29]
................... (idle for 1h32mn)
GithubBot[foswiki] FoswikiBot pushed 1 new commit to master: http://git.io/hWkDTg
foswiki/master c6b0f32 MichaelDaum: Item12805: fixed sub-hashes like {Site}{CharSet} not being parseed properly...
[08:01]
***GithubBot has left [08:01]
FoswikiBothttp://foswiki.org/Tasks/Item12805 [ Item12805: sub hashes in LSC aren't accessible anymove using QUERY or IF ] [08:01]
..... (idle for 22mn)
JulianLevensMichaelDaum: your fix ref Item12805 reverted a change jast made to support locale during the Camp. I suspect your fix breaks his and vice versa. This may need more work :( [08:23]
MichaelDaumno dont think so [08:24]
***blad3 has left [08:24]
MichaelDaumhis locale checkin had a lot of unrelated changes in it as well
the part I reverted might have been an attempt to fight back taintedness
the error was obvious
[08:24]
JulianLevensOK, just thought it worth asking [08:25]
MichaelDaumthere have been another fix by jast that in fact would have been worth a separate report + checkin getting a serializer of some style. there's been a caching error in the module that jast has fixed.
btw the autotests hosted by florian completely failed with an abnormal abortion. not sure what goes on there.
we realy need to hammer those tests more.
[08:26]
JulianLevensModAcOst: I note that you've spotted the bug in Item12786, are you ready to check that in or do you need to set up a test case first [08:39]
FoswikiBothttp://foswiki.org/Tasks/Item12786 [ Item12786: Mailnotify matches topic prefixes by default ] [08:39]
................ (idle for 1h19mn)
ModAcOstJulianLevens: I can provide a test for it as well, I just didn't want to steal it from OliverKrueger [09:58]
andreliHi guys
Foswiki gets chatty lately.
I get automated email notifications for tasks that are not related to me. http://foswiki.org/Tasks/WebNotify even though seems correct.
Any idea?
[09:59]
ModAcOstadreli: Most likely Item12786 [09:59]
FoswikiBothttp://foswiki.org/Tasks/Item12786 [ Item12786: Mailnotify matches topic prefixes by default ] [09:59]
GithubBot[foswiki] FoswikiBot pushed 1 new commit to master: http://git.io/jnkV0A
foswiki/master 947a3e5 CrawfordCurrie: Item12806: add a check for valid TOPICINFO during pre-commit...
[10:00]
***GithubBot has left [10:00]
FoswikiBothttp://foswiki.org/Tasks/Item12806 [ Item12806: pre-commit should check validity of TOPICINFO ] [10:00]
***ChanServ sets mode: +o Lynnwood [10:00]
ChanServ sets mode: +o pharvey [10:12]
jasthuh
I have absolutely no idea how that change ended up in there
MichaelDaum_: the serializer change I made was not meant to fix caching. it was meant to fix locale. and it presumably even actually did that. I didn't know there were existing issues in that.
oh, now I remember where that change came from
the one you reverted, that is
it was a locale-related fix, but the fix was bad :)
the proper fix would have untainted *and* changed the regex to capture everything, not just the first {...}
in any case, sorry for breaking it :(
[10:17]
MichaelDaumjast, no worries.
the other thing you fixed was the way allocated serializer objects were cached under the style ID. as this ID coming from outside coud just be written in any case, the thing would not reuse already instantiated serializers just because the style param was written differently
e.g. %QUERY{...serializer="json"}% vs %QUERY{...serializer="Json"}% vs %QUERY{...serializer="JSON"}% etc
only the first QUERY should instantiate a json serializer while the other reuse it no matter how the style is written
^serialzer=^style=
[10:32]
jastoh, right [10:38]
MichaelDaum:) [10:40]
CDotCDot is off to hospital. See you when (if) they let me out again :-) [10:52]
MichaelDaumwoops [10:54]
.................... (idle for 1h36mn)
***ChanServ sets mode: +o gac410 [12:30]
...................... (idle for 1h48mn)
ChanServ sets mode: +o OliverKrueger [14:18]
OliverKruegerOliverKrueger pings JulianLevens [14:18]
JulianLevensHi [14:19]
OliverKruegerThanks for the reminder on Item12786. [14:21]
FoswikiBothttp://foswiki.org/Tasks/Item12786 [ Item12786: Mailnotify matches topic prefixes by default ] [14:21]
OliverKruegerWhat takes me so long was not the regex fix, but my aspiration to add a unit test for the bug.
I never created a unit test before and Im still learning who they work.
Sorry for the delay.
[14:23]
gac410that one is particularly difficult :)
gac410 spend quite a bit of time trying to figure out why the existing test didn't fail. I still think it should.
[14:23]
OliverKruegerOliverKrueger pings ModAcOst
Just saw in your irclog ref that Stephan already crafted a test for it.
ModAcOst: If you read this, please go ahead with your test/checkin. I will learn unit tests on another Item later. ;)
[14:24]
JulianLevensThat sounds good, I need to learn how to craft unit tests as well [14:28]
OliverKruegerOliverKrueger unblocks the Item. ;) [14:29]
ModAcOstHi, I made a new pretty simple test. The other tests do not check for extra topics, as far as I looked [14:29]
***OliverKrueger sets mode: +ooo ModAcOst JulianLevens uebera|| [14:31]
gac410gac410 never realized that "BeingWorkedOn" blocked an item from other devs. He steps on people all the time :) [14:37]
ModAcOstMaybe it doesn't ^^ [14:38]
OliverKruegerI interpret it as a "social blocker" not a technical one. ;) [14:38]
ModAcOstCan't commit however [14:38]
OliverKruegerI set it to "Confirmed". [14:38]
gac410ModAcOst: Can't commit ??? Do you lack auth? [14:39]
ModAcOstsvn: E165001: Commit blocked by pre-commit hook (exit code 2) with output: Can't locate Foswiki/Attrs.pm in @INC [14:39]
OliverKruegerI think it should prevent people from working working on parallel solutions.
Someone checked in a "pre-commit.pl" lately...
[14:39]
gac410gac410 usually saw it meant to comment / coordinate fixes.
I think Crawford just did. Trying to verify TOPICINFO
Foswikirev:17410
[14:39]
FoswikiBothttp://trac.foswiki.org/changeset/17410 [ Changeset 17410 – Foswiki ] [14:41]
gac410Wonderful. That will probably need to be fixed on the server, if it blocks the commit to fix it :( [14:41]
OliverKruegerHow do I temporarily disable checkin checks?
I have root access to f.o.
[14:43]
gac410Not sure. I was just starting to look. I think the exits get copied into /home/svn
Yeah, they are in /home/svn/nextwiki/hooks but I don't know how they get there.
[14:44]
OliverKruegerpre-commit.pl -> /home/trunk.foswiki.org/core/tools/develop/pre-commit.pl [14:45]
gac410er... maybe not.
/home/svn/supportscripts/pre-commit.pl is a symlink to the file in svn
I think you can just temporarily remove the symlink. The pre-commit hook checks if it exists.
[14:45]
OliverKrueger/home/trunk.foswiki.org/ is a normal checkout area. So I can delete the pre-commit file and revert it back afterwards. [14:48]
gac410I think if you add a PERL5LIB to the hook itself, the .pl might work [14:49]
OliverKruegerModAcOst: Can you try again?
OliverKrueger moved pre-commit.pl to pre-commit.pl.bak
[14:49]
gac410/home/svn/nextwiki/hooks/pre-commit Tests and executes the symlink in the supportscripts directory. [14:50]
OliverKruegerYes, and I temp. moved it to the side... [14:51]
gac410Maybe add an export PERL5LIB=/home/trunk.foswiki.org/core/lib to that hook?
gac410 never can figure out when the env is passed and when it's cleared
[14:52]
OliverKruegerits a perl file not a shell script. [14:54]
gac410No... the hook itself is a shell script. #!/bin/sh ... [ -f pre-commit.pl ] && perl pre-commit.pl $* MAIN [14:56]
ModAcOstsvn: E165001: Commit blocked by pre-commit hook (exit code 1) with no output. [14:56]
gac410See /home/svn/nextwiki/hooks/pre-commit ... that's the hook itself [14:56]
OliverKruegeradded "PERL5LIB=/home/trunk.foswiki.org/core/lib" to pre-commit.
ModAcOst: again please. :)
[14:58]
gac410gac410 grumbling to self .... did the original checkin have any sort of local test :( [14:59]
ModAcOst"Can't locate Foswiki/Attrs.pm in @INC" again [15:00]
gac410darn. [15:00]
OliverKruegerrevert CDots checkin? [15:08]
gac410if you rename the /home/svn/nextwiki/hooks/pre-commit that will disable the hook safely.
Then you should be able to revert :)
gac410 needs to get some motivation to work on git hooks again.
[15:09]
OliverKruegerModAcOst: Should be disabled now. Can you try again? [15:10]
ModAcOstsvn: E165001: Commit blocked by pre-commit hook (exit code 1) with no output. [15:13]
gac410wtf [15:13]
***ChanServ sets mode: +o MichaelDaum [15:14]
OliverKruegerOliverKrueger adds a "exit 0;" to pre-commit. [15:14]
gac410If a hook is missing it should not be active. The install process is to copy or rename pre-commit.tmpl template
mv /home/svn/nextwiki/hooks/pre-commit /home/svn/nextwiki/hooks/pre-commit.disable should have been sufficient
[15:14]
OliverKruegermaybe [ -f pre-commit.pl ] fires a errorcode 1 to the caller.
I moved the pl, not the hook itself.
[15:16]
gac410Hm.. I guess the [ -f isn't working as intended. Might as well just let it fail. Maybe the [ -f should exit 0 if that fails, othewise execute the hook.pl
gac410 has never really learned shell scripting
[15:17]
OliverKruegerI guess the errorlevel code gets propagated up the chain.
I my checkin again.
(with the exit 0; workaround in place)
[15:21]
GithubBot[foswiki] FoswikiBot pushed 1 new commit to master: http://git.io/EuMB8Q
foswiki/master 344ccbf OliverKrueger: Item12475: partially reverted docco changes...
[15:31]
***GithubBot has left [15:31]
FoswikiBothttp://foswiki.org/Tasks/Item12475 [ Item12475: Recent additions to CPAN libraries cause issues on some systems ] [15:31]
ModAcOstNow it worked [15:34]
OliverKruegerreverted CDots checkin and removed my exit0 workaround. [15:36]
MichaelDaumjast, https://.../bin/configure/FindMoreExtensions looks strange with lots of 400 invalid requests [15:41]
gac410MichaelDaum: Is it just https:// sites? trunk.foswiki.org seems to be looking okay [15:43]
GithubBot[foswiki] FoswikiBot pushed 2 new commits to master: http://git.io/2NwEwg
foswiki/master b3b4223 StephanOsthold: Item12786: Improve topic matching for MailerContrib...
foswiki/master 9bcad40 OliverKrueger: Item12806: reverted CDots changed since it prevents further svn checkins...
[15:45]
***GithubBot has left [15:45]
FoswikiBothttp://foswiki.org/Tasks/Item12786 [ Item12786: Mailnotify matches topic prefixes by default ]
http://foswiki.org/Tasks/Item12806 [ Item12806: pre-commit should check validity of TOPICINFO ]
[15:45]
JulianLevensHallelujah [15:45]
MichaelDaumgac410, no even plain old http. even the frontpage shows http://.../bin/configure/resource/configure/resource/processing-bg.gif 400 (Invalid Request) [15:45]
jastMichaelDaum: wfm... [15:49]
MichaelDaumyea
;)
[15:49]
gac410iirc the resource loader does do some strange stuff. So that resources cannot be read without a session. [15:50]
jastif you find any more details that might help figure that out, let me know [15:50]
MichaelDaumdoes that mean a direct access to the .gif url won't work? [15:50]
gac410Correct
I just did a net trace of the actual Extensions page, and didn't see any 400's
[15:51]
MichaelDaumhm then it is my fault [15:52]
gac410The configure resources are pretty well protected iirc. [15:53]
jastgood thing, too... I added some extremely classified icons to those buttons [15:53]
gac410I think it was to make sure that resource function could not be used outside of configure [15:54]
MichaelDaumoh I should mention this is running under nginx
might be the session isn't carried over to some resources
[15:59]
gac410well I get the same error on foswiki.org if I go after a resource directly. But it works using the resources in context.
I would expect configure to not work at all if resources are not working. It pulls in the javascript that way.
[15:59]
MichaelDaumthose resources that work just fine - like jquery - are called without a cookie
the ones that fail do send the session cookie
which is exactly the other way around I'd suspected
[16:01]
gac410IIRC there are some differences with how ngnix set the expected apache ENV variables. HTTP_URL and the likes. [16:02]
jastthat cookie behaviour does sound rather strange [16:03]
MichaelDaumhere's the error calling the resource directly: Invalid Dispatch CGI::Session=HASH(0x8f189e0)/FOSWIKICFG4SID=3d046bab19b2af5e1d0eebb7be33d471; path=/; expires=Sat, 16-Mar-2024 16:03:40 GMT; secure Invalid resource name
calling https://.../bin/configure/resource/configure/resource/processing-bg.gif directly
same without a cookie: Invalid Dispatch CGI::Session=HASH(0x8b276b8)/ Invalid resource name
[16:05]
gac410The cookies are sent in the GET's issued directly by the FindMoreExtensions page. At least the Firebug Net trace shows them in the headers of each GET [16:06]
MichaelDaummaybe the cookie-no-cookie is a red herring [16:08]
jastthe error message is pretty broken either way [16:08]
MichaelDaumthe msg says: "Invalid resource name" so maybe it isn't able to map the url to the real resource data [16:08]
KAIsbI see y'all are busy, but anybody available for a quick Q? Installed NatSkin and top of menu on right has some gibberish. Also, after editing, the article has a whole lot of code under my edit, which is not visible there in the original (under wysiwig OR code) [16:10]
MichaelDaumKAIsb, screenshot it [16:10]
jast'Invalid Dispatch' is supposed to output the dispatch type (_action, _validate etc.), not any weird hash/cookie stuff [16:10]
MichaelDaumheh [16:11]
jastno idea how the message you see is even possible
I don't see any call to dispatch() that doesn't have a constant as its first arg ($type)
[16:12]
gac410I just tried it again locally. Before I login to configure I get a correctly formed "Not Authorized" message. After login, I get the little spinning gif. [16:12]
MichaelDaumKAIsb, you are missing a couple of plugins
WebLinkPlugin and FlexFormPlugin
[16:17]
gac410MichaelDaum: Have you considered building a tricked-out foswiki as another offered VM Take the 1.1.9 vm I just built, Add all the Nat* ecosystem plugins, and offer another vm? [16:18]
MichaelDaumyea
hope is that just doing an "install NatSkin" in configure will actually do the trick. no vm download.
[16:19]
KAIsbit would actually be a big help to those of us who don't code... :) [16:20]
gac410The vm's are just an easy way for users - esp. windows users - to kick the tires. [16:20]
MichaelDaumindeed [16:21]
KAIsboh, I'm hoping to make a long trip, not just kick the tires... :0 [16:21]
MichaelDaumor ship NatSkin OOTB [16:21]
KAIsbthat would work too. it's less scarry-looking [16:21]
gac410The only hard part I had with building the 1.1.9 vm was reclaiming diskspace after the os upgrade [16:21]
MichaelDaumKAIsb, note that a new NatSkin is around the corners, looks like http://demo.michaeldaumconsulting.com [16:22]
gac410I think NatSkin OOTB would be too drastic for upgraders. But a NatSkin distribution ... may be another path. [16:23]
MichaelDaumwe did plan for a new skin for foswiki-2.0 [16:25]
KAIsbAnd some input from a new windows user, the GUI/menus don't seem that intuitive. I'm constantly looking for the settings menu and it's always difficult to find where they're located, and which ones do what... [16:26]
gac410I'll confess my concern with NatSkin is you move so fast at times, it tends to break older installs. [16:26]
KAIsbgranted, my background is mostly graphics software, but I do like to get around. [16:26]
gac410KAIsb: Settings within foswiki itself. Yes it rather pre-dates gui configurations :)
Understanding the Setting / inheritance hierarchy within foswiki is a challenge. Unfortunately settings aren't just in one place.
System.DefaultPreferences Main.SitePreferences, Main.<usertopic> <web>.WebPreferences, <web>.<topic> ... each overriding the prior unless finalized. (Not sure I even got this order correct)
[16:27]
KAIsbyeah, but I'm coming from DOS days, and maybe because I kinda started with DOS (actually Apple IIe), it's just... not what I expect.
Thanks. I'll try to put them in the wiki itself so I can find them easier.
[16:30]
gac410bin/configure sets stuff that generally can't be overridden by the wiki.
file system paths, certain "sensitive" information, Settings within topics are more related to how foswiki displays stuff for users. and generally isn't all that sensitive.
For ex. If *you* have a personal preference for NatSkin, you should be able to set all the requires settings in your user topic. And FINALIZE the settings so that webs and topics can't override your settings.
[16:31]
KAIsbso these two (WebLinkPlugin and FlexFormPlugin) need to be installed separately, right? I don't think I can see them in my installed extensions [16:35]
gac410Yes.
In theory if the NatSkin DEPENDENCIES was built correctly, configure should have installed everything needed. Unfortunately it's a huge install. Some servers time out if it takes too long.
[16:36]
KAIsbthanks all. gotta run to a quick meeting, but I'll be back to finish off [16:37]
gac410I think that I set the timeout at 30 seconds for apache on the vm. [16:37]
***ChanServ sets mode: +o OliverKrueger [16:47]
ChanServ sets mode: +o OliverKrueger [16:55]
foswiki_irc6hi, I am trying to download attached .docx or .xlsx files, but the file says it is corrupt, the file on the file system is fine (have FTP downloaded it), but is corrupt when downloaded via the wiki page (tried IE, Chrome and FF)
I am using the secure attachment option (viewfile)
[17:04]
gac410Which version of foswiki? [17:05]
foswiki_irc6I think Foswiki Release 1.1.5 (according to ReleaseHistory.html) [17:05]
gac410System/InstalledPlugins is a good place to find the version, esp. if you've replaced Main or System WebHome [17:06]
MichaelDaumfoswiki_irc6, try XSendFileContrib to secure attachments. [17:07]
foswiki_irc6I have googled and found stuff relating to icons and mimetypes, but that all seems fine
This site is running Foswiki version Foswiki-1.1.5, Tue, 10 Apr 2012, build 14595, Plugin API version 2.2
[17:07]
MichaelDaumwhich OS is it underneat?
th
[17:07]
foswiki_irc6CentOS release 6.4 (Final)
not heard of "XSendFileContrib" - thank-you
[17:08]
MichaelDaummight be viewfile doesn't read the file from disc in binmode...anyway: viewfile is slow and error prone as it reads all of the file into memory using perl, then sends it to the http server, which then buffers another copy in memory ... all this before the file even sees the first bit on the browser side. [17:09]
gac410Check your setting for $Foswiki::cfg{MimeTypesFileName}
And verify that docx and xlsx are in that file
Foswiki searches the file suffix in that file to determine which mimetype to use when serving the file.
default location would be in data/mime.types
[17:09]
foswiki_irc6yes I have checked that and it seems fine
application/vnd.openxmlformats-officedocument.spreadsheetml.sheet xlsx
[17:12]
gac410okay so that wasn't it. :( [17:13]
foswiki_irc6i will investigate XSendFileContrib [17:14]
gac410viewfile though *should* work. All be it very slow. [17:15]
.............................. (idle for 2h25mn)
KAIsbwell, installed and activated the 2 plugins, which cleaned up the top of the menu on left, but did not clear all the gibberish at the bottom of each post... [19:40]
..... (idle for 20mn)
so, anybody familiar with NatSkin implementation? The new gibberish: http://snag.gy/sLo7M.jpg [20:00]
gac410I have to leave very shortly, but do you have TopicInteractionPlugin enabled?
It might be that or maybe AttachmentsListPlugin ... not sure which MichaelDaum_ would know for sure.
[20:07]
***ChanServ sets mode: +o pharvey [20:13]
KAIsbthanks. had the first one, not the second. Installed but no change.
I guess I'll keep looking.
[20:22]
I'm told that I'm missing Graphics::Magick plugin, but I can't find it in extensions. Any ideas where I should search for it? [20:28]
GuilainCgraphics::Magick is a perl module
you have to install from cpan if need be
but if you're on the VM it should be not necessary...
[20:29]
***ChanServ sets mode: +o pharvey [20:32]
..... (idle for 24mn)
KAIsbok, got it working. It's a bit counter-intuitive for me to have to load a plugin and then turn it on. I would think the default should be that the plugin turns on automatically on load, but allows you to turn off at will later on. Or at least give you the option on load.
But it works now. Thanks all.
[20:56]
.... (idle for 15mn)
chrishellhello, I have the problem that the fw-pages are deformed
I can see the html and css-text
there are however text-boxes and links
the user-registration e.g. has all textboxes to create a new user
but beneath that is just plain css and then html-text
is this a known issue?
[21:11]
.... (idle for 16mn)
***gregg4567 has left [21:30]
ChanServ sets mode: +o pharvey [21:42]
........ (idle for 37mn)
GuilainCKAlsb your idea is interesting, and fell free to write a request feature ;) ; but keep in mind, that the number of active plugin, is part of performances, more your are active plugin, slower it is. automatic activation might create quickly slow web site
chrishell, is on your personal wiki ?
argh... too late
[22:19]
...... (idle for 27mn)
KAIsbOf course too many plugins will slow it down. I was talking about it being intuitive, or not so.
Thanks, I'll look into doing a feature request maybe tomorrow....
for now I just noticed that a test user has overwritten an entry instead of merging it. hmmm... I thought foswiki was supposed to protect against that. I was told as much when I opened the same entry in two different accounts.
good thing I tested it....
At least restore last version worked... :)
[22:46]
GuilainCfoswiki make history more by overwritten, than merge
on data form
topic text page, are merge if two user modify in the same time
if i understand well what merging is for you :)
in wich context
basicly, foswiki is able to make diff betwee two "edit"
[22:55]
KAIsbI'm not quite sure what you mean by "make history more by overwriten, than merge". What happened is I opened a page for editing with one user, then opened up the same page with the admin user (and got the "merge" notice). Admin user made the change and saved. Then when original user made the change (to his unedited/original page), this save overwrote the previous changes made by the admin. No merging happened. [23:02]
GuilainCis exactly this behaviour that I speak about [23:05]
KAIsbwhat about this behavior [23:06]
GuilainClet me try again.
:)
let user1 and user2 two user
topic : topic web page
[23:06]
***ChanServ sets mode: +o OliverKrueger [23:06]
GuilainCuser1 edit the page, modify, save
when user1 click on the edit he has 1 hour (standard time) for his modification and block for the others
imagine, that, after user1 have save, user2 come, and edit page, it get 1 hour too
these, sequentiality create history (revision of a topic), and you can make diff between revision
this is the standard behaviour
now, there is a second one
[23:06]
KAIsbyes, but what happened was user 1 opens, user 2 opens, user 2 changes and saves, user one changes and saves after user 2, user 1 overwrites changes of user 2 with no notice given. [23:09]
GuilainCin the case of : user1 click on edit, user2 click on edit, accept disclaimer and force the modification
and user1 and 2 save their edition , foswiki attempt to make a merge between the edition
ah
this beaviour seems to not be normal for me... (let me think about it)
[23:09]
KAIsbThe only thing explanation that I might have is that user1 had topic open longer than 1 hour. Maybe that's why there was no notice given when user1 saved...
I don't remember for a fact if it was longer than 1 hour - that's what I'll need to try again.
[23:11]
GuilainCdid you get a revision ?
a new revision when user1 overwrite the user2 changes ?
[23:12]
KAIsbI did. That's how I was able to restore to previous version, and that worked. Good thing the second revision was a test...
otherwise I would've had to merge myself, which wouldn't have been fun... :)
But it was "dangerous" as there was no notice given...
Anyway, I gotta run. I'll try it again tomorrow and see if it's consistent...
Thanks for your help
[23:13]
GuilainCthe explanation i have, is your user1 has wait for more than 1 hour, and have submit the topic, without refreshing the content of user2
nevertheless, it's quite strange... :)
try in the same time the same thing
you're welcome, see you g'd night
[23:15]
KAIsbwill do. tomorrow. back in the morning. [23:16]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)