#foswiki 2014-06-02,Mon

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
***gac410 has left [04:34]
.................. (idle for 1h28mn)
ChanServ sets mode: +o MichaelDaum [06:02]
............................................................. (idle for 5h2mn)
gregg4567 has left [11:04]
............... (idle for 1h10mn)
ChanServ sets mode: +o gac410 [12:14]
GithubBot[foswiki] FoswikiBot pushed 1 new commit to master: http://git.io/MJudXQ
foswiki/master f713699 MichaelDaum: Item12929: fixed incorrectly passed parameters with a zero...
[12:15]
***GithubBot has left [12:15]
FoswikiBothttp://foswiki.org/Tasks/Item12929 [ Item12929: EasyMacroPlugin incorrectly passes parameters with number 0 ] [12:15]
.......... (idle for 46mn)
gac410Hi all, Don't forget the release meeting in #foswiki-release channel
Paging all developers Release meeting 1300Z Channel #foswiki-release Starting now!
[13:01]
***dgretch has left [13:09]
...... (idle for 28mn)
ChanServ sets mode: +o Lynnwood [13:37]
................... (idle for 1h34mn)
Tarbox has left [15:11]
....................... (idle for 1h54mn)
gac410Hm. Any opinions. The big effort to always use single quotes in html. Which we really can't finish because we use CGI to generate a lot of html. ...
All of the %X% single character ICON set statements use double quotes. Opinions on changing them all to single quotes for consistency?
Item12060 is actually caused because %X% uses double quotes.
[17:05]
FoswikiBothttp://foswiki.org/Tasks/Item12060 [ Item12060: INCLUDE macros "warn" attribute does not accept dollar-escapes ] [17:07]
gac410The bug is that ICONS cant be used in the warn message because the double-quote terminates the string.
And $percnt was a proposed workaround.
[17:08]
.... (idle for 19mn)
MichaelDaum: Item12915 is fixed. Added ::$action to the page variant. Tested and it fixes the rest / view collision as expected. [17:27]
FoswikiBothttp://foswiki.org/Tasks/Item12915 [ Item12915: The PageCache::genVariationKey() fails to consider the action (view or rest) when calculating a cache key. ] [17:27]
GithubBot[foswiki] FoswikiBot pushed 1 new commit to master: http://git.io/29kCRg
foswiki/master 4665e9e GeorgeClark: Item12915: Include action as a page variant....
[17:30]
***GithubBot has left [17:30]
dgretch has left [17:36]
MichaelDaumgac410, there are some cases which might cause %ICONs to suddenly expand differently - not using double quotes
this is mainly the case for macros that use single quoted params ... which is imho no best practice, but anyway
example: %MACRO{...format='%ICON%'}%
I'd always advocate to use double quotes for foswiki macros ... always ... and single quotes for html attribtues.
unfortunately single-quotes have been made possible in Foswiki::Attrs at some point so we have to live with this. even worse the %ICON param received a quote parameter to configure the quoting style of the markup it produces.
[17:40]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Attrs [17:43]
MichaelDaumall that is remaining here is the insight that (a) we can't fully follow a practice where all html markup generated by foswiki is using single-quote html attributes and (b) that foswiki is already ├╝ber-configurable to use any type of quoting possible ... which creates more confusion and incompatibility than solving any problem
and thats where the quoting story is probably supposed to end
getting rid of CGI.pm is on another list as it is been removed from perl core
[17:46]
.... (idle for 17mn)
gac410Yeah. The question is now that we started the migration (somewhat) to single quotes in html, should %X% et. al. switch to them or remain at double quotes.
Which causes more damage.
tbh I'd also like to deprecate single quotes in foswiki macros. I suspect that that was purely accidental.
I recall that working though a long time ago. vaguely it might have even been true on TWiki. I seem to recall using single quotes back when I was in the working world.
[18:04]
MichaelDaumtoo late for 1.2.0 imho
anything we can skip now is good
[18:11]
gac410yes for sure. [18:11]
MichaelDaumchanging quotes is like playing with fire in a fragile building
it feels more like one of these famous last minute fixes
[18:12]
gac410yes. So Item12060, I don't think that the right answer is $percnt. So maybe close with recommendation to use warn=' ' single quotes in the macro? [18:13]
FoswikiBothttp://foswiki.org/Tasks/Item12060 [ Item12060: INCLUDE macros "warn" attribute does not accept dollar-escapes ] [18:13]
MichaelDaumas long as warn supports standard escapes there is a plan B for users at least [18:14]
gac410hm What would happen if the %X% was defined with the standard \" escapes. Or would that break if the %X% was used outside of a quoted string.
Dumb question I guess. That breaks things for sure.
[18:15]
This works. Though maybe not advisable. Consistent with the quot= option for the %ICON macro
* Set QUOT = "
* Set X = <img src=%QUOT%%ICONURLPATH{warning}%%QUOT% alt=%QUOT%ALERT!%QUOT% title=%QUOT%ALERT!%QUOT% width=%QUOT%16%QUOT% height=%QUOT%16%QUOT% />
ugly. :(
[18:25]
MichaelDaumlet %X% as it is
when using it in warn, use %INCLUDE{ ... warn="$percntX$percnt woops"}%
[18:28]
gac410So the fix is to add standard escapes to INCLUDE [18:29]
MichaelDaumthe more straight forward %X% is defined, the better [18:29]
gac410yeah. [18:29]
MichaelDaumright. that's what I was saying.
as a plan B
%INCLUDE{"ThisTopic" warn="$percntINCLUDE{\"SomethingElse\"}$percnt" }%
[18:30]
.................... (idle for 1h37mn)
***dgretch has left [20:08]
....... (idle for 31mn)
gregg4567 has left [20:39]
........... (idle for 52mn)
ChanServ sets mode: +o gac410 [21:31]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)