#foswiki 2015-03-17,Tue

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
GithubBot[distro] gac410 pushed 1 new commit to master: http://git.io/htpN
distro/master f2edb1e George Clark: Item13308: WebCreateNewTopic enhancements...
[02:10]
***GithubBot has left [02:10]
GithubBot[distro] FoswikiBot pushed 3 new commits to Release01x01: http://git.io/htj8
distro/Release01x01 a87297a Milan Masek: Item12813: Translated using Weblate (Czech)...
distro/Release01x01 c0eecff Martin Dahlem: Item12813: Translated using Weblate (Danish)...
distro/Release01x01 9d3fad0 Raul F Rodriguez: Item12813: Translated using Weblate (French)...
[02:19]
***GithubBot has left [02:19]
GithubBot[distro] gac410 pushed 1 new commit to master: http://git.io/hqeC
distro/master fdb7408 George Clark: Item13294: Punctuation fix...
[02:24]
***GithubBot has left [02:24]
............................................................. (idle for 5h2mn)
ChanServ sets mode: +o CDot [07:26]
....................................... (idle for 3h14mn)
JoachimHoppeI am having a problem with JSCalendarContrib. Clicking on a date has no effect. I read that the use of the calendar with NatSkin can course problems but on the foswiki.org it's running fine. Can somebody help me? [10:40]
........ (idle for 35mn)
GuilainChi JoachimHoppe,
first try it by using pattern, if something wrong with natskin we will be sure
for doing that
take you test topic where you want use JSCalendarContrib
and add at the end of url ?skin=pattern
by doing that you should see your topic with pattern skin and then try to use JSCalendarContrib
and tell us if it's works or note
note = not ;)
[11:15]
JoachimHoppehi GuliainC, have done that and it works [11:18]
GuilainCok good :)
first step is done :)
what exactly is your skin setting ?
skin = ...
and then which version of foswiki you use (you find it inside the System/WebHome topic)
and then which installation have you (OS+ installation type -ie : debian package or tarball-)
[11:19]
JoachimHoppeSitePrferences, Set SKIN = nat [11:21]
GuilainCand finally what's the exact description of your problem (nothing appear, wrong caracter) [11:21]
JoachimHoppefoswiki 1.1.9
OS is windows server 2012
by clicking on the calendar icon the calendar pops up fine. when i click onto a date the date highlights but nothing else
[11:21]
GuilainCso it's like if the mouse click on the date doesn't give the date to the field ? isn't it ? [11:25]
JoachimHoppeWhen I click on the arrow (month or year) the date of the first of the actual month appears in the input field
you are right
[11:26]
GuilainCdo you use JSCalendarContrib for a date field of a DataForm or "inline" in your topic ? [11:27]
JoachimHoppeI am useing FlexFormPlugin. I guess it's integreated in this
but i also tried it in a test topic: <input class="foswikiInputField" id="cal_val_here" type="text"></input>
[11:28]
GuilainCGuilainC takes note and try to find something relevant
and this topic test is the same result ?
[11:29]
JoachimHoppethanks [11:29]
GuilainChum don't say thanks so quickly...
:)
i'm not found anything :(
if you have some knowledge about debugging html web page (firebug for example) try to see if all js files are load
and present
[11:32]
JoachimHoppeunfortunately i don't have knowledge about debugging [11:34]
GuilainCok,
we will find it
you say that foswiki works well, in which topic have you done your tests ?
the aim is for me to have material for testing :)
and then have you done an test with an other browser ?
[11:35]
JoachimHoppeFirefox is showing the same problem
For testing I created a test topic called TestTest
[11:36]
GuilainCin sandbox ?
to be more clear, how have you test on foswiki.org ?
[11:37]
JoachimHoppeno. I am useing a normal web called also called Test
tried the example on http://foswiki.org/Extensions/JSCalendarContrib
i have firebug installed now. if you can tell me what to do it might helps
[11:38]
GuilainChum explaining firebug... is not easy [11:42]
JoachimHoppei feared so [11:42]
GuilainCthe aim is to check error on js file
let me install natskin and js on my personnal foswiki install and i will make the test
hum let me resume
pattern skin + jscalendar... is ok
nat skin + jscalendar is not ok
and you use too flexformplugin
isn't it ?
[11:42]
JoachimHoppedon't want to make it more complicated but I also have problems with MediaPlugin and FlexPaperPlugin showing PDF's. Its might be a general problem with NatSkin [11:44]
GuilainCdo you have last version of natskin [11:44]
JoachimHoppeYour are right. [11:44]
GuilainCok, and you're in the wrong day few foswiki guru are here... :/ let met try on my side to see if i've the trouble too [11:46]
JoachimHoppeRunning NatSkin 3.99 Saw that there is 4 avaiable now but is not offered to update [11:46]
GuilainCand the best is probably disable all plugin except which one we try to work with
do you know how to do it ?
(disable all plugin)
my idea is first test with natskin and only JScalendar
and then add flexformpulgin
and then add all
all plugin
GuilainC needs to lunch, people waiting him
could we see that in 1 hour ?
[11:46]
JoachimHoppeok give me a minute do disable all not plugins exapt natSkin and JS calendar
One hour is fine
in whish plugin contains JScalender
[11:48]
GuilainCok so see you, in one hour
you can enable/disable plugin by setting in your test topic the good parameter in url or inside the topic
please see documentation here : * Set DISABLEDPLUGINS = SpreadSheetPlugin, EditTablePlugin
oups
http://foswiki.org/System/Plugins
and then try to make a circonscription of which plugin are involved in the issue (hoping is an issue from foswiki and not browser or web server :/)
i'm back in one hour
*circonscription* is the bad word even in french, i want to say *to circumscribe* the trouble
find the minimal scope
[11:49]
JoachimHoppeok [11:53]
***ChanServ sets mode: +o Lynnwood [11:57]
....... (idle for 33mn)
ChanServ sets mode: +o RaulFR [12:30]
RaulFRhello all :-)
anyone familiar with NatEdit here?
this string https://github.com/foswiki/distro/blob/master/NatEditPlugin/templates/editdialog.natedit.tmpl#L140 refers to what looks like a Javascript file uploader working with NatEdit
but I cant see any such functionality when using NatEdit on trunk.foswiki.org
I would like to see the dialogs there so as to be sure to make a proper translation
[12:30]
GuilainChi RaulFR, i use natedit on my personnal install, let me 5 sec
RaulFR, go to insert link
(kind of chain)
and then go to files attach (in english) "fichiers attachés" in french
and then press the green + button
and I think you're in the "natedit uploader"
in 1.1.9 everything is not translate
JoachimHoppe, I'm back, have you done some testing by enable/disable plugin for finding exactly which plugins make JSCalendarContrib unusable ?
[12:38]
JoachimHoppeI am still busy enabling all plugins one after the other. give me 10 more minures [12:51]
GuilainCok let me know, I'm starting on my personnal foswiki install to see if I've the same trouble [12:53]
RaulFRhello GuilainC :-) thanks but do you have the same buttons there: http://trunk.foswiki.org/bin/edit/Sandbox/TestNatEditWithTables
GuilainC, the button looking like a chain is for inserting a link, and does not allow uploading a file
GuilainC, the button next to it looks like a paper-clip, this one is named "insert file", but in does not allow for file upload, it can only insert things like: [[%ATTACHURLPATH%/file.ext][descriptive text]] in the editor, that's it
maybe something, some option, is not activated with NatEdit in the 1.2 installation on trunk.foswiki.org
?
[12:56]
GuilainChum, ok I've check under my 1.1.9 version let me try on trunk [13:01]
RaulFRthanks GuilainC
brb
[13:01]
GuilainCRaulFR, it's disappear in this version !
something is broken, and MichaelDaum is not here today
perhaps the best is to put it in the common string task ?
[13:03]
JoachimHoppe, sorry, it's works well under my personnal foswiki installation
natskin + JSCalendar and inline test (wiki code come from the JSCalendarContrib docu)
[13:12]
JoachimHoppeGuilainC, It's done. I disapled all plugins except NatSkin and JScalendar worked fine. Than i enabled one after the next and tested the function until the last and calender is still working. Unfortunately now a lot of other plugins are also not working anymore
it's confusing. I noticed before that it's sometimes nead a while before a change shows effect. Do not know if this is normal
[13:13]
RaulFRGuilainC, the problem is not string related, it is a feature that is missing
at least, it is on the trunk.foswiki.org installation
[13:17]
GuilainCok, RaulFR
ok JoachimHoppe, I'm starting to suspect and plugin order problem
are you familiar with this notion ?
and JoachimHoppe, is the plugin who doesn't work now is on the actual test topic ? not on all the topic ?
JoachimHoppe, I'm speaking about the "Plugin Evaluation Order" in http://foswiki.org/System/Plugins (and who's in the /bin/configure at the "top" (top but below the plugin chaotic list) of the extension tab
[13:23]
JoachimHoppeSorry, can't follow you [13:28]
GuilainCdon't worry :)
so,
you've done some test and then the conclusion is natskin and JSCalendarContrib works well together
isn't it ?
(it's the (1) point)
[13:28]
JoachimHoppethining the same. [13:29]
GuilainCthen (2) you've re-activate one by one the plugin and now some of them doesn't work properly [13:29]
JoachimHoppeI guess it's best to wait until all pages are ok again and than to the same again but slower [13:29]
GuilainCthining ? [13:30]
JoachimHopperight [13:30]
GuilainCright for (1) or for (2) or for both ? [13:30]
JoachimHoppeonly the pages i had open and tested during the pugins are disabled are not looking nice now. i gess it needs a while until the rendered again. Is that normal?
1 and 2 are right
[13:31]
GuilainCok, so is it normal than after having make some test with enable/disable plugin the other plugin doesn't work well ?
normal no, but possible yes depending how you do that
i suppose in you test topic
you have Set ENABLEPLUGIN = ...
[13:33]
JoachimHoppei enabled them in "config", sounds there is a better way [13:36]
GuilainCyou have enable them by the /bin/configure script ? [13:36]
JoachimHoppeyes
or better
[13:36]
GuilainCok... for debbuging i think the better way is to only work in the topic setting field... don't worry
foswiki is most of the time a "repeatable object" ;)
GuilainC thinking
[13:37]
JoachimHoppeI untaked them in configuration / extensions [13:38]
GuilainCthen now, you've check in as they were before and it's doesn't works well [13:38]
JoachimHoppeWhat is the correct way to do it [13:38]
GuilainCfor those who work well before
several way
no better, just different
to be quick, /bin/configure impact all webs
to a user point of view is the same than System/DefaulPreferences and Main/SitePreferences
then you can enable/disable by web and it's impact only on the web
by using the WebPreferences topic
[13:38]
JoachimHoppeyes thats much better [13:40]
GuilainCand then you can enable/disable by topic
by setting variable in the topic itself
for debugging i would suggest first to work in an topic in a sandbox
it's doesn't disturb all other webs and all other users
but don't worry
the most important is to solve your trouble :)
so you're sure to have re-enable all the plugin you want like before ?
and if i've well understand, now, natskin + jscalendarcontrib works but not some others ?
[13:40]
JoachimHoppeyes
natskin + jscalendar are only working in my test topic whish not renderd propper anymore. in a second test topic i didn't opend during the test everything works fine expect jscalender
I am sure it's on of the other plugins
I think it's best to wait until the system is stable again and than try it again. Only disable the plugins by settings in a test web
When i opened the topics and saved them they are all looking fine again. same as before also JS calender is not working
Also it wasn't a success i learnd a lot. I will enable all plugins again on after the other. This time in the web setting :-)
[13:42]
RaulFR!seen MichaelDaum
seen MichaelDaum
WikiRingBot: seen MichaelDaum
[13:53]
WikiRingBotWikiRingBot has last seen MichaelDaum 16 Mar 2015 - 13:57 GMT on #foswiki ... known as MichaelDaum_ now
WikiRingBot has last seen MichaelDaum1 12 Mar 2014 - 19:01 GMT on #foswiki ... joined channel #foswiki
WikiRingBot has last seen MichaelDaum_ 2 Mar 2015 - 15:57 GMT on #foswiki ... known as MichaelDaum now
WikiRingBot has last seen MichaelDaum__ 16 Dec 2014 - 11:12 GMT on #foswiki ... known as MichaelDaum now
[13:54]
GuilainCsorry i've get an urgency
i'm back
JoachimHoppe, don't forget that you need to reload topic for the change makes any effects on the topic
if i were you i will work in a topic setting
not a web
is more small and have less impact on the other users
[13:54]
JoachimHoppeok, thanks for the advice [13:57]
GuilainCand then what i'm suspect is the plugin evaluation order
foswiki have many plugin
by default they are load by their alphabetic name
for a lot of reason sometime that's right for a proper function of the plugin
then, you can change the order
in configure / extension, under the first extension options list at the top of page
[13:57]
JoachimHoppewhat do you mean with plugin evaluation order. how does it effect foswiki [13:58]
GuilainCConfigure how plugins are loaded by Foswiki <br/>{PluginsOrder}
the plugin order will change the order of evaluation of the different marco
marco = macro
GuilainC think about an example
[13:58]
JoachimHoppelooks i have to read about this to understand [13:59]
GuilainCfor reading,
first read System.Plugins
"Plugin Evaluation Order"
section
[14:01]
JoachimHoppei will do [14:02]
GuilainCand then in configure you have the info (i inside a square)
the most important is to find it in configure
:)
and then
the most difficult is to find the right order
you don't have to put all the plugin in the list
just find the right one which make the issue appear
and please share it :)
I'm not sure that the order in enablepulgin variable is taking into account
[14:02]
JoachimHoppei will study it and I have a feeling we will see us here again :-). Thanks a lot for your help
is there an example of propper working orders
[14:04]
GuilainCplease come back, i've to be absent for 2 hours,
I don't think there is an proper working orders so many plugin, my foswiki level is at this point, try to have a good method for understanding the best order :)
[14:05]
JoachimHoppedont't worry my day is nearly finished. will come back after i tested [14:06]
GuilainCnormally there is more guru foswiki, today is specially quiet
some advice too
don't use preview
use save and view
to see all the topic settings you can use SHOWPREFERENCE variable
it's very verbose but very usefull
[14:07]
***ChanServ sets mode: +o CDot [14:10]
GuilainCit think the best should to write a tutorial entitled :"how debugging misconfiguration in foswiki"
JoachimHoppe, what's suprise me is when you pass ?skin=pattern to the url everything were worked well ?
GuilainC perplexe
perplexe = perplexed
sorry JoachimHoppe, need to go, good luck for you investigation
[14:11]
............... (idle for 1h14mn)
jmk0I'm trying to insert anchored URLs into the output from macros in my plugin but it looks like the engine is turning my #s into %23.. is there a way around this?
when i say "engine" I don't mean I've tracked it to Engine.pm, I haven't dug that deeply yet
[15:29]
jastcan you give an example of what you're outputting?
(before it's getting altered by the engine)
[15:32]
jmk0i'd love to except i'm having difficulty there, it looks like writeDebug and saveFile do the same substitution. I tried using print but nothing shows up in the apache logs either :-/
this is the code, fwiw: return "#$tag$ctype"; ... where $tag is just a basic alpha text string and ctype is an alphanumeric string
the output should be ...URL="https://something/wiki/bin/view/WEB/TOPIC#anchor"
[15:34]
jastfor outputting to web server error log, print to STDERR [15:36]
jmk0yeah, I tried that... zip. [15:36]
jastthat, uh, shouldn't happen :)
or maybe your log level in apache is too restrictive
[15:37]
jmk0... or i'm trying to debug the wrong web server, hang on... [15:40]
ok, it's there before I return I thought maybe it's actually in decodeFormatTokens, which I'm using, but I don't see it
it's probably buried in getViewUrl... and I'm appending the anchor to the topic instead of the results of getViewUrl...
looks like moving the anchor append did the job. :)
[15:46]
.... (idle for 18mn)
foswiki_irc8I'm trying to figure out how on a web or topic you can hide some of the text so that only a certian group can see it [16:10]
jmk0.. you might try using %INCLUDE for that section and set access controls in the included file
not sure if that works, but that's all I can think of to try
[16:11]
foswiki_irc8ok cool. I was looking at that but wasn't sure if that was it. I'll give it a go
thank you much
[16:13]
........... (idle for 51mn)
GithubBot[distro] FoswikiBot pushed 2 new commits to master: http://git.io/h3ng
distro/master 16fd186 Raul F Rodriguez: Item13252: Translations updated using Weblate (French)...
distro/master 781ba99 Justin J. Kim: Item13252: Translations updated using Weblate (Korean)...
[17:04]
***GithubBot has left [17:04]
GithubBot[distro] FoswikiBot pushed 1 new commit to Release01x01: http://git.io/h3na
distro/Release01x01 3675777 Raul F Rodriguez: Item12813: Translated using Weblate (French)...
[17:04]
***GithubBot has left
ChanServ sets mode: +o gac410
[17:04]
gac410Hi CDot. I need some advice. Foswiki.pm uses Sandbox validateWeb & validateTopic to untaint the web & topic names But that blanks out incorrect information. If I actually use that to do the untaint, then there is no way for UI to throw meaningful invalid web / topic errors.,
I've completely rewritten the path parser in Foswiki.pm and it so far is working fine. But I have to do untaintUnchecked if I want UI to throw errors.
[17:09]
jaststore a copy of the original web/topic data? [17:10]
CDotShow me a bad path example that yo want to detect as an error [17:10]
gac410foswiki.org/blah/Sandbox some lower case in front of a valid webname. On trunk it crashes. [17:11]
CDotok. So you want "blah" to be detected as an invalid web name, don't you? [17:11]
gac410My new code handles it fine, but I want to leave blah in the path, then UI throws Invalid Web and all is happy.
Yes, But detect in Foswiki.pm is way too early. Not possible to throw, the UI isn't built yet.
[17:11]
CDotCDot isn't sure what "blanks out incorrect information" means
oic. You want an oops if a bad web/topic combo is detected?
[17:12]
gac410untaint \&validateWebName returns a valid web name, or an empty string (or maybe undef)
Right. I want to oops it, not mask it.
[17:12]
CDotok, so remember it happened [17:13]
gac410UI takes care of it. [17:13]
CDotand fire an oops when you are ready [17:13]
jast'oops' is such a nice verb :-) [17:13]
gac410So it's not that Foswiki.pm needs to throw the oops, it just needs to not "fixup" a broken path. Let the UI deal with it like it should,.
But I want to untaint,
[17:13]
jastactually it would be nice to fixup _some_ errors, e.g. wrongly capitalized web name [17:14]
CDotum. Not sure Foswiki.pm should "fix up" anything [17:15]
jastnot trivial to do it right, of course [17:15]
gac410I can do some of that true. But need to be careful. I tried that, and discovered it was so early view vs. rest is not established, so it UC'd the rest method. :P [17:15]
CDoty, if you find yourself using an "if" statement, you probably got it wrong ;-) [17:16]
jastI don't have an up-to-date master branch on this machine... in this very old version requesting /wiki/sandbox/ gives you Main.WebHome, without any warning or error message [17:16]
gac410Other thing it is currently getting wrong is application of queryparams web, topics=web.topic and defaultweb
Yeah. trunk is in bad shape
[17:16]
CDotgac410: one thing at a time. Did I answer your first Q? [17:16]
gac410No [17:17]
CDotthen I'm not clear on what the Q is. [17:17]
gac410My question... do UntaintUnchecked? or some other way vs untaint \&validateWeb...
untaint &validate introduces the issue where bad stuff just disappears.
[17:17]
CDotCDot still can't parse that as a Q, sorry [17:18]
gac410Task was http://foswiki.org/Tasks/Item13185
Okay. Foswiki.pm parses query pathinfo into web & topic, and untaints it. If it uses the Sandbox validateWeb or validateTopic, the untaint changes "blah" to ''
[17:18]
CDotmy view on untaintUnchecked - if you find yourself calling it (without having first validated the data) then you are definitely doing something wrong
the untaint should be *changing* anything
it should just check
shouldn't (I meant, of course. Why do I often do that? :-( )
[17:19]
gac410Right. But it does more than remove evil. It currently is encoded to enforce the Webname regex and Topicname regex
So untaint is either a fully validated web or topic, (syntatically) or nothing.
[17:20]
CDotCDot reviews that code [17:21]
gac410If nothing, then you get the "silent fixup".
My new code is very idferent. I'll create an item branch tonight
[17:21]
jastto be clear, it's not untaint itself doing the clearing, it's the &validateWeb passed to it... and untaint passes on the result from that [17:21]
gac410True. [17:21]
CDotvalidateWebName just calls Foswiki::isValidWebName [17:21]
gac410And if not true, returns ''
Which causes the substitution to UsersWeb, and the magic fixup.
[17:22]
CDotok, that's a poor piece of coding. It should return undef.
magic is generally *bad*
[17:22]
gac410well, undef or '', result is a magic default web / default topic. [17:22]
CDotcode should be clear on what it's doing, and why [17:23]
jaston master, validateWebName does return undef if isValidWebName returns something false-y [17:23]
gac410The current foswiki.pm is a sphagetti nightmare.
right. but Foswiki.pm does $web = (untainted & validated) || usersweb basically
[17:23]
CDotgac410: where? [17:24]
gac410gawd. It probably does it 4 times. the code to DWIM regarding web vs topic is a nightmare IMHO
Hang on ..
[17:24]
CDotyes; it's complex because it's trying to maintain compatibility [17:24]
gac410Starts around line 1965. [17:25]
CDotCDot is reading the code before you started making changes; can we compare line numbers in that? [17:26]
gac410Well it failed miserably. :P. I'll check in my rewrite into an item branch tonight when I'm back home on a real network. [17:26]
CDotCDot wants to be sure we understand what was there before [17:26]
gac410Line 1965 # SMELL: this is a really dangerous hack. It will fail

That's the last code before it digs into the path fixup.
[17:26]
CDotok, so starting at line 2000
my $topic = ""
[17:27]
gac410Yeah sorry... Yes thats where the mess starts. And there is a secondary issue too I documented in Item13185 [17:27]
CDotdown as far as the normalizeWebTopicName call, it's basically establishing the requested web and topic names
the outer normaliseWebTopicName I mean, at line 2040
[17:27]
gac410Line 2110 after # SMELL: what happens if we move this into the Foswiki::Users::new? actually overlays the result of all that code. and establishes a different web/topic. [17:28]
CDotIMHO that normalise is premature, as it risks mapping a null web name to the USERSWEB, but that's an aside
CDot is still working forward from line 2040
so I added a note # Item3270 - here's the appropriate place to enforce spec
[17:29]
gac410Yes I agree. I'm taking a very different approach. I think what I'm doing will work. Only on unit test failed, and I understand it. Needs some more tweaking [17:30]
CDotthat relates to what you are rtying to do, IIRC [17:30]
gac410Yes. That's one fixup. [17:30]
CDotok, so, I agree that come line 2067 there's a risk of pear-shapedness
'' as a default for the web name is probably not constructive
[17:31]
gac410The root cause of the Item13185 crash starts with Line 2017, "topicSpecified" Can be set if the final part is a webname. Ie any URL without trailing slash is triggered as a topic. [17:32]
CDotCDot is still thinking about gac410's first Q
ok, I think I see
[17:32]
gac410What I want to do is validate it enough to untaint it without using the strict rules. Then let UI do the rest of the checking where it can throw meaningful errors.
And I want to clean up the spaghetti
[17:33]
CDotif the validation fails, then you can either (1) attempt to repair it, given superior knowledge or (2) mark the failure, which tells UI to repair it when it is ready
I would be very reluctant to clean up the spaghetti. It is doing some clever stuff to retrieve the web/topic from different sources in different contexts
my inclination would be to flag the problem to UI
e.g. like this:
[17:33]
gac410The web / topic / defaultweb queryparams are completely broken too., So may be clever, but it's busted. [17:35]
CDot$web =
Foswiki::Sandbox::untaint( $web, \&Foswiki::Sandbox::validateWebName )
|| "YOU ARE IN A DARK CAVE. IT SMELLS OF GRUE";
[17:35]
***uebera|| has quit IRC (Quit: ZNC) [17:35]
gac410I love your interesting way of flagging stuff :D [17:35]
CDotone thing at a time?
CDot played Zork when he was a teenager and has never fully recovered ;-)
[17:35]
gac410So one question. If queryparams web, topic are provided, they *should* unconditionally override the pathinfo [17:36]
CDotisn't that the topic of the mythical Item3270? [17:37]
gac410So bin/view/Main/WebHome?topic=Sandbox.WebChanges Should show sandbox, not main. [17:37]
CDotCDot seesm to remember documenting this
I would agree with you
[17:37]
gac410So my take is to make a decision at the top. queryparams or path. Then either parse one or the other. Rather than poking in a conditional here and there. [17:38]
CDotCommandAndCGIScripts: "| =topic= | Overrides the web.topic path given in the URL (specify Web.<nop>TopicName, or <nop>TopicName in compbination with =defaultweb= below) | |"
the decision is already made, for that one anyway
oooh, spot the typo in CommandAndCGIScripts
[17:38]
gac410And once that is done. we need to figure out why User->initializeUser() is overriding the session {webName] and {topicName} [17:40]
CDothum. That sounds like a Svenism [17:40]
gac410When I was testing the query parms, they were flipping back to the pathinfo. That call to initializeUser seems to re-apply the path
Which makes a lot of the logic moot.
[17:40]
CDotwell, it might be puching a topic context?
find /home/foswiki/git/core/lib/ -name '*.pm' -exec grep -PHn '{webName}\s*=' \{\} \;
might help
[17:42]
gac410I'll create an item branch tonight. And you can take a look-see. IMO removing quotes, and dots and slashes should be sufficient to safely untaint in Foswik.pm. given that UI does further checking. [17:43]
CDotnot *removing*, just *detecting*
IMHO it should *not* attempt to fix it
[17:43]
gac410Hm. We "truncate" at first quote. Quotes in the path are probably evil. [17:44]
CDotthat's too sweeping.... you need to be more nuanced than that [17:45]
gac410And dots & slashes are web / topic delimiters. so split( /[\/.]+/, $pathinfo) is what my new parser does. [17:45]
CDotthat's reasonable..... and what normalizeWebTopicName does [17:45]
gac410Hm. I don't think normalize just does a greedy regex to split on last . or / [17:46]
CDoty, probably
it's not it's job to validate
[17:47]
gac410er. I *recall* normalize uses a greedy regex.
right.
[17:47]
CDotit does normalise . to / for the web separator, but that's all [17:47]
gac410The part that gets complex, is the code to detect if the last part of the path is a web or a topic, and if a trailing slash, treat it as a web even if it is a topic. [17:48]
CDotthe Q's you have to answer are these. (1) what regex fully describes a valid web name? (2) Does use of that regex compromise other functions (such as REST)? (3) the same Q's for topic [17:49]
RaulFRhello CDot, gac410, I believe I have found other problems with EDITTABLE, see how the tables in this page look like with the current version http://www.foswiki.org/Community/FrenchTranslation and how it looks with 1.2 on trunk: http://trunk.foswiki.org/Community/FrenchTranslation [17:49]
CDot(4) is it possible to transform the web name *after* Foswiki.pm has finished?
that (4) is a biggy.
[17:49]
gac410transform the webname ??? [17:50]
CDotbecause I strongly suspect it isn't.
y, as im "repair" it
e.g. capitalise the first char
[17:50]
gac410Ah. yeah. I don't think so. Oh... we only do ucfirst on topics currently. [17:50]
CDotso sandbox -> Sandbox IFF the Sandbox web exists
which is what Sven was trying to do
[17:50]
gac410I can do that with my new parser,. As I check each component individually and know when I hit the last one, I can check webExists on the ucfirst version [17:51]
CDotRaulFR: narrow the problems down as far as possible and raise a task, describing in detail how to reproduce the problem.
does webExists work before Foswiki.pm has initialised the session?
[17:51]
gac410Yes. It's purely a store request. [17:52]
CDotif the store is set up in time, then the answer is yes, I guess [17:52]
gac410(Already tested that part :D) [17:52]
RaulFRCDot, ok I'll do that [17:53]
CDotok, then there are a number of transformations you can test from line 2066 of Foswiki.pm
RaulFR: :-)
rather than defaulting to a ''
so $web =
Foswiki::Sandbox::untaint( $web, \&Foswiki::Sandbox::validateWebName )
|| _performSomeIncredibleMagic( $web );
CDot still isn't sure what the content of gac410's OopsException was to be
[17:53]
gac410Just the bad_web message "Invalid or missing web name (blah) "
I'm not touching that part, just trying to get to where it happens again.
Oooh RaulFR I like it. All the table heading are table footings?
[17:55]
RaulFRgac410, yes [17:57]
CDotok. Well, it all seems to make sense to me. Have I helped at all? [17:57]
gac410Yes indeed. I appreciate the guidance. [17:57]
RaulFRgac410, CDot, it looks like it is related to the table sorting macro used there [17:57]
gac410http://trunk.foswiki.org/bin/view/blah/Sandbox and you'll see one bug. [17:57]
CDotRaulFR: lloks like it's sorting the heading, for some reason :-(
it's not supposed to do that. Is it a raw HTML table?
[17:58]
RaulFRyes, also when clicking on the heading for sorting the table, the heading gets sorted inside the other rows too
that may be related to the same reason why the heading gets at the bottom, not sure, I'll report that too
CDot, no, it is a TML table
http://trunk.foswiki.org/Community/FrenchTranslation?raw=on
btw, the "raw" mode in 1.2 in light gray is incredibly hard to read now
[17:59]
gac410+1 I agree. I really hate the new raw look. Low contrast is really bad especially for aging eyes. [18:01]
CDotvery odd; when you "view source" you can see that the teable header is at the *end* of the table
CDot always uses raw=all, no problem for these old peepers ;-)
[18:01]
gac410:) [18:02]
RaulFRthe 1st table is like!
%TABLE{initsort="1" initdirection="up"}%
%EDITTABLE{}%
| *Mot* | *Traduction* | *Phrase d'exemple* | *Traduction d'exemple* | *Remarques* | *cohérence d'ensemble* |
| topic | page | Create new topic | Créer nouvelle page | pas d'article en anglais, pas d'article en français | %BON% |
[18:03]
CDotRaulFR: does it still happen if you turn off the EditRowPlugin? [18:03]
RaulFRthe headers in the TML are indeed at the top
I'll change the page to check that
[18:03]
CDotno, don't bother
it's definitely the editrowplugin causing the problem, on the server side
it'll require some detail research in the code
[18:04]
RaulFRwell, CDot I did it [18:05]
CDotyou broke it? Great! Then you can fix it ;-) [18:05]
RaulFRI removed the %EDITTABLE{}% macro, leaving the %TABLE{initsort="1" initdirection="up"}% [18:05]
CDotoh, it had an initsort? I didn;t notice that [18:06]
RaulFRand the result is also weird : http://trunk.foswiki.org/Community/FrenchTranslation [18:06]
CDotthat's almost certainly the source of the problem [18:06]
gac410btw CDOt ... templates/edit.tmpl still includes the WikiSyntaxSummary that you deleted. Might as well pile on while waiting for heating system repairs. :D [18:06]
CDotok, sorry chaps, this is all wonderful but I have to get back to work. Will take look at what you post for my attention in Tasks tomorrow. [18:07]
RaulFRthe header gets sorted as another row, when removing %EDITTABLE{}%, when adding it, the header get transported as a footer
ok CDot you'll read me tomorrow, take care
WikiRingBot: seen MichaelDaum
[18:07]
WikiRingBotWikiRingBot has last seen MichaelDaum 16 Mar 2015 - 13:57 GMT on #foswiki ... known as MichaelDaum_ now
WikiRingBot has last seen MichaelDaum1 12 Mar 2014 - 19:01 GMT on #foswiki ... joined channel #foswiki
WikiRingBot has last seen MichaelDaum_ 2 Mar 2015 - 15:57 GMT on #foswiki ... known as MichaelDaum now
WikiRingBot has last seen MichaelDaum__ 16 Dec 2014 - 11:12 GMT on #foswiki ... known as MichaelDaum now
[18:11]
RaulFRwell, I need to talk to Michael too, about NatEdit and a problem I found with it while trabslating (which is not related to strings translation). It looks like NatEdit has a Javascript file uploader (at least according to this string this string https://github.com/foswiki/distro/blob/master/NatEditPlugin/templates/editdialog.natedit.tmpl#L140)
I don't use NatEdit on my current installation, but GuilainC does. He confirmed that on the current version, NatEdit has such a dialog, and that the button for accessing the Javascript file uploader are not there on trunk.foswiki.org
I am unsure if this is a bug of version 1.2, or if this is due to an installation problem (or an installation option) on trunk.foswiki.org
or if this a feature that was removed knowingly from NatEdit which is now a Core plugin
if nobody knows here, I'll raise a task for that too
[18:13]
need to go now, I'll reconnect a bit later [18:27]
gac410thanks again CDot. I'll be back later after you all are asleep. [18:35]
***gac410 has left [18:35]
.................................... (idle for 2h59mn)
ChanServ sets mode: +o RaulFR [21:34]
RaulFRhello all :-) [21:35]
............................. (idle for 2h22mn)
***ChanServ sets mode: +o gac410 [23:57]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)