#foswiki 2015-06-29,Mon

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
GithubBot[TopicInteractionPlugin] gac410 pushed 1 new commit to master: http://git.io/vt2Hm
TopicInteractionPlugin/master aec7ecb George Clark: Revert "Item13477: Compatibility with UTF-8 core on Foswiki 1.2"...
[01:06]
***GithubBot has left [01:06]
FoswikiBothttp://foswiki.org/Tasks/Item13477 [ Item13477: Using TopicInteractionPlugin to Upload an attachment produces an Internal Server Error ] [01:06]
jomogac410 why did you reverted? works for me... [01:07]
gac410It was broken. I uploaded a new patch. The prior one fixed uploads, and broke other actions, rename, etc.
Crawford figured out the main issue.
[01:08]
jomoah so.. ok ;) [01:08]
gac410The javascript was encoding the parameters, so that the utf8 decode failed
So I added url decode, but that was bogus.
[01:09]
...... (idle for 25mn)
jomo, anyway patch is attached to the task: http://foswiki.org/pub/Tasks/Item13477/TIP-patch
I've also tested on 1.1.9 with utf8 site charset. Didn't test with iso-8859 site.
[01:34]
............................ (idle for 2h15mn)
RiskRewardHi, I'm trying to construct a query to report the value of a form field, but the field's label has a space in it. My query is: %QUERY{"Approved Revision" topic="%BASETOPIC%"}%. Foswiki responds with "Missing operator in 'Approved Revision". Any idea what I should do? [03:50]
gac410You actually created forms with spaces in the name? The docs suggest to use brackets to support spaces
ie. If you want the Field name to include embedded spaces, use the format [<nop>[FieldName][Descriptive human-friendly Field Name]].
[03:53]
RiskRewardOh. I tried that, but for some reason they didn't work. Maybe because I didn't have the <nop>. It's not too late to change the forms, so I'll try that. Thanks. [03:54]
gac410Hm not sure about that nop.
I suspect that's an artifact of formatting the documentation
[03:54]
RiskRewardHmm. When I look at past versions of the topic now, they use the latest Form, so they are missing data. Any way to make them refer to the form in the state it was orignially in? [03:57]
gac410Hm, I don't think so. [03:58]
RiskRewardActually, removed the <nop>.Works better without it. Think you're right. [03:59]
gac410I just fixed the topic ;) [04:01]
GithubBot[distro] gac410 pushed 1 new commit to master: http://git.io/vtacL
distro/master fa51a01 George Clark: Item9693: Typo in DataForms. <nop> should not be visible
[04:02]
***GithubBot has left [04:02]
FoswikiBothttp://foswiki.org/Tasks/Item9693 [ Item9693: Documentation updates for Foswiki 1.2.0 ] [04:02]
RiskRewardSwift! [04:02]
It looks like when you use the [[][]] approach in a Dataform, it doesn't pick up the field name correctly. Here's an excerpt from my topic: %META:FIELD{name="ApprovedRevision" attributes="" title="[[ApprovedRev][Approved Revision]]" value="A"}%
shouldn't 'name' be 'ApprovedRev'?
[04:15]
gac410tbh I'm not very knowledgeable on forms [04:16]
RiskRewardActually, very interesting. Looks like the "name" is built by collapsing spaces out of the second part of the title, i.s. AprovedRevision becomes ApprovedRevision. [04:21]
........... (idle for 51mn)
***gac410 has left [05:12]
........... (idle for 50mn)
GuilainCRiskReward, an undocumented aspect of DataForms, is the fact that there is by field : field name and field title
title contain spaces, accents (éèàç etc) ,
all this stuff is suppress for create the "name"
and name is used for different query, formatted search, etc
for finding name/title of field
I always used ?raw=all
add to any topic containing the form (not the dataform definition)
for seeing what I'm saying, go to your homepage : Main/RiskReward
and add the ?raw=all
you will see name and title of the field
hoping it could help
[06:02]
RiskRewardThat's great, thanks GuilainC!
So the only reason to use something like "[[ApprovedRev][Approved Revision]]" is to link to a topic, for example to get a list of names to use in a dropdown.
GuilainC: Do you know how to leave the site's footer off a print version created by view.print?
...sorry, cover=print?
[06:04]
GuilainCIMHO, yes, is the only
first modify view.print template
[06:07]
RiskRewardHmm. I can't find the line to remove. [06:09]
GuilainCbut if you are lazy like me i only use template=viewplain
?template=viewplain
if you don't want any color, and it's contains only text, you can ask the ?skin=text too
[06:09]
RiskRewardSome of my colleagues would like "nice printed versions". So still needs to include formatting. [06:11]
GuilainCso viewplain should be sufficient ? [06:12]
RiskRewardWell, my viewprint.tmpl includes a banner to say "uncontrolled copy" etc. [06:12]
GuilainCso you have change your template ?!
so everything is ok ? :)
[06:14]
RiskRewardNo, I created a viewprint.dandi.tmpl [06:14]
GuilainCso what's the question/problem RiskReward ?! :) (it's the morning where I live, and I haven't finish my breakfast cup of tea...
so... still half in my bed ;)
[06:16]
***ChanServ sets mode: +o MichaelDaum [06:17]
RiskRewardAt the bottom of the cover=print page it shows the site's copyright notice. Not sure how to remove this. [06:17]
GuilainCok, so in a foswiki logic
when you press on this link
you cal any viewprint template
any because is depend of your setting in skin variable
do you use (do you know) nat, pattern ?
[06:19]
RiskRewardThink I use pattern. [06:21]
GuilainCso, If I don't say something wrong, it's should be viewprint.pattern.tmpl
GuilainC searchs on /template about copyright (grep -r copyright
[06:22]
RiskRewardsounds right. How do I "comment something out" in that file? [06:23]
GuilainCok, it's foswiki.tmpl which contains line about copyright
but I/we discover that it's used WEBCOPYRIGHT
variable... so it could redefine (somewhere) or comment (in the template file)
see System/DefaultPreferences
and look for "WEBCOPYRIGHT"
so you can change it...
thank you RiskReward to teach to me this tricks :)
[06:23]
RiskRewardNo, thank you for your help! [06:25]
GuilainCso to be clear, don't change DefaultPreferences
you have to put your change in SitePreference
[06:25]
RiskRewardThanks! [06:26]
.............. (idle for 1h8mn)
MarcKloterGood morning. Is there a URL parameter like ?skin= and ?cover= but for ViewTemplates? :) [07:34]
GuilainCtemplate=viewtemplate MarcKloter ;) [07:46]
***ChanServ sets mode: +o CDot [07:55]
....... (idle for 33mn)
MarcKloterThank you GuilainC :) [08:28]
........... (idle for 52mn)
msnI am getting following error while trying to edit a document, the document loads fine then everything goes blank Use of uninitialized value $tml in pattern match (m//) at /var/www/foswiki/lib/Foswiki/Plugins/WysiwygPlugin/Handlers.pm line 728. (/var/www/foswiki/lib/Foswiki/Plugins/WysiwygPlugin/Handlers.pm:728) [09:20]
.... (idle for 19mn)
I get this error when I try to upload something http://paste.debian.net/265308/ [09:39]
GuilainChi msn, could you give us more information about foswiki version used, which OS ? if you've done something this last days (i.e. if it was work before ?!) [09:43]
msnGuilainC: Foswiki version 1.1.9, OS CentOS 7, modperl2
I have recently installed WidgetsSkin but even when i disable it i get this error
[09:47]
GuilainCok give me some minutes for checking code [09:48]
GithubBot[distro] cdot pushed 2 new commits to master: http://git.io/vtVMd
distro/master 42c65c4 Crawford Currie: Item13482: remove CGI::Hidden calls that break multibyte chars
distro/master 8512288 Crawford Currie: Item13482: multibyte fix required to prevent wide-byte error
[09:48]
***GithubBot has left [09:48]
FoswikiBothttp://foswiki.org/Tasks/Item13482 [ Item13482: CGI::Hidden naffs up utf-8 params ] [09:48]
msnGuilainC: I am seetting up foswiki from scratch in alternate directory to make sure problem [09:53]
GuilainCok msn, but I've to say...
I've no idea ! :(
absolutely no idea
how do you disable widgetskin ?
[09:56]
msnyou make some entires in Main/SitePrefrences to enable it, so i remvoed them [09:57]
GuilainCGuilainC check widgetskin plugin
ok, widgetskin need to modify skin variable in order to work
so, what's your skin variable now ?
I supposed you've have suppress all the WIDGETSKIN* variable, isn't it ?
[09:58]
msnGuilainC: yes i did i removed all of them from the siteprefrences [10:00]
jomomsn: few tips. Check the System.InstalledPlugins topic, also System.PerlDependencyReport. No errors? Works under plain CGI? (e.g. not mod_perl? Have you ModPerlEngineContrib installed (for modperl)? [10:00]
.......................... (idle for 2h9mn)
***ChanServ sets mode: +o gac410 [12:09]
gac410Hi everyone. Just a reminder Release Meeting in channel #foswiki-release at 1300Z (45 minutes)
Meeting agenda: Foswiki:Development.ReleaseMeeting01x02_20150629
[12:14]
FoswikiBothttp://foswiki.org/Development.ReleaseMeeting01x02_20150629 [ ReleaseMeeting01x02_20150629 ] [12:15]
....... (idle for 30mn)
jastI won't be there today, I've got the day off and am busy with all kinds of things [12:45]
gac410okay. have a good day off [12:45]
2-minute bell - Release meeting in #foswiki-release [12:58]
..... (idle for 20mn)
***ChanServ sets mode: +o Lynnwood [13:18]
.......... (idle for 46mn)
GithubBot[distro] cdot pushed 4 new commits to master: http://git.io/vtrCT
distro/master d1b3526 Crawford Currie: Item13482: missing dependency
distro/master 20d2db4 Crawford Currie: Item13482: move dependencies to the correct place, otherwise non-Pattern skins may fail to load
distro/master cd3a3ff Crawford Currie: Item13481: move Pattern-skin specific stuff out to PatternSkin. Plus fix pseudo-install so it doesn't fall over on .gz generation
[14:04]
***GithubBot has left [14:04]
FoswikiBothttp://foswiki.org/Tasks/Item13482 [ Item13482: CGI::Hidden naffs up utf-8 params ]
http://foswiki.org/Tasks/Item13481 [ Item13481: Move cruft out of base templates ]
[14:04]
.......... (idle for 46mn)
GithubBot[distro] cdot pushed 1 new commit to master: http://git.io/vtriB
distro/master 7e69e14 Crawford Currie: Item13481: spelling error
[14:50]
***GithubBot has left [14:50]
FoswikiBothttp://foswiki.org/Tasks/Item13481 [ Item13481: Move cruft out of base templates ] [14:50]
GithubBot[distro] gac410 pushed 1 new commit to master: http://git.io/vtrMv
distro/master 82079ee George Clark: Item13480: Remove HIDE_NON_WIKI_WORD_WARNINGS...
[14:56]
***GithubBot has left [14:56]
FoswikiBothttp://foswiki.org/Tasks/Item13480 [ Item13480: Allow non-wikiword is not working correcly. ] [14:56]
jomogac410: http://foswiki.org/Tasks/Item13483 - some unicode problematic extensions... [14:56]
gac410Thanks jomo, good list to start.
jomo, added a column for fix status.
[14:59]
jomook, it is just the extract from my ExtansionsRants local web ;) [15:04]
gac410:) [15:04]
CDotjomo: what does "Utf8problem" mean? [15:05]
jomothat mean the extansion has some problems with the unicode core... (for example double encoding, or wrong encoding and so on. It the flag Dies here - it means - it dies.
jomo just removed the DepreRegexBracers flag - it will come into another Task...
[15:07]
gac410I'm mostly concerned with just capturing a list of "there be dragons here" so we 1) know that we need to investigate further, and 2) 1.2 users can look one place for a list of possible pitfalls. [15:09]
jomofor example: for the DigestPlugin: dies with Wide character in subroutine entry at /me/fw/ExtTest/wikis/DigestPlugin/lib/Foswiki/Plugins/DigestPlugin.pm line 61.
and so on..
[15:10]
gac410If you have that info, it would definitely be helpful to capture that. Maybe just post a comment below the table. Using the comment plugin [15:11]
CDotyes please - otherwise we end up spending a lot of time reproducing what you have already discovered [15:12]
jomoas i told gac - i have an alove web for the Extnstions, each extension has a dat form + the topic contents. The data form contains some "flags" as above the topics contains the destcription - adding eveything into two places - a bit much work.. ;( for the fix you must install it anyway - so will see the error immediatelly).. [15:12]
CDotgac410: we need to do a scan for CGI::Hidden too [15:13]
gac4105 in core
Make that 3.
2 are comments
Foswiki/Form/Label.pm:        CGI::hidden(
Foswiki/Form/FieldDefinition.pm:    return CGI::hidden( -name => $this->{name}, -default => \@values );
Foswiki/LoginManager.pm:        $rest .= CGI::hidden(
CDot: any reason we don't just pass -utf8 flag to CGI?
[15:14]
CDotI don't want it generating utf8 - that's just as bad [15:15]
gac410okay [15:16]
CDotI don't want it doing *any* encoding
I want it to generate perl characters
but can't find a way to make it do that :-(
[15:16]
jomocgi::hidden: ActionTrackerPlugin, BioKbPlugin, ComponentEditPlugin, FormPlugin etc... [15:16]
CDotso eliminating CGI:: calls (which we started)
is the best way to go
jomo: y, just worried about core right now
but yes, they will have to be done
[15:16]
jomook [15:17]
CDotgac410: where was the function we added to do the CGI::tag generation?
CDot has forgotten
[15:17]
gac410There is a separate branch. I never merged it. [15:17]
CDotdid we ever check it in :-/
bugger
ok, so longhand HTML is the only way then :-(
bad. Very bad :-(
[15:17]
gac410Branch HTMLTemplates ... It really needs a feature request and some better thought. [15:18]
CDoteasy to get quotes wrong
ok
[15:18]
gac410I started out basically duplicating the CGI:: calls into Render::HTML but generating using a HTML template. But Michael pointed out that really stuff we do in code with options to CGI really ought to be skinned in the HTML template [15:19]
CDotultimately yes, but that's a *huge* change [15:20]
gac410Right. But just jamming in a new generator without at least considering the design was not a good solution. [15:21]
CDotthere are two places where we are going to get errors
one of them is the FieldDefinition code - the very place GuilainC was talking about
I'm sure I put something in core. It had to handle entity-encoding of param values.
[15:22]
gac410Well the HTMLTemplates branch is there. https://github.com/foswiki/distro/blob/HTMLTemplates/core/lib/Foswiki/Render/HTML.pm [15:26]
CDotwe can't merge this close to a release
just going to have to go the longhand way
CDot wiches we *had* merged, though
[15:29]
gac410Ageed. PLease don't :) One big objection was the BoooOOOgus use of a suffix to indicate entity encoding required
And the one field you need - hidden - is one I didn't do ;)
I assume this then is still a blocker for 1.2.0RC
[15:30]
CDotyes [15:32]
gac410and after that I'll be blind for a few hours, so no 1.2 work until a few hours at least [15:33]
CDotany CGI calls that take data that might potentially include unicode strings are a problem
so really, all the calls you mapped
[15:33]
jomonick jomo_ [15:35]
jomo_brb [15:36]
.... (idle for 19mn)
gac410CDot: Why are we not seeing issues then. The form tests for data anyway jomo did seem fine.
Or is it another cgi version issue
[15:55]
CDotthat's a reasonable question.
I need to go back and revisit what was happening with CommentPlugin.
[15:56]
gac410okay [15:58]
CDotand the answer is; the effect I was seeing was coming from somwehre else (probably the decode fiddling we were doing with TIP)
so there's no problem with CGI, and I can stop panicking :-)
[16:02]
gac410If you're not panicking I'm not panicking. [16:03]
CDotCDot loves the way the browser works when you use characters that are written right-to-left [16:04]
gac410:) [16:04]
.... (idle for 18mn)
CDotgac410: how did you test viewfile?
just want to be sure I'm testing the right thing
https://github.com/foswiki/distro/commit/5787c88824be
[16:22]
n.m. [16:28]
GithubBot[distro] cdot pushed 1 new commit to master: http://git.io/vtowu
distro/master ba0396b Crawford Currie: Item13478: decode_utf8 must happen as soon as possible, and that's when the PATH_INFO is first analysed. Note that by the time it hits the Engine::CGI module it has already url-decoded by CGI, but only to utf8.
[16:41]
***GithubBot has left [16:41]
FoswikiBothttp://foswiki.org/Tasks/Item13478 [ Item13478: Viewfile multiple issues with utf8 filenames and topics ] [16:41]
......... (idle for 44mn)
gac410gac410 is back and not as blind as I expected.
So CDot waddayouthink .... we looking okay for RC? Oh, for testing viewfile, I hacked my apache to redirect everything to viewfile, and then clicked around viewing topics & attachments with utf8 names.
[17:25]
foswiki_irc3anyone want to take a stab at helping out trying to run the configure routine? I suspect my error is this one: CGI -any pragma has been REMOVED. You should audit your code for any use of none supported / incorrectly spelled tags and remove them at /usr/local/share/perl/5.14.2/CGI.pm line 925. BEGIN failed--compilation aborted at (eval 8) line 2. [17:36]
gac410foswiki_irc3: There is a support question handling that one. hang on [17:36]
foswiki_irc3I'm installing on Ubuntu 12.04. I *think* I have the CGI module installed, but perhaps I have an incompatible version? cpan says I have the most current version. (I'm pretty unfamiliar with the whole Perl universe.) [17:38]
jomogac410: wait a half hour with RC... :) need test something... ok? [17:38]
foswiki_irc3thanks. I'll hang on. :-) [17:38]
gac410jomo, okay [17:39]
CDotgac410: FWIW I'm happy. I can't find anything else wrong. [17:39]
gac410CDot: Excellent. [17:39]
CDotI think your multi-version attachment must be an artifact of RCS [17:39]
gac410yeah I saw that. [17:39]
CDotPFS seems to do the right thing
I can't log in to the t.f.o server any more, due to someone changing the port number, and then me forgetting what it is.
[17:39]
gac410gac410 pulls hair. where the heck is the patch for CGI -any Grrrr [17:41]
foswiki_irc3:-) [17:43]
gac410foswiki_irc3: If you've gone to recent CGI, you'll also run into warnings about param called in list context
That one is Foswiki:Support.Question1540
[17:44]
FoswikiBothttp://foswiki.org/Support.Question1540 [ Fetching the value or values of a single named parameter ] [17:44]
foswiki_irc3The code says my CGI is version 4.21 [17:46]
gac410yeah you'll need the patch for multi_param as well. [17:46]
jomoahh damm = Cannot decode string with wide characters at /usr/local/lib/perl5/site_perl/5.16/mach/Encode.pm line 215.
on T.F.O
http://pastebin.com/3AptJxdC
[17:48]
foswiki_irc3reading through that link, it seems to be in the process of being addressed in 1.2. I wonder if I should wait a bit (I'm pretty ignorant about Perl and/or patching it). [17:50]
gac410Is this a new 1.1.9 install or are you an existing site that upgraded perl / CGI [17:51]
foswiki_irc3New install. Just grabbed in on Thursday or Friday last week [17:52]
gac410I'll be building the 1.2.0-RC "Release Candidate" later today. if jomo has not found another blocking bug :P
For CGI, there are 4 places that need update I think
[17:52]
jomogac410 imho the above is blocking.. :( sry. [17:52]
gac410lib/Foswiki/Plugins/WysiwygPlugin/TML2HTML.pm:use CGI qw( -any );
lib/Foswiki/Plugins/WysiwygPlugin/Handlers.pm:use CGI qw( :cgi -any );
lib/Foswiki/Plugins/CommentPlugin/Comment.pm:use CGI qw( -any );
lib/Foswiki/Contrib/MailerContrib.pm:use CGI qw(-any);
... basically the qw( -any ) string has to be removed. So they would all say simply use CGI;
jomo, how did you trigger it.
[17:53]
foswiki_irc3Well, I could wait for the RC and try that - at least I can give some feedback that way. :-) [17:54]
jomo1.) goto http://trunk.foswiki.org/Sandbox/Jomo/UniTestForm 2.) click on the link ČččÉéé - 4th line in the table... [17:54]
gac410looks like crash in TablePlugin ... CDot ??? [17:55]
CDotDon't look at me. i stopped taking the tablets years ago. [17:55]
foswiki_irc3ok... that's sounds easy enough to do (edit the file). I use Microsoft Word to edit it right? (hehehe) :-P [17:56]
gac410are you installing on windows? [17:56]
CDotWTF? Why is TablePlugin tying to decode_utf8? [17:56]
jomofoswiki_irc3: yes, but dont forget save it as pdf ;) :) [17:57]
foswiki_irc3no... just kindding. Ubuntu 12.04
gotcha. Pdf it is! :-)
[17:57]
gac410okay phew. yeah just use nano, or vi if you are familiar
CDot: I added the "if $Foswiki::UNICODE" in c0f50c8e - but the decode was there before me.
[17:57]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::UNICODE [17:59]
jomoCDot: should Task the above? [17:59]
CDotjomo: feel free; just don't assign it to me (I don't touch TablePlugin, on principle) [18:00]
gac410Awe come on. [18:00]
jomoi just asking - i'm never assing nothing to nobody - (i have a wife) [18:01]
gac410BTW CDot ... I just did a grep for decode_utf8 There are a bunch of them in 1.2
LoginManager, NatEdit TablePlugin WysiwygPlugin ...
[18:01]
CDotLoginManager? That's not good
CDot checks
plugins will have them, because they maintain reverse compat
[18:03]
gac410Looks like I added the decode as well.
Topics with utf-8 links could not sort. And I marked it waiting for your review :P
[18:04]
CDotthe one in the LoginManager is a bug, since the latest checkin I did to standardise decode of path_info
the rest are fine AFAICT
[18:05]
gac410That's probably the cause. Now that you decode the path, TablePlugin has a double-decode [18:05]
jomohm.. it is possible to trigger also from here http://trunk.foswiki.org/Sandbox/Jomo/UniTableBug :( /not from a table/ - something happened, because this works days ago... ;) [18:06]
gac410It was git commit 5d9b2319c7d705258b20f72f3abe8a223b4e4476
Anything that generates a table sort link will probably be broken. Core is now decoding the path,
[18:06]
GithubBot[distro] cdot pushed 1 new commit to master: http://git.io/vtKn1
distro/master 9e23f52 Crawford Currie: Item13478: missed one
[18:07]
***GithubBot has left [18:07]
FoswikiBothttp://foswiki.org/Tasks/Item13478 [ Item13478: Viewfile multiple issues with utf8 filenames and topics ] [18:07]
CDotTablePlugin decodes the path_info? Bleagh! [18:07]
gac410yeah. [18:08]
CDotdouble argh. That call to query_string bypasses the Foswiki engine
no way will it work with a non-CGI Engine
[18:10]
gac410Wonderful. [18:10]
CDotand your decode is correct [18:10]
gac410So why is it failing now. [18:11]
CDotbecause CGI stores the query_string undecoded
dunno why it's failing
what was the error?
ah, cannot decode wide chars
hmmm
oh; because you are not urldecoding the query string; you are urldecoding the url - which *is* wide chars
[18:11]
gac410Okay http://trunk.foswiki.org/Sandbox/TestT%C3%B6pic Sort a table column and it crashes. This was *definitely* fixed before the most recent changes
That topic was my test case
[18:13]
CDotyou have concatented a byte string (query_string) to a wide-char string ($url)
and then decoded the result
[18:13]
gac410Hm when did $url become wide. It was fine a few days ago. [18:14]
CDotsince you used a wide topic..... [18:14]
gac410No... I was testing on that specific topic. [18:14]
CDotc3b6 is a wide char [18:14]
gac410I think when you just changed Foswiki, it decoded the URL earlier? [18:15]
CDothuh? [18:15]
jomojomo is again surprised. i was 100% convienced than we have EVERYTHING unicode characters only...
(inside ofc)..
[18:15]
gac410That exact topic and table sort was working fine ... so I have no idea why it's now broken. [18:15]
CDotjomo: not everything. The QUERY_STRING is a special case, because 99% of the time when it's used, it is passed on verbatim into a new encoded url
the url is generated by $url = $cgi->url( -absolute => 1, -path => 1 ) . '?';
[18:16]
gac410Not complaining, just don't understand how my working testcase broke. [18:16]
CDotI have no idea what that does [18:16]
foswiki_irc3:-) Sorry had to take a call. So just to be sure, I just edit those 4 files so that they now read: "use CGI;" correct? [18:16]
gac410yes [18:17]
CDotok, $cgi->url is the script's url
Engine::CGI builds it from the path_info
which recently became decoded
hence your crash
bloody hell :-(
[18:17]
gac410The fixes were for Item2328 Ah... so yes, that's the story. [18:19]
FoswikiBothttp://foswiki.org/Tasks/Item2328 [ Item2328: Table sorting still doesn't work if topic name contains an umlaut ] [18:19]
gac410So my test case was a topic with an umlat and a small table :) [18:19]
CDotI would stilla rgue the TablePlugin code is flying close to the wind
it is assuming the request is a CGI, and not a Foswiki::Request
[18:20]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Request [18:21]
gac410That predates foswiki I suspect. :P [18:21]
CDotI suspect it predates the dinosaurs, myself.
CDot is pretty sure he coded that sort of thing out of the core in twiki Beijing
CDot has gone to eat
[18:21]
gac410That code has had 3 commits. Item327: Rebranding TablePlugin and then my utf8 changes
[18:24]
FoswikiBothttp://foswiki.org/Tasks/Item327 [ Item327: Rebranding TablePlugin ] [18:24]
foswiki_irc3ok.. edited those files (and reverified) but I'm still getting the same error. Perhaps there's another file or three that needs editing as well? [18:29]
gac410could you "pastebin" the traceback http://pastebin.com Mark it for a short lifetime
Need to know which module it crashed in, and line number.
[18:30]
foswiki_irc3FWIW, I didn't edit configure. Didn't see any "use CGI" references in there, but might have missed it. [18:30]
gac410Ah... that reminds me. Check bin/configure for "use CGI
::_loadBasicModule('CGI qw(:any)');
In that case, make it ::_loadBasicModule('CGI');
so it's not a use statement there.
[18:31]
foswiki_irc3so that should be edited to: ('CGI'), correct? [18:33]
gac410yes [18:33]
foswiki_irc3k. will give that a go. brb [18:33]
jomohow to include a topic as verbatim? of course, <verbatim>%INCLUDE{...}%</verbatim> doesn't works. i want <verbatim>the included topic content here</verbatim> [18:37]
gac410I don't think we support that [18:38]
jomojomo just asked (for something like: %INCLUDE{"topic" format="verbatim"}% -ok - no problem... :) [18:39]
GithubBot[distro] gac410 pushed 1 new commit to master: http://git.io/vtKwN
distro/master 48bcacb George Clark: Item13478: And encoding url early breaks TablePlugin
[18:41]
***GithubBot has left [18:41]
FoswikiBothttp://foswiki.org/Tasks/Item13478 [ Item13478: Viewfile multiple issues with utf8 filenames and topics ] [18:41]
foswiki_irc3well.. I got a little further, I think. Now it's complaining about: Failed to load the perl module Foswiki::Configure::Type. The module was found at /var/www/foswiki/lib/Foswiki/Configure/Type.pm [18:41]
FoswikiBothttp://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Configure::Type [18:41]
foswiki_irc3Type.pm seems to have the same issue, so I guess I'll need to edit any other references so that it reads "use CGI", correct? [18:41]
gac410awe darn. Sorry about that ... Looks like -any or :any are both issues. I didn't search for the : version [18:43]
foswiki_irc3fair enough. I can work through it and edit where necessary [18:43]
gac410And it's just those 2. [18:44]
foswiki_irc32? I only ran across the Type.pm one. But it seems to be working now. At least the config screen is up. :-) [18:47]
gac410Excellent [18:47]
foswiki_irc3There's some issues its reporting, so I'll go have a look at those. Thanks for the help! [18:48]
gac410jomo, Table sort is fixed on trunk, if you want to check out the rest of your testing.
CDot might not like my fix, but it seems to work.
gac410 has to run out for a bit.
[18:50]
jomogac410: ok, the 1st part of the test is ascii-only and it is done here http://trunk.foswiki.org/Sandbox/Jomo/TestFormTopic1 check it and ask me, if something is un-understand-able... (what probably is). [19:03]
jesuisseDealing with Item13477... still having problems despite the provided patch. Is anyone (gac410) interested in having me collect some debugging information on the installation where it fails? [19:06]
FoswikiBothttp://foswiki.org/Tasks/Item13477 [ Item13477: Using TopicInteractionPlugin to Upload an attachment produces an Internal Server Error ] [19:06]
jomojesuisse: gac410 seems away for now - but the 1st patch is reverted and dont know about current status. So, need wait for gac410 :) [19:10]
jesuisseOK. Saw he reverted the patch but from the phrasing wasn't sure which part wasn't right. Oh well, I'll wait :-) [19:12]
.... (idle for 18mn)
gac410huh?
There is a patchfile attached to the topic that should fix it up fine. Can't stay long.
I didn't commit it.
and gac410 has to step away again
[19:30]
Hm. I wonder. Crawford made some more core changes, Latest TIP patch might require latest FW core. [19:40]
jesuisseIt works mostly.
Forgot to compress the js file after patching it :-)
[19:40]
gac410Ah... [19:40]
jesuisseNow it's only details that won't work.
Like deleting an attachment and thumbnails.
[19:40]
gac410Hm. Deleting an attachment I tested. But didn't do anything with thumbnails. I don't know the extension all that well. Really depends on MichaelDaum getting some time. [19:41]
jesuisseYes, it's now usable enough to wait for a MichaelDaum fix. Thanks for your time! [19:42]
gac410yw.
Needed to be sure that a complex plugin was able to migrate to 1.2.0 without undue gymnastics
jomo, what's the status on trunk. Are you happy now?
[19:42]
jomoread above
ok, the 1st part of the test is ascii-only and it is done here http://trunk.foswiki.org/Sandbox/Jomo/TestFormTopic1 check it and ask me, if something is un-understand-able... (what probably is).
check and decide how "urgent" this is.. :D
imho = blocker
[19:43]
gac410damn.
gac410 doesn't know the form code very well at all.
[19:43]
foswiki_irc3me again. Sorry to be a pain. Now I'm getting (when hitting the save button in configure): CGI::param called in list context from /var/www/foswiki/lib/Foswiki/Configure/UIs/AUTH.pm line 44, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/local/share/perl/5.14.2/CGI.pm line 404. [19:44]
gac410foswiki_irc3: See http://foswiki.org/Support.Question1540 [19:45]
foswiki_irc3thanks.. I'll have a peek at thast :)
*that
[19:46]
gac410Perl has made some really major changes to CGI and Perl regexes. It gets worse if you ever update to perl 5.22.0 ... all fixed in upcoming Foswiki 1.2.0
jomo. Darn, you are saying it's broken for plain ascii forms.
[19:46]
jomoyes... if I understand forms right - then yes... [19:47]
gac410if 1.1.9 fails in the same way then I probably won't let it block. [19:47]
jomoimho, it is somewhere a typo like $1 instead of $2 or such... :)
okay, test it under 1.1.9 - i have installed it... you need copy only the TestForm topic with the form definition
[19:47]
gac410Okay now that I read it, that one I'm not touching with a 10' pole.
That needs someone who really knows the forms code. If 1.1 takes the names from the title, then changing it will really break lots of existing applications.
[19:49]
jomoi tought that this happens only with unicode, and just today discovered the ascii too problem...
so - don't know - if the 1.1.9 is the same - then it is a "known issue" :)
[19:50]
gac410If I did it right, 1.1.9 only saved 2 fields. http://foswiki.org/Sandbox/TestFormTopic1 [19:54]
foswiki_irc3thanks... that patch seems to have done the trick. Now I just have to address the other issues (like mail), but I'll work through those in due course. Thanks for all the help. It's time to grab some food. :-) [19:55]
gac410jomo, let me know how you make out with the utf8 If' it's consistent with plain ascii on 1.1.9, then I'll go ahead and build RC1
gotta step away for a moment again.
[19:57]
jomook - probably it is the same for unicode.. [20:00]
***foswiki_irc3 has left [20:12]
gac410And did you play with Foswiki:Sandbox.TestFormTopic1 Seeing same as on trunk? [20:13]
FoswikiBothttp://foswiki.org/Sandbox.TestFormTopic1 [ TestFormTopic1 ] [20:13]
jomoyes, checkd it - same as in the trunk - so "known issue" same as 1.1.9 ... (seems, nobody uses field titles) :) [20:15]
gac410Jomo, See Item2097 [20:15]
FoswikiBothttp://foswiki.org/Tasks/Item2097 [ Item2097: FORMFIELD is not working as in TWiki due to chaneg in storing of form data ] [20:15]
jomoYES - this is it - definitely not blocking - very old bug and seems nobody needs the titles feature.. :) [20:17]
gac410Also see Item10025 [20:17]
FoswikiBothttp://foswiki.org/Tasks/Item10025 [ Item10025: title attribute cannot be easily customised ] [20:17]
jomoanyway - want check one more thing? [20:17]
gac410sure
And Item12090
[20:18]
FoswikiBothttp://foswiki.org/Tasks/Item12090 [ Item12090: Field name -with description- in Forms not working properly ] [20:19]
jomook, go to http://trunk.foswiki.org/Sandbox/Jomo/UniTestFormTopic1 - the topic contains text, now click on the EDIT (but on the FORM edit) (not the topic-edit) and select change form, change the form to none - and you will get lost topic text...
dont save the topic at the end..
just cancel - this is an confusing cache problem...
[20:19]
gac410:P GeorgeClark not allowed change on Web [20:20]
jomoomg sec [20:20]
gac410gac410 goes to elevate to admin [20:20]
jomohow to set all? [20:20]
gac410AllowWebChange = *
er ALLOWWEBCHANGE = *
[20:21]
jomodone [20:21]
gac410Damn. and yikes. I think thats a new blocker [20:22]
jomono
this is a cahe problem
if you refresh the cache - it will be ok
[20:22]
gac410Works fine on 1.1.9
Refresh the cache from where?
[20:23]
jomobottom page - "Get a fresh version here." [20:24]
gac410Not for me. [20:25]
jomohm... [20:25]
gac410Clicked refresh, Clicked edit form, Clicked change form, Select None, which takes you to empty topic edit. Hit cancel. [20:26]
jomohm.. then it is a bug..
for me 10 mins ago helped the refresh... but maybe i done something other too..
[20:26]
gac410Hm This time tried without natedit. and it seemed to work. [20:27]
jomoso, deinitely a bug... [20:28]
gac410tried again and it just failed. [20:28]
jomobut maybe not a blocker ;) [20:28]
gac410lemme trace.
Okay, so when you hit the change form it ends up doing a POST to tml2html with text= (empty text field)
[20:28]
jomohm.. if this is a blocker - so sorry ;( [20:33]
gac410well I'd rather we find it now than after it's in production and someone is losing data.
I think that this one will really need MichaelDaum
Or CDot maybe.
Please open a task
again better now than later
[20:33]
jomook going open
http://foswiki.org/Tasks/Item13484
[20:35]
gac410Thanks jomo, you can recreate the issue on any task in the Tasks web. :P [20:39]
jomohuh? please try with another words - somewhat missed the point.. what i should to do? [20:40]
gac410no. sorry. I meant you don't need a test topic, Every task is a test topic. [20:41]
jomoah so... okay
you could add your findings about the POST into the Task...
[20:42]
gac410I bumped it to urgent. Yeah I'll trace it one more time on 1.1.9 and 1.2.0 and try to see what's different
Yeah that's exactly it. After Change Form, the POST to edit has text='' on trunk and text='the raw topic' on 1.1.9
[20:43]
jomojomo going to work on another project - because staying in FW causes no 1.2 will go out.. :D [20:47]
gac410But staying in FW causes a much higher quality 1.2 to eventually go out. [20:47]
jomo:)
hah - great - http://foswiki.org/Development/CustomizeDisplayedFieldTitle - hope Michael could find some free time...
[20:48]
gac410Jomo, task updated with trace. [21:01]
jomo:) foswiki really needs more pieces (clones) of you and cdot ;) :) [21:04]
gac410Confirmed a NatEdit bug. override SKIN to famfamfam,pattern (removing the natedit skin) and the problem goes away. [21:04]
Hm The "hidden" topic body "text" field is there in both cases, but it doesn't get submited on 1.2
gac410 is suspicious of the javascript.
Nah,,, Idiot here. I had disabled NatEdit.
[21:14]
jomolol [21:15]
Schiramael_LockhIs Foswiki a suitable tool for a personal wiki + wiki blog
Or would that bee too much headache?
[21:29]
gac410Foswiki is a very powerful tool, but can be used very simply as well. All depends on what you really want to do.
jomo, so that's the bug. NatEdit has the textarea in a separate tab. Edit form doesn't render the tab at all. no hidden text == poof text gone.
hm Maybe the solution is on the Save side. If text= urlparam is missing, preserve the existing.
[21:29]
jomoomg - hard to track down such bugs... [21:31]
gac410naw. definitely not. Need it in the submit or the editor will be empty.
Ideally edit/save of a form ought to just save the topic and not pop you into the editor.
jomo, it's not just remove the form. Any change in the form loses the topic
[21:32]
jomoSchiramael_Lockh: foswiki is REALLY very powerfull - but this comes with a price... for example, if you expect some very easy theming - you will be surpised - it needs much work... So, really depends what do you want and expect.. the best is - try it yourself...
gac410: wondering how it isn't catched to now..
[21:35]
gac410People don't change forms very often.
at least on Foswiki.org Generally topic sticks with the original form
[21:35]
jomoim in development doing this often - but probably the topics are empty...
so the error isn't visible
[21:36]
Schiramael_LockhI have lots of content (for a personal wiki 5000+ atm, heavily interlinked) interface is not much concern to me.
Are there any features in Foswiki that will help me identify links within the content?
something like backlinks advanced
[21:37]
jomothen foswiki is great - the worst weakness is the interface (hard to theming) - if you satisfied with the standard skin - the FW could be for you TheRightTool [21:38]
gac410Our backlinks search is rather poor. But in generally it has good search facilities. [21:38]
jomoimho Foswiki has only one free competitor what has comparable features - xwiki (written in Java) - but on the other side, it is much more complicated to use (at least for me)... [21:43]
gac410jomo, okay now I'm really baffled. The form issue doesn't fail for me locally [21:48]
jomoi never saw this also locally - therefore i said - it is a cache issue... [21:49]
gac410Hm I'm not getting natEdit locally. wtf Cleaning and trying again. [21:50]
***jomo has left [21:51]
GuilainCSchiramael_Lockh, to my point of view, the core of foswiki is powerfull... but as user of an knowledge base, you don't see his power. For real efficient, install there is many extension which bring the power to the user. for example : Solr integration, Tag cloud and tag, classification plugin, directed graph, and the power of regex.. (with filterplugin for ex) but you need a little knowledge in informatics
oh I forget the MichaelDaum's suite, like harvest, templateinteracitonplugin and so one
[21:55]
Schiramael_LockhThanks everyone. I will try it out. [21:56]
GuilainCand for the blog, blogplugin enable you to have your blog in some min [21:57]
Schiramael_LockhIs there any easy way to import my text files. It is in Wiki syntax [21:57]
GuilainCwhat do you mean by wiki syntax ? [21:57]
Schiramael_Lockhto give a test drive [21:57]
GuilainCMediawiki format ? [21:57]
gac410Hm which wiki syntax. Not all wikis are the same [21:57]
Schiramael_Lockhyes, mediawiki
I don use any complicated stuff
[21:57]
GuilainCok Schiramael_Lockh, there is a plugin for that [21:58]
Schiramael_LockhCan mass import? [21:58]
GuilainChttp://foswiki.org/Extensions/MediaWikiToFoswikiContrib
yes all database
[21:58]
Schiramael_LockhThanks [21:59]
GuilainCneed to be customize to your need
and if you want to play... you have http://foswiki.org/Extensions/Testing/SemanticLinksPlugin
(but never tested)
[21:59]
............. (idle for 1h2mn)
gac410jomo, if you're still around, I've got a fix. But still will need Michael to validate. [23:05]
jomo;) - it is not hot for me (yet) [23:05]
GithubBot[distro] gac410 pushed 1 new commit to master: http://git.io/vtin0
distro/master 98c529b George Clark: Item13484: Tell save that it's a form edit, not a topic...
[23:08]
***GithubBot has left [23:08]
FoswikiBothttp://foswiki.org/Tasks/Item13484 [ Item13484: Changing form to none - causing lost topic content ] [23:08]
jomolol - one line only? nice! [23:09]
gac410Cursory checks seem to indicated that it's fixed, but no idea if there are any corner cases. [23:10]
jomojust for fun - check this topic http://trunk.foswiki.org/Sandbox/Jomo/𝖶𝖾𝖻𝖯𝗋𝖾𝖿𝖾𝗋𝖾𝗇𝖼𝖾𝗌 :) :) [23:15]
gac410What about it?
Looks like a normal WebPreferences
[23:16]
jomocheck teh source
and the WebIndex - here are TWO :)
[23:16]
gac410One written with an alternate utf-8 character? [23:17]
jomoyes :) funny.. [23:18]
gac410Yeah that's one of the security issues with unicode. *especially* email addresses / urls, when its impossible to visually detect hijacking
is it the W ?
[23:18]
jomoyes - next theme to handle in 1.xxx or 2.xxx :)
U+1D5B6 W
U+1D5BE e
U+1D5BB b
U+1D5AF P
U+1D5CB r
U+1D5BE e
U+1D5BF f
U+1D5BE e
U+1D5CB r
U+1D5BE e
U+1D5C7 n
U+1D5BC c
U+1D5BE e
U+1D5CC s
[23:19]
..... (idle for 20mn)
gac410anyway jomo, trunk.foswiki.org is updated, if you want to try to break it. ;) [23:40]
jomolol - going to sleep soon :) [23:40]
gac410okay. g'night
And thanks for the help. That was a great catch.
[23:40]
jomothx:)
RC soon? :)
[23:41]
gac410I'm probably going to wait until tomorrow. Give Michael and CDot a chance to validate my changes.
I'd rather slip a day and only have to do this once.
[23:42]
.... (idle for 17mn)
***jesuisse has left [23:59]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)