#foswiki 2016-10-11,Tue

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
gac410I guess the question is ... will there ever be a case where you need to know that no web was "requested" in the request (path + query params) [00:00]
vrurgI thought that having undef web puts too much burden on a lot of code which would have to check it then. Much less common situation when someone needs to check if there was explicitly defined web name in the request could do so through the Engine.
Ok, we're thinking about the very same thing. ;) My approach is not to try to find out if such case would pop up but keep in mind that it's rare but not totally impossible. And make it possible to check this situation.
BTW, this is the case of HomePagePlugin – it must step in ONLY when no web in the request.
[00:01]
gac410hm. I think in your design, the request is always asked for the requested web, rather than picking up the Webname global. So assigning the defaulit in the request makes sense.
Something odd going on ... I've got some unicode test topics with unicode web / topic and attachment names. None of my pub links to unicode attachments are working. But failing on master too :(
[00:03]
vrurgBut I would have to reconsider visibility rule for _pathParsed attribute. It is private (as _ suggests) but must be published to the world and documented... Because this is where the parse() output is stored.
There was a test case for unicode names. Does it fail too?
[00:07]
gac410It may very well be data issues with my testcases, I was not very rigorous. Some are working some are all messed up.
But since it's failing on master, not your issue ;)
[00:08]
vrurgI'm polishin up code, getting rid of old style calls and similar. Gonna get a lot of failures. [00:11]
gac410I think something is broken in master. Topic has [[Litterbox/Úňíčôďě/ÁťťáčhméňťŤôpíč/FľléxPápěŕPĺúgíň.pdf]] and ls -la pub/Litterbox/Úňíčôďě/ÁťťáčhméňťŤôpíč/FľléxPápěŕPĺúgíň.pdf finds the file just fine [00:12]
vrurgThen wanna learn Foswiki::Config to save itself instead of relying on ConfigureContrib. Wanna make it the first step towards replacing LocaLib.cfg. [00:13]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Config [00:13]
gac410So the encoding in the topic, and on disk are both fine. But if I click the link I get
You don't have permission to access /pub/Litterbox/Úňíčôďě/ÁťťáčhméňťŤôpíč/FľléxPápěŕPĺúgíň.pdf on this server.
[00:13]
vrurgLooks like utf flag gets reset somewhere. [00:14]
gac410damn... failing on Release02x01 branch too. wtf
Checked out FoswikiRelease02x01x01 tag - to get the 2.1.1 release, still failing. Maybe it is my data or config ... strange
[00:15]
vrurgIn my case all unicode was simply washed away from the file name. The resuling file name is valid and everything works fine.
;)
But it could be plackup problem. Will have a look at what's going on.
[00:18]
gac410I'm using apache. Don't worry about it.
I'll try re-uploading and see if it's something oddball in my setup
[00:19]
vrurg"During move of attachment _2016-01-14_04-14.xls to Trash.TrashAttachment an error was found. " – Heh, something definitiely strange goes on. I have added another layer to the problem perhaps. ;) [00:22]
gac410I think in my case it's bad test data. Same attachment on a different topic is working fine. [00:25]
vrurg: Attach, create link, and then trash attachment ... all worked fine here. So my test topic is defunct. [00:30]
vrurgIn my case it's Plack::Request::Upload which is returning damaged filename in basename. I wonder what do they mean by 'basename' then?
Do you have any idea what could it mean? Their doc is too brief on this.
What actually happens upon upload is 'Пенсионная 2016-01-14 до 04-14.xls' filename becomes '_2016-01-14 до 04-14.xls' in basename.
[00:30]
gac410Strange. So it's stripipng the first word from the filename? [00:33]
vrurgI think it's stripping off all unicode. Let me check...
In the source it is using File::Spec::Unix->splitpath. And then replaces spaces with underscores. What for??? I see no sense.
[00:34]
gac410hm the до was preserved. That's not latin is it? [00:35]
vrurgNo, cyrillic. [00:35]
gac410Is that code - replace space wiht underscore, in Foswiki or Plack
We used to replace spaces with underscores, but disabled that option iirc
I just attached your filename on master, and it worked fine.
[00:36]
vrurgIt's in Plack. [00:37]
gac410ugh... that sucks. why would it not support spaces in filenames. [00:37]
vrurgIt seems like File::Spec::Unix->splitpath is removing all unicode from file name. That's really annoying. [00:37]
gac410That shouldn't happen either. I'm pretty sure we use splitpath and I've never heard it fail like that. [00:38]
vrurgDebugged it. It's this line:
$basename =~ s|[^\w\.-]+|_|g;
It's a part of Plack::Request::Upload::basename method.
[00:39]
gac410That's nasty. [00:40]
vrurgPerhaps I shall don't use the method and simply refer to File::Spec on my own. Bypassing the '::Unix' part too, BTW.
It has to be platform independant.
[00:41]
gac410yes. We want to accept filenames with any characters except for the obvious .htaccess .htpasswd and a few other things that we filter.
yup,... same failure here on apache. Пенсионная 2016-01-14 до 04-14.pdf was renamed to _2016-01-14_04-14.pdf on attach.
[00:42]
vrurgBut then I get this: 'Це є copy of Пенсионная 2016-01-14 до 04-14 copy.xls'
And this is what's stored on the dist. Ok, will have something to think of tomorrow.
[00:44]
gac410I think we need to decode_utf8 for the filename
Browser passes in utf8 we need unicode characters
[00:45]
vrurgI'll have to locate the place where to do it. Engine's code would be the most reasonable as this is where the string enters the core. [00:46]
gac410Hm Need to be consistent with Foswiki request. I think we deocde all url stuff ... not sure though. It's one of the "sticky" areas
We spent a lot of time to get that right on 2.0/2.1
[00:47]
vrurgTo my understanding the string must be set to internal encoding when it enters the core. In other words, the rule of thomb is to convert it as soon as got it from the outside.
Ok, time to finish for today.
[00:50]
gac410right. The question is is the Request object "inside" or "outside" ... I think it's inside.
okay ... goodnight
on master, it's the Engine that does the decode_utf8 and NFC normalize the input
[00:51]
vrurgIn the old scheme it's outside. But in my branch Request doesn't get any data directly but by requesting Engine only. This is to guarantee consistency of incoming data througout different environments.
The idea of Engine to me was to be a driver to different kind of servers/protocols. Request must not care what the application is controlled by.
[00:54]
gac410right. [00:56]
vrurgOk, now I'm leaving. Thanks and cu! [00:56]
gac410cu! [00:56]
.... (idle for 18mn)
GithubBot[distro] gac410 pushed 1 new commit to Item13897: https://git.io/vPEmd
distro/Item13897 e1cc0e1 George Clark: Item13897: Fix request tests...
[01:14]
***GithubBot has left [01:14]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ] [01:14]
gac410vrurg ... I fixed the RequestsTests. I'm still not 100% convinced that the Request object should return defaults. anyway... test fixed. [01:16]
................................ (idle for 2h38mn)
***gac410 has left [03:54]
................................. (idle for 2h42mn)
ChanServ sets mode: +o MichaelDaum [06:36]
............................................................ (idle for 4h58mn)
fsfsLy
oops. I meant to ask Lynwood what he found out about PublishPlugin and Foswiki 2.1.2, as I'm seeing the same "Can't locate object method "_renderZones" via package "Foswiki" at .../lib/Foswiki/Plugins/PublishPlugin/PageAssembler.pm line 107." error
[11:34]
................. (idle for 1h20mn)
hmm, PublishPlugin is on the Item13483 list [12:55]
FoswikiBothttps://foswiki.org/Tasks/Item13483 [ Item13483: Incompatible extensions with the unicode core ] [12:55]
fsfsany reason why it shouldn't use the regular Func API for writing files? [12:56]
..... (idle for 23mn)
***ChanServ sets mode: +o Lynnwood [13:19]
................ (idle for 1h15mn)
LynnwoodI have a couple of questions regarding foswiki logging if anyone is knowledgeable about the workings of that. For some reason, the event log file is not getting rotated monthly so the same file has been used since May and has grown huge.
In configure, under the logging settings. I see the comment " Note that on very busy systems, this logfile rotation can be disruptive and the Compatibility logger might perform better." Is this referring to what I'm seeing on this system? If so, can I switch to Compatibility logger easily?
btw, this is a 1.1.10 installation.
...although i'm anticipating updating it fairly soon/
While on the subject, does anyone have recent experience with the experimental LogDispatchContrib.
[14:34]
fsfsLynnwood: last week, you asked about PublishPlugin on 2.1.2 - have you opened an issue about that?
it seems I'm running into similar issues, some of which I hope to have fixed...
[14:41]
Lynnwoodah... no, not yet. I was working on figuring out a short-term solution in lieu of being able to use PublishPlugin. I'll open an issue about that today.
seems to me i got the same error message everytime i ran it.
i'll see if i can find that or i'll reproduce it.
the fact that i got that same message made me a little hopeful that it could be solved.
[14:42]
fsfslet mw know when you and I'll add what I have to the issue [14:44]
Lynnwood[13:05:50] <Lynnwood> Does anyone know if Foswiki::_renderZone() still exist as function?
[13:06:51] <Lynnwood> I'm trying to use PluginPlugin with 2.1.2 and it's failing. Error I get is "Can't locate object method "_renderZones" via package "Foswiki" "
[13:07:54] <Lynnwood> sorry... that's PublishPlugin
That was from Friday
fsfs - what kind of issue are you having?
[14:46]
fsfsyes, exactly the same
the internal API changef an PublishPlugin needs to check fir that
[14:47]
LynnwoodI'm fairly certain that the renderZone function still exist... perhaps it just not calling it correctly. [14:48]
fsfs...but then there are more/different errors... [14:48]
Lynnwoodoh :-(
hope fades... ;-)
[14:49]
fsfsit needs an update to accoint fir utf-8
(excuse my typing - currently on a mobile)
[14:49]
Lynnwoodno worries
i understand
[14:50]
fsfsI got it to actually publish something, but haven't looked at the result yet
anyway, more on that tomorrow!
[14:51]
Lynnwoodgood! Later... [14:52]
.......... (idle for 47mn)
I wish i understood better the perl syntax by which Foswiki references a particular function. [15:39]
.... (idle for 16mn)
If someone _did_ understand Foswiki syntax for calling modules, then they could probably figure out how to change this line from PublishPlugin which is producing error: " my $result = $Foswiki::Plugins::SESSION->_renderZones($tmpl);" [15:55]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Plugins::SESSION [15:55]
Lynnwoodto this line from current Foswiki.pm which does work: " $this->{zones} = new Foswiki::Render::Zones($this);" [15:56]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Render::Zones [15:56]
.......... (idle for 45mn)
fsfsLynnwood: my $result = $Foswiki::Plugins::SESSION->zones()->_renderZones($tmpl); [16:41]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Plugins::SESSION [16:41]
fsfsfrom memory, that's what works for me [16:42]
Lynnwoodreally?! cool. I'll give it a try.
I created task: Tasks.Item14198
[16:42]
FoswikiBothttps://foswiki.org/Tasks/Item14198 [ Item14198: PublishPlugin fails in Foswiki 2.1.2 while trying to render zones ] [16:43]
fsfsLynnwood: I've added what I've got so far to Item14198 [16:56]
Lynnwoodthanks. i'll check it. [16:57]
***ChanServ sets mode: +o gac410 [17:08]
............................ (idle for 2h18mn)
gac410 sets mode: +v WikiRingBot
gac410 sets mode: +o vrurg
[19:26]
........ (idle for 38mn)
FoswikiOnSlack<tddesma> I have a LDAP/AD question for authenticating with Foswiki 2.1.2. Has anyone had any success getting it to work? [20:04]
gac410Yes, we know of a number of sites successfully using LDAP/AD.
Unfortunately I'm not able to help you ... I don't use it.
[20:06]
FoswikiOnSlack<tddesma> We are trying. Just not able to login with the AD credentials [20:07]
gac410There are a lot of support Q&A regarding LDAP configuration: See https://foswiki.org/Support/WebSearch?search=LDAP&scope=all&web=Support [20:09]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)