#foswiki 2016-10-18,Tue

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
gac410vrurg: you around? [01:44]
***gac410 sets mode: +o vrurg [01:44]
....... (idle for 32mn)
ChanServ sets mode: +o Lynnwood [02:16]
GithubBot[distro] gac410 pushed 1 new commit to Item13897: https://git.io/vP19t
distro/Item13897 9ea06bb George Clark: Item13897: Convert Foswiki Macros to use $app->cfg->data
[02:21]
***GithubBot has left [02:21]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ] [02:21]
.................................................... (idle for 4h17mn)
***ChanServ sets mode: +o CDot [06:38]
......................................................................... (idle for 6h1mn)
ChanServ sets mode: +o gac410 [12:39]
.... (idle for 15mn)
ChanServ sets mode: +o CDot [12:54]
....... (idle for 32mn)
foswiki_irc2Hi there, i am unable to get http://localhost/foswiki/bin/configure.pl
i did a fresh install on WAMP on windows
localhost gets me to the frontpage of foswiki but the link above doesnt work
access denied .. missing or illegal web name
[13:26]
***ChanServ sets mode: +o Lynnwood [13:28]
foswiki_irc2does anyone has an idea ?
ah i see.. all the files in bin have no extension .. should i rename them ?
[13:28]
andreas77hello ? [13:34]
gac410hello andreas77 [13:45]
andreas77hi gac410
i managed to install it, thanks anyway
[13:56]
vrurggac410: Hi! I see you were looking form me yesterday. [13:59]
GithubBot[distro] gac410 pushed 1 new commit to Item13897: https://git.io/vPMbX
distro/Item13897 c77e8e4 George Clark: Item13897: Remove Foswiki::cfg access from UI
[14:00]
***GithubBot has left [14:00]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ] [14:00]
gac410vrurg: yeah, but I figured it out :)
good morning
[14:00]
vrurgGood morning :)
I want to move save functionality from the Configure plugin to Config.pm. But that seem to involve moving things like Configure::Item and it's relatives... Damn scary...
[14:01]
gac410config, save thyself
vrurg: I'm seeing another major slowdown, thought I don't think the code is used. AddressTests::test_timing_creation
master: 0.193776 wallclock secs ( 0.20 usr +  0.00 sys =  0.20 CPU) @ 500000.00/s (n=100000)
Item13897: 25.4777 wallclock secs (25.48 usr +  0.00 sys = 25.48 CPU) @ 3924.65/s (n=100000)
[14:03]
***gac410 sets mode: +o vrurg [14:07]
vrurgWill try to check it later today. [14:09]
gac410Core does not use Foswiki::Address at this point, so it's pretty minor, but would be good to understand just for general knowledge. ;) [14:10]
vrurgWow, terribly slow... Will see what nytpof shows. [14:11]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Address [14:11]
gac410Upload tests are broken. ... I'm guessing that's because of the internal changes to plack psgi? [14:12]
vrurgThe last time it was a conflict of calling convensions. I blindly replaced ->new() with ->create() whereas the latter was supplying named parameter to the constructor which doesn't support it. Since it was WebFilter instead of using System web as a template the code was simply copying it over to the new web with all topics and attachments.
No, plack is not related to this. I guess it's another matter.
What suite did you use for uploads? Mine is passing with only failures in cleanup which doesn't affect the tests.
[14:13]
gac410interesting ... If I change the AddressTests to call Foswiki::Address->_new (Code you comment on "keeping around") it is much faster than Foswiki::Address->new
Ah...,. vrurg, never mind. They are all passing, but log Assertion (unable to unlink /tmp/yAMERCG12W/requestTmp/pwzKldznCY : No such file or directory) failed!
yeah, it's in Upload "sub DEMOLISH"
[14:18]
vrurgBTW, regarding the Foswiki::cfg – if a method referencing cfg->data a lot I would recommend storing it into a local variable because both cfg and data are methods. I'm used to do it like: $cfgData = $app->cfg->data; $cfgData->{SomeParam}; No good for tests where createNewFoswikiApp() is used because then $cfgData would reference config from old app object. [14:20]
gac410Ah... :( Okay I'll review what I did
btw ... does the cfg object prevent or flag run-time modification of the configuration?
[14:21]
vrurgThis what always was making me rather reluctant to use of accessors because calling a sub is way to expensive in Perl. But the conflict of reliability vs speed most of the time is resolved in favor for the former.
No, it doesn't. And it is not possible without further additional slowdown.
[14:23]
gac410foswiki is slow enough in places, not good to add it. ;) [14:24]
vrurgWhen you refer data attribute – you refer just a plain hash. [14:25]
gac410that's what I figured.
Didn't know if moo had any object magic
[14:25]
vrurgI could try and make use of tied hash but it is costly. [14:25]
gac410Lets keep overhead down for now. [14:26]
vrurgAny magic comes with a price tag attached. ;) [14:26]
gac410Or we'll probably just have to optimize it out later [14:26]
vrurgBTW, I rewrote the Include's doc handler. Needed more support for OO but the old code was a headache to extend. Would you have some time to see if there is something missing from the new parser or some docs are not handled properly. [14:28]
gac410sure
Did you already commit it? 13187 or 14152
[14:28]
vrurgThanks a lot! Ok, need to finish my work for today first. Hope to get to the Address tests then. [14:29]
gac410Again, no big concern on address tests ... as they are not used. Stale code for now. [14:29]
vrurgIt's in both. I merge to 14152 from 13187 [14:29]
gac410okay thanks [14:29]
vrurgIt is stale but the reason for the slowness could be a deep problem affecting other code. Will see.
Welcome! If you need to compare the old and the new parser just set the USE_LEXICAL_PARSER constant in doc.pm to 0 for the old one.
[14:30]
gac410only thing that jumps out as missing is flagging SMELL or TODO [14:31]
vrurgActually new doc fetches them and inserts into the resulting page. Is there something else to be done? The summary of SMELLS is generated as always – this code is left intact. [14:40]
gac410hm okay, maybe I'm just not spotting any object with SMELLs I'll look some more. [14:41]
vrurgFoswiki::App, Foswiki::Configure have them. [14:43]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::App https://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Configure [14:43]
vrurgOk, I'll be back later today.
Foswiki::Config, though.
[14:43]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Config [14:44]
gac410Hm I'm not seeing them displayed. Logged in as "admin" user. I'll play a bit. [14:44]
***ChanServ sets mode: +o Lynnwood__ [14:49]
gac410with USE_LEXICAL_PARSER = 0, I get the smells, but default =1, no smells are reported for me. [14:52]
......... (idle for 44mn)
vrurgSomehow you''re in 'public only' mode. Are you logged in? [15:36]
gac410yes, I've tried both the internal "admin" login, as well as a registered user in the AdminGroup
And with the old parser, I do get smell, and those would be suppressed as well.
just confirmed. with the old parser, when I log out, the smells disappear, so that code is working fine and I'm logged in correctly.
[15:36]
vrurgI broke the regexp at some point. Will commit the fix soon. [15:45]
gac410unrelated, but the "publiconly" flag is disabled in the PerlDoc topic, with SMELL that it should differentiate public vs. published. Wonder if we ought to just remove the publiconly references as it's not used
okay thanks vrurg
[15:46]
GithubBot[distro] vrurg pushed 1 new commit to Item13897: https://git.io/vPDG0
distro/Item13897 e3423f4 Vadim Belman: Item13897: Fixed SMELL comment regex.
[15:49]
***GithubBot has left [15:49]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ] [15:49]
vrurgTo me 'publicOnly' serves find to hide private methods and potentially unsafe SMELLs. If didn't even get deeper into published logic – just tried to reproduce the old parser behaviour.
If somebody has time and will to get it arranged – that'd be great. But so far I'm happy to have ObjectMethod/ObjectAttribute supported as well as info about what class is inherited and what roles are applied.
[15:51]
gac410y, not suppressing anything is best for now. Not sure how would be best to determine "published" ... but the whole _Method flag for private is not consistently used.
vrurg, yes that fixed it thanks! New parser looks fine IMO
[15:54]
vrurgThere is a pretty way in 13897 to deal with declaring a method public: introduce a keyword for this. ;) Something like: public pubMethod => sub {...};
And then there are few way to handle it and use in doc.
[16:00]
gac410cool
Though let's not add the frosting until later ;)
[16:01]
vrurgAlternative is to use attributes. Looks nice to: sub pubMethod :public {...} – but I have to refresh my memory as attribute sub is being called every time a method/sub get called. This is no good from perfomance point of view.
But if there is a way to register a void attribute without any perfomance penalty then this way would even be better.
vrurg adds a new item to TODO list...
[16:02]
gac410I can't think of any runtime benefit to a keyword though vs a simple comment for the parser. Though maybe warning "private method called by ..." would cut down on some abuse.
(And really p.o. some devs who use private methods :D)
[16:03]
vrurgvrurg is a dev of this kind.
I refer to an Foswiki::Object::_clone_data outside of Foswiki::Object.
[16:04]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Object [16:05]
gac410Though if dev's are forced to use the private methods, it's probably a good sign that the API is missing something. [16:05]
vrurgAlready though about switching it to limited-use public but that's not an emergency.
gac410: You're absolutely right.
[16:05]
........... (idle for 53mn)
gac410: The address test is slow when Assert::DEBUG is on. It's a side effect of Foswiki::Object collecting information about object source including stack trace generated by Carp::longmess. On 10000 times repetition it becomes really visible. [16:58]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Object [16:58]
............. (idle for 1h3mn)
gac410okay vrurg, great, thanks. [18:01]
..... (idle for 21mn)
CDotgac410: apologies for missing the release meeting, been rather busy on incredibly boring things. [18:22]
jmk0hey, is there a "smart" way to run build.pl for making a release package? I tried using git clone on distro, and on my extension (putting it under distro) and running "perl build.pl release" but it's not able to find the packages. I've been adding the .pm locations using the -I option but after the 3rd one it seemed like there must be a better way [18:33]
both gac410's instructions and the Extensions/BuildContrib topic seem to imply it should just work [18:38]
... actually I think the issue is that foswiki expects the JSON module to be installed? The host I'm using doesn't have it so it's failing on that. The rest was just me not having FOSWIKI_LIBS set properly [18:44]
gac410jmk0: BuildContrib should work fine. but y, it expects the foswiki install to be operational and needs the LIBS set corrcectly
Hi CDot .. sorry I missed you - fixing a bathroom fan/heater. :( No problem, I figured you were just busy. But wondering if a different day / time would work better for you or others. We've had it on Monday 1300Z for a long time now.
[18:49]
jmk0was missing "version" as well (terrible name for a perl module IMO).. and LocalSite.cf [19:01]
gac410wow... what version of perl do you have installed ... version is a core perl module, 5.10.1 had the minimum required version
and yes ... horrible name
corelist version
FoswikiBot: corelist version
[19:03]
FoswikiBotgac410: version was first released with perl 5.009 (released on 2003-10-27) [19:03]
jmk05.16.3
i have no oversight on this machine so i have no idea what's up with its config
[19:04]
gac410that definitely should have had the required version of version. It's a core module ... no cpan necessary, except for very old perl [19:05]
jmk0didn't seem to be installed at all for whatever reason [19:05]
gac410That's really hard to do, as it's part of perl. strange.
FoswikiBot: corelist version 0.77
[19:05]
FoswikiBotgac410: version was first released with perl 5.009 (released on 2003-10-27) [19:06]
gac410hm the bot corelist is missing a feature. Should report version 0.77 was released with perl v5.10.1 [19:07]
.... (idle for 15mn)
jmk0bleah, I'll do this at home where I have a bit more control over the host configuration. Too many missing things. [19:22]
gac410strange that it would be this messed up. we generally build pretty easily on a standard install. The tricky stuff is when javascript is involved and you want to use the minimizer code.
That needs node.js installed.
[19:23]
jmk0no LocalSite.cfg, tools/configure requires CGI, MD5, etc
unless there was a more straight-forward way to produce enough of a LocalSite.cfg for BuildContrib
[19:24]
gac410oh, yeah, configure assumes you've got a functional system ... hmm I'm wondering really why we have to have functional foswiki for extensions. But probably true. Building core foswiki uses "view" to generate the html docs, so in that case it's required., [19:26]
jmk0probably wouldn't hurt to have a simple, low-overhead method for generating a LocalSite.cfg file [19:26]
gac410crap... pseudo-install -A *used* to do a simple copy of Foswiki.spec to LocalSite.cfg, and then append all the Config.spec files. But it was proving unreliable, so changed to tools/configure under the covers.
tools/configure gives you a better - thoroughly checked LSC, but it does use the Engine, which pulls in CGI :(
[19:29]
jmk0is the engine necessary? Perhaps the thing to do would be to reverse that dependency, make something that configure sits on top of, instead of the opposite
shared code that could be used w/o the dependencies
just throwing out thoughts, haven't really looked at the details
[19:30]
gac410It's a really complex area. tools/configure uses all of the checkers and internal plugins, wizards, etc. [19:31]
jmk0of course it is :D [19:32]
gac410Pretty much anything you can do with the Web configure UI, you can run with the tools/configure interface. [19:32]
jmk0provided you have the right dependencies ;-) [19:32]
............. (idle for 1h2mn)
***ChanServ sets mode: +o Lynnwood [20:34]
..... (idle for 23mn)
GithubBot[distro] gac410 pushed 1 new commit to Item13897: https://git.io/vPykX
distro/Item13897 c442117 George Clark: Item13897: Minor changes to PerlDoc...
[20:57]
***GithubBot has left [20:57]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ] [20:57]
............................ (idle for 2h16mn)
GithubBot[distro] gac410 pushed 1 new commit to Item13897: https://git.io/vPyBl
distro/Item13897 9cbca2f George Clark: Item13897: compare/compareauth was using old script
[23:13]
***GithubBot has left [23:13]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ] [23:13]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)