#foswiki 2016-11-01,Tue

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
gac410thanks vrurg ... I'll keep adding the tests then [00:14]
........ (idle for 38mn)
vrurggac410: thanks to you two serious bugs were fixed. Actually, if you checked out the commit I commented out a piece of JsonRpcContrib::Server code where it was setting web/topic. As they're now Request's responsibility it doesn't belong there anymore. But would be nice if somebody will review it.
vrurg is playing with Perl6. Great language, slow implementation.
[00:52]
gac410Just found another one. Request::JSON was unconditionally overriding the method in the postdata with the method from the path. If there is postdata, then its the authority for the request. [00:53]
vrurgDamn, I really overlooked this. In my defence I could say that when I started with JSON there was too little understanding of how it works.
:)
[00:54]
gac410gac410 has been reading about docker, dealing with Halloween visitors, ... and now back to json tests.
good reason for tests. :)
[00:55]
vrurgIt is, for sure. And I'm still dealing with visitors. My first real Halloween here, have no idea what to give to the children. [00:57]
....... (idle for 34mn)
gac410well ... turning on / activating more tests. May have found another issue. redirectto=Web.Topic#Anchor works fine. but same parameter when passed in as json data gets encoded as Web.Topic%23Anchor
Me needs to create the same test on master :P
well... check the same test, I think it exists.
[01:31]
GithubBot[distro] gac410 pushed 1 new commit to Item13897: https://git.io/vXYOO
distro/Item13897 dbdb98a George Clark: Item13897: Enable more JSON tests....
[01:35]
***GithubBot has left [01:35]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ] [01:35]
gac410Committing it with the failing test for now. [01:36]
test was disabled on master. Fails there as well, but even as a url param [01:42]
..... (idle for 23mn)
It's a limitation in getScriptUrl which cannot handle anchors. :( and jsonrpc server does it's own handling instead of depending upon core. [02:05]
..... (idle for 23mn)
yeesh. I had added json tests to master. Trying to get them to run on Release02x01 .. and json has lots of issues there. Redirectto is messed up. doesn't process "defaultweb" :( [02:28]
...... (idle for 26mn)
GithubBot[distro] gac410 pushed 1 new commit to Release02x01: https://git.io/vXYGd
distro/Release02x01 62d92f1 George Clark: Item14204: Port JsonRpcContrib tests to 2.1...
[02:54]
***GithubBot has left [02:54]
FoswikiBothttps://foswiki.org/Tasks/Item14204 [ Item14204: Port JsonRpcContrib unit tests from master to Release02x01 ] [02:54]
.... (idle for 19mn)
GithubBot[distro] gac410 pushed 2 new commits to master: https://git.io/vXYZ0
distro/master b7ff177 George Clark: Item13883: Update dependencies...
distro/master 4b0fbfd George Clark: Item14204: Port JsonRpcContrib tests to 2.1...
[03:13]
***GithubBot has left [03:13]
FoswikiBothttps://foswiki.org/Tasks/Item13883 [ Item13883: Documentation changes for master and 2.1 ] [03:13]
GithubBot[distro] gac410 pushed 1 new commit to master: https://git.io/vXYZ9
distro/master 8d393a3 George Clark: Item14204: Failed to return parse errors...
[03:22]
***GithubBot has left [03:22]
.... (idle for 16mn)
GithubBot[distro] gac410 pushed 1 new commit to Item13897: https://git.io/vXYn8
distro/Item13897 0cb9233 George Clark: Item13897: Merge branch 'master' into Item13897
[03:38]
***GithubBot has left [03:38]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ] [03:38]
gac410vrurg: I don't know wtf I did, but I merged master, and I think I got it okay, but the OO branch is totally broken :(
Found it.,
$session not $app in my merge ... missed it :(
[03:44]
GithubBot[distro] gac410 pushed 1 new commit to Item13897: https://git.io/vXYcY
distro/Item13897 a1d2d13 George Clark: Item13897: Fix merge error...
[03:49]
***GithubBot has left [03:49]
gac410fixed [03:49]
....................................... (idle for 3h11mn)
***ChanServ sets mode: +o CDot [07:00]
.... (idle for 16mn)
ChanServ sets mode: +o MichaelDaum [07:16]
....................................... (idle for 3h12mn)
MichaelDaum changes topic to: Logs: http://irclogs.foswiki.org/bin/irclogger_log/foswiki - Slack: https://foswiki-slackin.herokuapp.com/ - Bugs: https://foswiki.org/Tasks - Next up: Release meeting Monday 11/14 1300Z [10:28]
.......................... (idle for 2h8mn)
ChanServ sets mode: +o Lynnwood [12:36]
..... (idle for 21mn)
ChanServ sets mode: +o gac410
ChanServ sets mode: +o Lynnwood__
[12:57]
..................... (idle for 1h40mn)
vrurggac410: Hi! Saw your notice on json tests. So, OO is ahead of the master now in this respect? ;) [14:38]
gac410yeah. [14:39]
................................................. (idle for 4h0mn)
CDot ... when you have some time ;)
There seems to be a deep bug in preferences masked by a bug in the unit tests.
Documented in Item13986
[18:39]
CDotJust back from Scotland, just about caught up. Is it quick? [18:39]
gac410er... "Deep bug in preferences" and "quick" ... not often used in the same sentence. :D [18:39]
FoswikiBothttps://foswiki.org/Tasks/Item13986 [ Item13986: Suspected bug in preferences management. ] [18:39]
gac410I'm looking to confirm vrurg's findings. But my eyes glaze over in prefs and push/pop context.
No big hurry - nothing reported against it, but it would be good to understand
[18:40]
CDotI didn't write the prefs code, and am equally mystified by it :-(
CDot reads the report
[18:44]
gac410gac410 just added the fix vadim made ... found it in the 13987 meta code
The trigger is called whenever the attribute (in this case - text ) is changed.
[18:45]
CDotI sort of understand Vadim's point. And I think I agree, what he says makes sense. [18:46]
gac410okay. thanks. I'll try to fit the fix into 2.1.3 then.
And see what else shakes out ;)
[18:47]
CDoty, more I think about it, more it makes sense. Suggests that's a bug I saw in PublishPlugin, muti-moons ago. [18:47]
gac410cool. His object work is clearly shaking out some rather deep / subtle issues. [18:48]
We don't have an "invalidatePath" in Rel / master. Adding that function, and it indeed fixes the failure in the fixed unit test. Now I wonder what else it shakes out. [19:02]
The full FoswikiSuite ran without issues with that change. I'll commit it, so that we don't stray too far away from the OO branch. [19:13]
vrurgMost fun of it all is that I don't remember the bug... ;) It's good to make reports right away when spoted a problem... [19:13]
gac410y. helps a lot even if it's caught up some months later. Only thing slightly helpful would be to also commit the "fix" using the task. But this one was easy to find, so no bother. I know your commits are often large kitchen sink. ;) [19:14]
vrurgNot anymore, doing in small chunks now. And another point – I never commit to master. Better make a patch if have one. [19:16]
gac410no that's fine. I usually commit to Release02x01, then merge to master, keeps the git history clean. But if you commit to Item13897 branch against a task that identifies as a core bug, it's easier find the commit from the task. [19:18]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ] [19:18]
...... (idle for 29mn)
GithubBot[distro] gac410 pushed 1 new commit to Release02x01: https://git.io/vX3ke
distro/Release02x01 9e6a267 George Clark: Item13986: Fix bug discovered in prefs and meta...
[19:47]
***GithubBot has left [19:47]
FoswikiBothttps://foswiki.org/Tasks/Item13986 [ Item13986: Suspected bug in preferences management. ] [19:47]
GithubBot[distro] gac410 pushed 1 new commit to master: https://git.io/vX3ID
distro/master e42889f George Clark: Item13986: Merge branch 'Release02x01'
[19:58]
***GithubBot has left [19:58]
........ (idle for 36mn)
GithubBot[distro] gac410 pushed 1 new commit to Release02x01: https://git.io/vX3OF
distro/Release02x01 40f745e George Clark: Merge branch 'Item14180' into Release02x01
[20:34]
***GithubBot has left [20:34]
FoswikiBothttps://foswiki.org/Tasks/Item14180 [ Item14180: Bootstrap enhancements and refactoring. ] [20:34]
........... (idle for 50mn)
GithubBot[distro] gac410 pushed 2 new commits to Release02x01: https://git.io/vX38k
distro/Release02x01 d9006fd George Clark: Item14180: Add in BootstrapTests from TestBootstrapPlugin
distro/Release02x01 830a54f George Clark: Item14180: Add test for Apache with mod_rewrite disabled.
[21:24]
***GithubBot has left [21:24]
FoswikiBothttps://foswiki.org/Tasks/Item14180 [ Item14180: Bootstrap enhancements and refactoring. ] [21:24]
GithubBot[distro] gac410 pushed 1 new commit to master: https://git.io/vX38G
distro/master 7c9c5fd George Clark: Merge branch 'Release02x01'
[21:25]
***GithubBot has left [21:25]
.... (idle for 15mn)
gac410vrurg: Are you in a position to test a beta 2.1.3 package on bsd, if I merge in your fix in Item13929 [21:40]
FoswikiBothttps://foswiki.org/Tasks/Item13929 [ Item13929: FileUtil doesn't work correctly with BSD tar. ] [21:40]
gac410Not right now btw. Just sometime before we release 2.1.3 Hopefully by the end of the month. [21:42]
foswiki_irc0Hello, I seems to able to add myself to the admin group but I am not able to edit corresponding pages
The "add members" options seems to work well in the sense that it is able to find and add users
However, in the list of member, I see the name in all lowercase
Should that be in CamelCase?
[21:47]
vrurggac410: In a VM, yes. [21:49]
foswiki_irc0Could someone please help me with understanding the code that adds and removes users to the admingroup? [21:54]
..... (idle for 22mn)
Is %WIKINAME% set to all lowercase? [22:16]
.... (idle for 17mn)
vrurgfoswiki_irc0: No, it shouldn't be. [22:33]
foswiki_irc0Thank you for confirming
when I add a member to the admin group, the member shows up all lower case in the members list
Could you please point me to the correct file to fix this?
[22:34]
vrurgSorry, without digging into the code I cannot help you. Unfortunatly, I don't have time. :( Try coming back to the channel some other time, somebody would help you. [22:39]
foswiki_irc0No problem! [22:39]
.... (idle for 16mn)
GithubBot[distro] vrurg pushed 1 new commit to Item13897: https://git.io/vX3ro
distro/Item13897 7851f88 Vadim Belman: Item13897: Fixed a bug in Foswiki::Net....
[22:55]
***GithubBot has left [22:55]
FoswikiBothttps://foswiki.org/Tasks/Item13897 [ Item13897: Implement ImproveOOModel proposal. ]
https://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Net
[22:55]
gac410foswiki_irc0: what Mapper are you using? TopicUserMapping (the default) Ldap mapping ?? [23:01]
foswiki_irc0Hi gac410
yes
[23:02]
gac410yes Ldap? yes TopicUserMapping? [23:02]
foswiki_irc0Sorry
Yes to Ldap mapping
[23:02]
gac410Ah... okay. Unfortunately I don't know much about that. No ldap here.
So when you use the Groups interface to add a user ... JoeUser, it then displays as "joeuser" ... it lost the case?
[23:03]
foswiki_irc0Exactly!
I am not able to understand why that is happening
when i start typing a username, in the drop down, it shows JoeUser correctly
[23:04]
gac410Well I sort of under stand, but have no idea how to solve. That needs someone more familiar with ldap. [23:04]
foswiki_irc0No problem gac410
Because of loosing the case, I do not get admin privileges
[23:05]
gac410Internally there is a concept of the WikiName, a LoginName, and something called the cUID ... and encoded version of the names to make them acceptable to the system. [23:05]
foswiki_irc0Yes, I think %WIKINAME% is correct
because when a user logs in it shows Hi Joe User!
[23:06]
gac410There are a lot of knobs/dials on ldap mapper to control a lot of that. But other than that, I'm lost :) [23:07]
foswiki_irc0No problem
I am currently lookng at GroupViewTemplate.txt to understand more
[23:07]
gac410Unfortunately the LDAP users are more in Europe... so now is sleep time for them.
I don't think it's the template itself. It's something in how interenally the WikiName/LoginName/cUID all get mapped together.
The templates are more a skin on top of the perl code that does the processing.
[23:07]
foswiki_irc0Yes, I was just trying to find how %WIKINAME% once added to admin group is stored in AdminGroup.txt
I wish I could find the piece of code that connects it
[23:09]
gac410If you look at Main.AdminGroup?raw=all that will show the metadata. The data is not stored in the plain topic text, [23:10]
foswiki_irc0yes, it appears to be showing what is in AdminGroup.txt [23:14]
gac410At the bottom there should be %META: lines [23:14]
foswiki_irc0%META:PREFERENCE{name="GROUP" title="GROUP" type="Set" value="bhargavasana, joeuser"}%
I found that the admin members list is in all lowercase
[23:15]
gac410okay. So the API is putting in the data in lower case. [23:15]
foswiki_irc0Yes, maybe there is some javascript somewhere I need to change? [23:16]
gac410no. That's internal to foswiki.
in the perl, probaby in the mapper.
[23:16]
foswiki_irc0Ok, I will try finding a perl script that updated %META in AdminGroup.txt
Ok, I will try finding a perl script that updates %META in AdminGroup.txt
[23:17]
gac410Probably in lib/Foswiki/Users/LdapUserMapping sub addUserToGroup
It is not going to be touching %META directly.
hm... not there .
[23:18]
foswiki_irc0yeah :(
there is an addUser
[23:19]
gac410If the LdapUserMapping does not implement addUserToGroup, then the group membership is probably done externally in Ldap, not in Foswiki.
But really, I'm not the one to ask.
[23:21]
foswiki_irc0Hmm [23:24]
gac410The code that processes the "add user" button is in lib/Foswiki/UI/Register.pm sub addUserToGroup
Which calls the user mapper code to add the user, which LDAP doesn't implement
[23:25]
foswiki_irc0Each time I add a user, it says it succeded
Could I get any clues from logs?
[23:29]
gac410I understand that. The mapper code is complex. But if the mapper doesn't implement it, it falls back to some default code I think.
I don't really know about logs - I think you are chasing the wrong thing. Look to how Ldap defines groups, not how the WikiGroups define them.
See https://foswiki.org/Extensions/LdapContrib#User_Groups
Did you enable the "Backoff Flag"
If it's enabled, try editing the "Settings" for the AdminGroup ("more topic actions" link) and set the WikiName in the group membership manually.
[23:33]
foswiki_irc0Yes, {Ldap}{WikiGroupsBackoff} is enables [23:36]
gac410It may be that you cannot use the Groups API with LDAP, but have to manually edit. [23:37]
foswiki_irc0I see..that is a great workaround!
I will go ahead with that for now
[23:37]
gac410Well hopefully it works ;) [23:39]
foswiki_irc0Thanks a lot gac410!
You have been helpful every time
[23:39]
gac410I'd guess that in most Ldap deployments, groups come from the Ldap directory. When I worked at a big company, we used a custom mapper and dynamic groups based upon department numbers, etc. [23:40]
foswiki_irc0I feel like I am finally getting close to finishing the migration from 1.5 to 2.x [23:40]
gac410cool. Were groups working on 1.1.5 with LDAP?
The groups API is "newer" ... but I think it was added somewhere in the 1.1.x releases.
[23:40]
foswiki_irc0There appears to be no API like in the current version
I see..maybe I am wrong then
[23:41]
gac410Ah... okay so you manually edit in 1.1.5, with * Set GROUP = JoeUser, FredAdmin, ... [23:41]
foswiki_irc0Yes
I thought I should use the API in the latest version but that appears to be complex when one has ldap
[23:42]
gac410Okay, so Edit Settings gives you the same thing, all be it needing an extra click. LdapContrib either needs to implement that function, or somehow disable it so users are not left confused [23:43]
foswiki_irc0Yes [23:43]
gac410If you have the time, please visit https://foswiki.org/Tasks/LdapContrib and create a task against LdapContrib and the deceptive API and instructions. [23:45]
foswiki_irc0Sure [23:45]
Is it good practice to customize by making a copy of PatternSkinThemeFatWillyNavigation and making changes? [23:51]
gac410Yes, best to copy it to a different name and "set" the navigation topic in Main.SitePreferences.
Set PATTERNSKIN_NAVIGATION_TOPIC=Web.Topic. .
[23:52]
foswiki_irc0Yes, I already set it based on foswiki.org site preferences
I want our web there at the top
however, I am wondering if items in the top navigation bar can be dynamic
[23:55]
gac410hm back to a topic I don't know. As it's a setting, you could use a different setting in different webs. If it's truly dynamic like the horrendous WebLeftBarWebsList, not a good idea.
That's a topic that most sites should kill off.
[23:56]
foswiki_irc0Understood!
Again, thanks a lot for all your help!
[23:57]
gac410yw.
(The trouble with WebLeftBarWebsList is ... it's SLOW, and if you have the PageCache enabled, then *every* page view gets a dependency on *every* WebHome and WebPreferences.
[23:58]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)