#foswiki 2017-01-16,Mon

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
***gac410 changes topic to: Foswiki.org now running 2.1.3 Beta 1! Logs: http://irclogs.foswiki.org/bin/irclogger_log/foswiki - Slack: https://foswiki-slackin.herokuapp.com/ - Bugs: https://foswiki.org/Tasks - Next up: Release meeting Monday 23th Jan 2017, 1300Z [02:16]
...... (idle for 26mn)
GithubBot[distro] gac410 pushed 1 new commit to Release02x01: https://git.io/vMrc7
distro/Release02x01 7749e08 George Clark: Item14263: Correct a typo in configure...
[02:42]
***GithubBot has left [02:42]
FoswikiBothttps://foswiki.org/Tasks/Item14263 [ Item14263: Mistype in Foswiki::Configure::Item ] [02:42]
GithubBot[distro] gac410 pushed 1 new commit to master: https://git.io/vMrcF
distro/master acf8acc George Clark: Merge branch 'Release02x01'
[02:42]
***GithubBot has left [02:42]
.................................................... (idle for 4h18mn)
ChanServ sets mode: +o cdot [07:00]
.... (idle for 15mn)
ChanServ sets mode: +o MichaelDaum [07:15]
..... (idle for 22mn)
GithubBot[distro] MichaelDaum pushed 1 new commit to Release02x01: https://git.io/vMra8
distro/Release02x01 fb960a7 MichaelDaum: Item14265: fixed unblocked ui
[07:37]
***GithubBot has left [07:37]
FoswikiBothttps://foswiki.org/Tasks/Item14265 [ Item14265: NatEdit plugin leaves UI blocked after some save errors ] [07:37]
MichaelDaumwhen I try to enable languages in configure I get "Can't locate object method "get_handle" via package "Foswiki::I18N"" [07:50]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::I18N [07:50]
MichaelDaumcan somebody try to disable internationalization and all languages and then re-enable it via configure, please?
I think there is a fatal error in Foswiki::I18N
[07:52]
can anybody repro https://foswiki.org/Tasks/Item14266 ? [08:00]
..... (idle for 20mn)
GithubBot[distro] MichaelDaum pushed 1 new commit to Release02x01: https://git.io/vMrr6
distro/Release02x01 4cbe297 MichaelDaum: Item13831: merge master
[08:20]
***GithubBot has left [08:20]
FoswikiBothttps://foswiki.org/Tasks/Item13831 [ Item13831: JS error in !System.LanguageSelector ] [08:20]
.............................................................. (idle for 5h9mn)
GithubBot[AutoTemplatePlugin] MichaelDaum pushed 1 new commit to master: https://git.io/vMomN
AutoTemplatePlugin/master 2e5d37e MichaelDaum: Item14267: always at least assign a view template
[13:29]
***GithubBot has left [13:29]
FoswikiBothttps://foswiki.org/Tasks/Item14267 [ Item14267: always at least assign a view template ] [13:29]
GithubBot[MetaCommentPlugin] MichaelDaum pushed 1 new commit to master: https://git.io/vMoYh
MetaCommentPlugin/master 0dd98c1 MichaelDaum: Item14268: implement a registerCommentHandler...
[13:37]
***GithubBot has left [13:37]
FoswikiBothttps://foswiki.org/Tasks/Item14268 [ Item14268: implement a registerCommentHandler ] [13:37]
GithubBot[MultiLingualPlugin] MichaelDaum pushed 1 new commit to master: https://git.io/vMoOQ
MultiLingualPlugin/master 6d03605 MichaelDaum: Item14269: fixed crash translating certain strings...
[13:44]
***GithubBot has left [13:44]
FoswikiBothttps://foswiki.org/Tasks/Item14269 [ Item14269: translation breaks down on certain strings containing bracket links ] [13:44]
***ChanServ sets mode: +o gac410 [13:48]
GithubBot[DBCacheContrib] MichaelDaum pushed 1 new commit to master: https://git.io/vMosq
DBCacheContrib/master e77d1a1 MichaelDaum: Item14270: oo-ify core as far as it isn't yet
[13:58]
***GithubBot has left [13:58]
FoswikiBothttps://foswiki.org/Tasks/Item14270 [ Item14270: oo-ify core as far as it isn't yet ] [13:58]
GithubBot[DBCachePlugin] MichaelDaum pushed 1 new commit to master: https://git.io/vMosh
DBCachePlugin/master 323a29a MichaelDaum: Item14270: major code cleanup oo-ifying the core
[14:05]
***GithubBot has left [14:05]
GithubBot[RtfContrib] MichaelDaum pushed 1 new commit to master: https://git.io/vMoGR
RtfContrib/master c0f21e5 MichaelDaum: Item14271: adjust to latest api changes...
[14:08]
***GithubBot has left [14:08]
FoswikiBothttps://foswiki.org/Tasks/Item14271 [ Item14271: adjust to latest api changes in DBCachePlugin ] [14:08]
gac410Hi MichaelDaum - regarding enabling i18n, are you able to save with just i18n enabled and then reload the server?
To get the correct modules loaded
[14:17]
MichaelDaumyes
but thats awkward isnt it
as soon as the languages are displayed to be chosen from, the select boxes should function properly ... which they dont
[14:20]
gac410y, I suppose at minimal, we could add a warning that after changing that setting, the server must be reloaded. But of course that's not fixing the issue.
I guess we'd have to unload and reload the i18n code, no idea how to do that. And worse it would have to be done on every fcgi handler. ... somehow
[14:21]
MichaelDaumwhy always load Locale::Maketext
or at least implement a dummy get_handler ...
or don't call get_handler when the class isn't ready for it
[14:23]
gac410No idea. That code is pretty obsure to me. Maybe because the MAKETEXT macro has to be functional ?
I've never seen the error in CGI. So probably fcgi/mod_perl only. I usually "spot check" them but seldom run regularly.
Y, confirmed ... just tried it on one of my productuion sites.
[14:24]
MichaelDaumokay at least I am not running into bogus differences on my end [14:28]
gac410I have no idea how to actually fix it, and as it's easy but inconvenient workaround to reload fcgi, I can't see blocking a release.
Unless someone has a fix.
The problem with trying to reload I18N internally, is that you are changing the fcgi env for a new uncommitted configuration, possibly leaving it unstable for other non-configure users.
[14:30]
MichaelDaumbefore creating a new release, let us first try a fix [14:32]
gac410So I think dynamically reloading modules is out. But changing them to avoid the call ( can('get_handle') or similar) might be worth looking into [14:34]
MichaelDaumy [14:35]
gac410It's actually the language checker that has issues. So might be fixable there.
lib/Foswiki/Configure/Checkers/LANGUAGE.pm:    my $h = Foswiki::I18N->get_handle($lang);
[14:35]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::I18N [14:36]
GithubBot[MetaDataPlugin] MichaelDaum pushed 1 new commit to master: https://git.io/vMoc2
MetaDataPlugin/master 750e79a MichaelDaum: Item14272: better interaction with SocialFormfieldsPlugin...
[14:36]
***GithubBot has left [14:36]
FoswikiBothttps://foswiki.org/Tasks/Item14272 [ Item14272: better interaction with SocialFormfieldsPlugin and other improvements ] [14:36]
gac410unless cat(get_handle) Warn: Unable to check languages until fcgi has been reloaded... [14:36]
***ChanServ sets mode: +o Lynnwood [14:37]
MichaelDaumgac410, sounds good [14:37]
gac410Actually it's a pretty obscure check - I'd say even just ignore it. .. Should never happen in real world
"Internal error: $lang is missing the '_language_name' from it's translation.  Language will not be usable."
[14:38]
MichaelDaumsounds even better [14:39]
gac410It only happens if the "special" language name string has not been translated. Typically only happens on master, when a new language is being added/ translated.
Last time I saw it for real was when klingon was added :D
well maybe want to warn - reload fcgi - I think I added that check after klingon was added - as the name was missing and we spent hours trying to figure out why the language just wouldn't enable.
https://github.com/foswiki/distro/commit/1fcce5ae076d ... back in March 2015
There is nothing in weblate to tell the translator to translate the language name. It's just another string.
[14:39]
GithubBot[MoreFormfieldsPlugin] MichaelDaum pushed 1 new commit to master: https://git.io/vMoWU
MoreFormfieldsPlugin/master 6133cf1 MichaelDaum: Item14273:...
[14:50]
***GithubBot has left [14:50]
FoswikiBothttps://foswiki.org/Tasks/Item14273 [ Item14273: replace MoreFormfieldsAjaxHelper with a template solution to be able to override it when required ] [14:50]
gac410MichaelDaum: I have a fix for the get_handle - gave a very rudimentary test on my live site. I'll check it in.
I just disable the test - This really is a never-will-happen, except on trunk.foswiki.org ... or if someone tries to cobble in their own translation.
[15:04]
GithubBot[distro] gac410 pushed 1 new commit to Release02x01: https://git.io/vMo82
distro/Release02x01 aed1dc4 George Clark: Item14266: Don't check LANGUAGE name...
[15:09]
***GithubBot has left [15:09]
FoswikiBothttps://foswiki.org/Tasks/Item14266 [ Item14266: Error enabling internationalization and languages ] [15:09]
GithubBot[distro] gac410 pushed 1 new commit to Release02x01: https://git.io/vMo45
distro/Release02x01 219bb4d MichaelDaum: Item13831: improve js changing languages...
[15:17]
***GithubBot has left [15:17]
FoswikiBothttps://foswiki.org/Tasks/Item13831 [ Item13831: JS error in !System.LanguageSelector ] [15:17]
gac410MichaelDaum: Cherry-picked Item13831 from master to Release02x01. Good catch. These commits to the wrong branch are really tough to spot.
I *hope* it's complete now.
[15:18]
GithubBot[distro] gac410 pushed 1 new commit to master: https://git.io/vMoBg
distro/master dc9eb0e George Clark: Item14266: Merge branch 'Release02x01'
[15:21]
***GithubBot has left [15:21]
gac410MichaelDaum: I think 2.1.3 and master are now synced up. Please verify this. Thanks. [15:24]
MichaelDaumyes it is fine according to my git [15:26]
gac410okay thanks. [15:26]
MichaelDaumhad some conflicts in natedit but thats because I am shaking it up a lot over here
for 2.2
[15:28]
............... (idle for 1h10mn)
gac410Hi MichaelDaum I meant to ask a while back. Do IRC messages with [off] get blocked from logging on Slack as well? [16:38]
MichaelDaumno [16:38]
gac410If not, that's a pretty bad situation. yikes
So that means that stuff we filter from the foswiki logger is really not filtered. Can an op temporarily "kick" the slack bot. Not having semi-private posting is really really bad.
gac410 needs to check my local logs for stuff that may have been logged anyway.
[16:38]
MichaelDaumyou can delete unwanted messages directly in slack: right click on message->delete [16:40]
gac410Only if we are on slack. This is not good not good at all. [16:40]
MichaelDaummeanwhile slack history is not accessible to google or whatever
only slack users can search thru history
offity isnt really security
[16:40]
gac410But it does prevent logging - which can be very important. [16:42]
***gac410 sets mode: +v FoswikiBot [16:42]
gac410Is the slack irc bot something you wrote. Can it be changed to filter out [off] lines? [16:44]
MichaelDaumthis is https://github.com/ekmartin/slack-irc
let me see how hard it is to implement
just upgraded it to the latest release
[16:45]
gac410anyway, not all that urgent, but must remember to just use PM now rather than [off] Dug through my pidgin logs - definitely stuff I didn't want in history, but nothing all that sensitive Just stuff I'd rather not have been logged publicly [16:53]
stefan_slighthello @all :-) i have a question regarding usernames and LDAP -
we have a user name that contains a - (something like max-samuel)
[16:56]
and in the wiki something gets messed up - if this user edits a topic the username shown in in the breadcrumb and in the Topic revision line is messed up like this:
max_2dsamuel
[17:04]
MichaelDaumtest 123
test 123
[on] test 12345
gac410, okay works now
[17:05]
gac410Great ! Thanks
stefan_slight: sound like something is not quite right in the ldap user mapper. not my area of expertise though :(
[17:07]
stefan_slightwe have checked in the pfv dir it is also written in this way. [17:09]
gac410y special characters are supposed to be encoded as _xx but they should also get reversed [17:09]
stefan_slightthey get encode quite well :-)
but on reading it seams foswiki does not decode it back...
[17:10]
gac410Are you using the LdapUserMapper? Foswiki uses 3 ID's. The WikiName, the external loginname and a cUID (canonical userid) which is the login name encoded so it is acceptable to ancient tools like rcs.
The mapper is responsible for the conversions.
cUID is always written to the topic Meta. but should be mapped to WikiName on display
[17:12]
stefan_slightwe have tried and edited the pfv file and written max-samuel -then the history and breadcrumb looked correct
ok
so only the last part did not work - the cUID to WikiName remapping
[17:13]
gac410There are definitely known bugs - sometimes the mapping is ambiguous. [17:14]
stefan_slightcUID is written correctly to Meta. (with the - encoded as _2d)
ah ok -hm
[17:14]
gac410MichaelDaum or jast might know more. [17:15]
stefan_slighti will look at the LdapUserMapper settings.
thanks for your help gac410
so now i know where it happens... ;-)
its the first step to solve it..
[17:16]
gac410I don't see that specific issue listed in https://foswiki.org/Tasks/LdapContrib [17:18]
MichaelDaumstefan_slight, the next release of LdapContrib will have a flag to disable this unwanted mapping: $Foswiki::cfg{Ldap}{UseCanonicalUserIDs} = 0;
and it will even default to 0 as the way standard foswiki handles mappings to canonnical uids is quite destructive ... and not reversible in some cases
for instance when a user login really is frank_5foster
[17:20]
gac410if it defaults to 0, won;t that break existing mappings / topic history? [17:22]
MichaelDaumyes
switching this mid-flight is a bad thing to do (tm)
[17:22]
stefan_slighthm [17:22]
gac410Do you know if the old rcs tools can handle special characters now?
iirc cUID was mainly needed because of rcs limitations :(
[17:22]
MichaelDaumfrank_foster was always fine as well as frank-foster
this mapping yadda is simply a pita
[17:24]
stefan_slightso foswiki/the ldap mapper doesn't try to reverse the encoding currently? [17:24]
gac410Item13177 is probably the task that exposes the internal design flaws. But it's a major restructuring to really fix it. [17:27]
FoswikiBothttps://foswiki.org/Tasks/Item13177 [ Item13177: when loginName contains specials, $SESSION->{user} double-encoded as a cUID when passed to checkAccessPermission() ] [17:27]
stefan_slightok - so i will wait for the next LdapContrib release to switch it off.... ;-) (i think iam fine with manually running a script in the data folder to exchange this one username with the correct username...)
thanks you two for explaining this to me :-)
[17:33]
MichaelDaumyour are welcome :) [17:42]
...... (idle for 29mn)
GithubBot[LdapContrib] MichaelDaum pushed 1 new commit to master: https://git.io/vMoFP
LdapContrib/master 18776fd MichaelDaum: Item14275: add parameter to switch off cUIdity
[18:11]
***GithubBot has left [18:11]
FoswikiBothttps://foswiki.org/Tasks/Item14275 [ Item14275: add parameter to switch off destructive mapping of logins to canonnical user ids ] [18:11]
MichaelDaumstefan_slight, new LdapContrib 7.60 is available. have a try. [18:13]
gac410MichaelDaum is on fire today! [18:13]
GithubBot[LdapNgPlugin] MichaelDaum pushed 1 new commit to master: https://git.io/vMobZ
LdapNgPlugin/master bc658ab MichaelDaum: Item14276: properly detect users in all DNs...
[18:17]
***GithubBot has left [18:17]
FoswikiBothttps://foswiki.org/Tasks/Item14276 [ Item14276: properly detect users in all DNs configured in UserBase ] [18:17]
MichaelDaumgac410, me working towards a codebase ready for blog.foswiki.org [18:19]
gac410the 2.1.3 beta has been untarred into the test.blog.foswiki.org directory. But an "intercept" is still in place to bloc web access [18:19]
MichaelDaumstill got 30 plugins waiting for a new release [18:20]
gac410I was just thinking of running CLI configure to get the base configuration.
Want to take this over to #foswiki-admin ?
I was thinking that initially I'd set it up as a completely standalone instance, but later symlink .htpasswd and Main over to f.o And override SitePreferences to be BlogPreferences
[18:20]
stefan_slightMichaelDaum: thanks :-) will try it tomorrow! [18:22]
gac410well I've never seen this before. "perl tools/configure" shows me the source code. ... wtf [18:25]
GithubBot[RenderPlugin] MichaelDaum pushed 1 new commit to master: https://git.io/vMoNW
RenderPlugin/master 45222bf MichaelDaum: Item14277: add a filename parameter to override it...
[18:26]
***GithubBot has left [18:26]
FoswikiBothttps://foswiki.org/Tasks/Item14277 [ Item14277: add a =filename= parameter to override it in content-disposition ] [18:26]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)