#foswiki 2017-01-31,Tue

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
GithubBot[distro] FoswikiBot pushed 1 new commit to master: https://git.io/vDI7j
distro/master f12adb9 CH yang: Item13884: Translations updated using Weblate (Chinese (Taiwan))...
[01:47]
***GithubBot has left [01:47]
FoswikiBothttps://foswiki.org/Tasks/Item13884 [ Item13884: Translation changes for master and Foswiki 2.1 ] [01:47]
GithubBot[distro] FoswikiBot pushed 1 new commit to Release02x00: https://git.io/vDI5J
distro/Release02x00 adea75c CH yang: Item13505: Translated using Weblate (Chinese (Taiwan))...
[01:48]
***GithubBot has left [01:48]
FoswikiBothttps://foswiki.org/Tasks/Item13505 [ Item13505: Translations for Foswiki 2.0.x ] [01:48]
GithubBot[NatSkin] FoswikiBot pushed 1 new commit to master: https://git.io/vDI5k
NatSkin/master ba0cd54 CH yang: Item13856: Translated using Weblate (Chinese (Taiwan))...
[01:48]
***GithubBot has left [01:48]
FoswikiBothttps://foswiki.org/Tasks/Item13856 [ Item13856: Translations for NatSkin ] [01:48]
............................ (idle for 2h18mn)
GithubBot[distro] gac410 pushed 1 new commit to master: https://git.io/vDIjB
distro/master a93ee2f George Clark: Item14301: Strikeone needs the cookie prefix....
[04:06]
***GithubBot has left [04:06]
FoswikiBothttps://foswiki.org/Tasks/Item14301 [ Item14301: Implement ConfigurableCookieNamesAndPaths ] [04:06]
..................................... (idle for 3h1mn)
***ChanServ sets mode: +o cdot
ChanServ sets mode: +o MichaelDaum
[07:07]
..... (idle for 20mn)
GithubBot[distro] MichaelDaum pushed 1 new commit to Item14288: https://git.io/vDLYC
distro/Item14288 21b19fc MichaelDaum: Merge branch 'master' into Item14288
[07:31]
***GithubBot has left [07:31]
FoswikiBothttps://foswiki.org/Tasks/Item14288 [ Item14288: rewrite to support pluggable edit engines ] [07:31]
GithubBot[distro] MichaelDaum pushed 1 new commit to master: https://git.io/vDLYR
distro/master b0abf0b MichaelDaum: Merge remote-tracking branch 'origin/Release02x01'
[07:32]
***GithubBot has left [07:32]
GithubBot[distro] MichaelDaum pushed 1 new commit to Item14288: https://git.io/vDLYE
distro/Item14288 fcbbd69 MichaelDaum: Merge branch 'master' into Item14288
[07:33]
***GithubBot has left [07:33]
........................................................................ (idle for 5h56mn)
ChanServ sets mode: +o gac410 [13:29]
gac410MichaelDaum: I had to open a blocker against 2.1.3 - Item14315 I've got 2 installs failing if I try to view topic revisions if they have attachments. Both RCS and PlainFile [13:34]
FoswikiBothttps://foswiki.org/Tasks/Item14315 [ Item14315: ASSERT in Meta.pm when viewing prior revisions of topics with attachments ] [13:34]
gac410running with FOSWIKI_ASSERTS enabled. [13:34]
MichaelDaumoha [13:38]
gac410I was unable to recreate it on trunk.f.o, but retrying now after a js change that was preventing save
damn. Followed the same steps and it doesn't fail on trunk. Strange.
trunk.foswiki.org that is.
great. Taint::Runtime IS installed on t.f.o, and ASSERTS is enabled. but it's running fine.
[13:39]
***ChanServ sets mode: +o cdot [13:45]
..... (idle for 20mn)
gac410cdot: If you could take a peek at Item14315 ... I've recreated this on two installs. My git checkout (master and r21, and a tarball install of 2.1.3B2. Not 100% sure what the assert is telling me. [14:05]
FoswikiBothttps://foswiki.org/Tasks/Item14315 [ Item14315: ASSERT in Meta.pm when viewing prior revisions of topics with attachments ] [14:05]
gac410trunk.f.o however does not fail. :( [14:05]
cdotClumsy. Looks like it's trying to re-load a previously loaded object with a different rev. Are ASSERTs enabled on t.f.o? [14:08]
***ChanServ sets mode: +o Lynnwood [14:10]
gac410yes I just checked. ASSERTS are enabled and Taint::Runtime is loaded
According to FoswikiServerInformation
I ran into the problem trying to recreate the extensions installer issue - installed and old then a new version of Publish plugin and tried to look at older revs of the extension. ... Boom
[14:13]
cdotOK. Well, normally a meta object is created "per revision". If you want to load a different revision of the topic, you really ought to create a new meta object. In this case, a meta object that was previously loaded with an older (not the latest) revision is being passed for re-loading a different revision. Which that OUGHT to work, there are various risks associated with it - hence the ASSERT.
The risks are: internal inconsistencies in the meta object (bits coming from different revs)
[14:15]
gac410It looks like the attachment table processing is what's reloading the version somehow. If no attachments, it doesn't fail. [14:16]
cdotwell, it's coming from a QUERY, so it's happening during rendering.
it's nothing to do with the underlying store, it's a problem in Meta.pm or, more likely, above
[14:17]
gac410y. I recreated on both PFS and RCS
Strange that t.f.o doesn't fail.
[14:18]
cdotInteresting. I assume it happens because you are viewing an old rev, so the topic object "in hand" is loaded with a rev that is not the latest. Then the QUERY code is demaning the latest for some reason.
ah yes, the params to the %QUERY appear to have an explicit rev in them.
That's not wrong, just surprising.
Recommend you double-check the template. That rev parameter has to be coming from somewhere....
[14:20]
gac410strange. I'll take a look at the templates. Thanks for looking into this.
Well according to the stack trace, it's %QUERY{"length(attachments[NOT lc(attr)=~'h'])"}% ... and that is in the template, but there is no explicit rev there.
attachtables.pattern.tmpl
I wonder if the QUERY macro sets the current rev if a revision is not requested.
[14:24]
cdotwait, sorry, I misread the code. If the rev is not passed, it assumes you are querying the latest [14:29]
gac410yes, elsif ( !$topicObject->latestIsLoaded() ) { [14:29]
cdotthat's the problem, then. The %QUERY in the template doesn't pass the rev being viewed.
Not sure how %QUERY is supposed to know what rev to use otherwise.
Anyway, the code is deffo wrong. It's a use-case that hasn't been thought through enough.
perhaps.
[14:30]
gac410I can add a rev= but need to be careful that we don't introduce any xss. Maybe query should check the rev= query param directly rather than passing it through the templates.
Actually, if the query param rev is "present", then why bother checking if latest is loaded.
[14:32]
That QUERY has been in the code since 2011.
Item12229
[14:38]
FoswikiBothttps://foswiki.org/Tasks/Item12229 [ Item12229: improve transliteration of free-form input to non-unicode chars wiki words ] [14:39]
gac410oops. Item11229 [14:40]
FoswikiBothttps://foswiki.org/Tasks/Item11229 [ Item11229: Update attachment count javascript ] [14:40]
GithubBot[TopicInteractionPlugin] MichaelDaum pushed 1 new commit to Item14223: https://git.io/vDLxD
TopicInteractionPlugin/Item14223 d3e63c5 MichaelDaum: Item14223: working on it...
[14:41]
***GithubBot has left [14:41]
FoswikiBothttps://foswiki.org/Tasks/Item14223 [ Item14223: replace outdated plupload uploader with jquery-file-upload ] [14:41]
..... (idle for 22mn)
***ChanServ sets mode: +o Lynnwood__ [15:03]
gac410There is a bit of extra processing going on. For QUERY requests for config variables: QUERY{"{NameFilter}" ... it still forces a meta load. [15:09]
***ChanServ sets mode: +o Lynnwood [15:13]
ChanServ sets mode: +o Lynnwood__ [15:22]
gac410Thanks again cdot ... I'll have a fix to check in when I get back from PT. [15:32]
.... (idle for 19mn)
cdotgac410: cool. I don't recall why I made QUERY so anal about the latest version. If a rev is in the topic object, it ought to just plough ahead with that rev and not attempt to force-load a different rev. [15:51]
................. (idle for 1h23mn)
***ChanServ sets mode: +o MichaelDaum [17:14]
MichaelDaumI've got huge problems with PFS and updating extensions
what I see is that I update say MoreFormfieldsPlugin from 3.01 to 3.02
[17:15]
gac410Updating from webUI or from CLI? [17:15]
MichaelDaumthe perl code is updated but data/System/MoreformfieldsPlugin.txt is NOT
webui
[17:15]
gac410AH HA. ... Known issue that nobody has figured out Happend on Foswiki 2.0 over a year ago with RCS too. [17:16]
MichaelDauminstead the TXT file stays on 3.01 _AND_ it auto-attaches all css and js and gz files as well [17:16]
gac410Item13785 [17:16]
FoswikiBothttps://foswiki.org/Tasks/Item13785 [ Item13785: ExtensionInstaller fails to replace files under some conditions. ] [17:16]
MichaelDaumI double checked the original ZIP and it has the corrent TXT file in it saying 3.02 and NO pseudo attachments as meta data [17:17]
gac410Most likely fcgi? [17:17]
MichaelDaumy
I removed pfv and txt but still it fails to install the new TXT from the ZIP
[17:17]
gac410It installs it, but somehow the core either reverts it or ignores it. [17:18]
MichaelDaumI've seen you and CDot discussing Meta.pm and the way it checks for loadedness and stuff ... [17:19]
gac410If you enable FOSWIKI_ASSERTS the installer will report exactly what it does file-by-file. Checked in (meta->save()) or copy [17:19]
MichaelDaumcant do that as people are working on the site
this is serious bs
[17:19]
gac410This has been a very sporadic issue, seems to hit one extension once in a while, and we've never figured it out. Lynnwood actually observed the topic update, and then revert back. [17:20]
MichaelDaumit might also be related to the system clock being out of sync [17:20]
gac410Said that the PFS revs were out of order with the newer rev in the system.
I was just trying to duplicate the issue yesterday when I tripped over the ASSERT caused by QUERY macros reloading the topic. But I've never been able to create this locally.
[17:20]
MichaelDaumI could picture a scenario where the system clock is crewed, creates some new files with timestamps in the future or far past ... and then gets tripped off [17:21]
gac410iirc, on foswiki.org, I even ran the install from the shell under the perl debugger, and could not see the issue. [17:21]
MichaelDaumhow do I upgrade from the cmdline? configure -yadda ...? [17:22]
gac410On f.o, way back when, it was the MultiTopicChangePlugin. Lynnwood hit it on PublishPlugin, andnow you with MoreFormfiledsPlugin This is really strange.
tools/extension_installer PluginName install will translat that into the configure command to run the wizard. But right now on CLI, it does NOT do checkins, but always just copies the files.
I just started working on that as well - make the wizard get a session if none exists, so that it can use Func & Meta::save()
On f.o I also ran into an issue that the Cache masked the update, so even when it was working, the cache was stale.
But as you say, it was a "live" site and my debugging options were limited.
[17:22]
MichaelDaumokay that did it: Ive got the correct txt file now [17:25]
gac410Running from CLI right now just does file copy. So your history will be munged [17:26]
MichaelDaumI tripple-checked on the filesystem: (1) it reverted to an old rev (2) it auto-attached js and css and gz etc
I do not want (1) nor (2)
[17:26]
gac410If the topic has a history, then it uses attach to keep the history clean. If topic does not have a history, it *should* just copy [17:27]
MichaelDaumI don't want to have any history of data/System/MoreFormfieldsPlugin.txt [17:27]
gac410If you have !noci in the manifest, and no history exists, it should not add it. [17:27]
MichaelDaum!noci? [17:27]
gac410If !noci is missing, then you will get checkins and history [17:27]
MichaelDaumnoci
!noci!
!!!noci!!!
[17:28]
gac410I see it
It's been a flag around for a very long time to prevent checkins
[17:28]
MichaelDaumboy this is serious bs*
I never understood !noci
up to now
okay
yet still the !yesci is !bugi
[17:28]
gac410No... Store has a contract. You use the APIs to change store on a live system.
Someday, if we ever have a database store, there won't be a choice
[17:29]
MichaelDaumthe situation is different when installing an extension and a new txt file materializes that way
the store simply does the wrong thing: it does NOT check in 3.02, instead it reverts to 3.01
[17:30]
gac410That seems to be a store bug then. AFAIK package does do the correct meta->save() call. [17:31]
MichaelDaumanyway. my time&steam is out for today. gotta dig deeper another time. see you. [17:31]
gac410see you :(
cdot, if you would in your spare time ponder https://github.com/foswiki/distro/blob/master/core/lib/Foswiki/Configure/Package.pm#L968
Thats where the topic is updated and saved. Is there *anything* possibly wrong with that code.
[17:31]
cdotNothing obvious. Maybe if the META in the $contents is SNAFU. [17:37]
gac410So no benefit to doing the load of any existing topic first, and then applying the new content [17:39]
.... (idle for 15mn)
GithubBot[distro] gac410 pushed 1 new commit to master: https://git.io/vDtVa
distro/master 54c394f George Clark: Item14315: Don't load latest rev in attachments table...
[17:54]
***GithubBot has left [17:54]
FoswikiBothttps://foswiki.org/Tasks/Item14315 [ Item14315: ASSERT in Meta.pm when viewing prior revisions of topics with attachments ] [17:54]
gac410CDot - that fixes 14315 I hope ... if you want to do a quick review. Thanks. [17:54]
cdotall makes sense [17:55]
gac410thanks [17:55]
..... (idle for 24mn)
GithubBot[distro] gac410 pushed 1 new commit to Release02x01: https://git.io/vDtK2
distro/Release02x01 e85d637 George Clark: Item14315: Don't load latest rev in attachments table...
[18:19]
***GithubBot has left [18:19]
GithubBot[distro] gac410 pushed 1 new commit to master: https://git.io/vDt6q
distro/master 4a2be88 George Clark: Merge branch 'Release02x01'
[18:23]
***GithubBot has left [18:23]
......... (idle for 41mn)
ChanServ sets mode: +o Lynnwood [19:04]
......................................... (idle for 3h23mn)
GithubBot[distro] FoswikiBot pushed 1 new commit to master: https://git.io/vDqcE
distro/master c67d012 CH yang: Item13884: Translations updated using Weblate (Chinese (Taiwan))...
[22:27]
***GithubBot has left [22:27]
FoswikiBothttps://foswiki.org/Tasks/Item13884 [ Item13884: Translation changes for master and Foswiki 2.1 ] [22:27]
GithubBot[distro] FoswikiBot pushed 1 new commit to Release02x00: https://git.io/vDqc2
distro/Release02x00 ab79a26 CH yang: Item13505: Translated using Weblate (Chinese (Taiwan))...
[22:27]
***GithubBot has left [22:27]
FoswikiBothttps://foswiki.org/Tasks/Item13505 [ Item13505: Translations for Foswiki 2.0.x ] [22:27]
GithubBot[ListyPlugin] FoswikiBot pushed 2 new commits to master: https://git.io/vDqcw
ListyPlugin/master 96b6819 CH yang: Item13990: Translated using Weblate (Chinese (Taiwan))...
ListyPlugin/master 3edadbc CH yang: Item13990: Translated using Weblate (Chinese (Taiwan))...
[22:27]
***GithubBot has left [22:27]
FoswikiBothttps://foswiki.org/Tasks/Item13990 [ Item13990: translations for ListyPlugin ] [22:27]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)