#foswiki 2017-04-10,Mon

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
***ChanServ sets mode: +o cdot [06:07]
GithubBot[distro] MichaelDaum pushed 1 new commit to Item14288: https://git.io/vSKou
distro/Item14288 c5b9a29 MichaelDaum: Item14288: make full screen button configurable
[06:09]
***GithubBot has left [06:09]
FoswikiBothttps://foswiki.org/Tasks/Item14288 [ Item14288: rewrite to support pluggable edit engines ] [06:09]
GithubBot[distro] MichaelDaum pushed 1 new commit to Item14288: https://git.io/vSKoK
distro/Item14288 71872b2 MichaelDaum: Merge branch 'master' into Item14288
[06:12]
***GithubBot has left [06:12]
............. (idle for 1h0mn)
ChanServ sets mode: +o cdot [07:12]
.............. (idle for 1h8mn)
cdot has left [08:20]
................................ (idle for 2h35mn)
ChanServ sets mode: +o cdot [10:55]
..... (idle for 22mn)
ChanServ sets mode: +o MichaelDaum
ChanServ sets mode: +o cdot
[11:17]
......... (idle for 41mn)
cdotwikibot: seen gac410
foswikibot: seen gac410
[11:59]
FoswikiBotcdot: gac410 was last seen in #foswiki 22 hours 41 mins ago joining the channel. [11:59]
***ChanServ sets mode: +o gac410 [12:13]
cdotgac410: https://foswiki.org/Tasks/Item14375 comments welcome [12:20]
gac410cdot: looks reasonable to me. [12:22]
cdotwhat does? The current implementation, or the proposed fix? [12:22]
gac410proposed fix [12:22]
cdotMichaelDaum: ? Any opinion ? [12:23]
gac410This only impacts META: and not macro { } syntax, right? [12:24]
jastmakes sense to me, too, FWIW [12:26]
cdotright [12:26]
MichaelDaumjust a bad regex ... depends on how much worse you are going to make it ;) [12:26]
cdotMichaelDaum: I was just going to use \S. Since the core is unicode now, that should be OK. [12:27]
MichaelDaumyou mean [^\s"] ? [12:29]
gac410MichaelDaum, Re Item14372: Why are all the other UI components in the JQ Config.spec listed. Except for Draggable? ,,, grep UI: lib/Foswiki/Plugins/JQueryPlugin/Config.spec [12:29]
FoswikiBothttps://foswiki.org/Tasks/Item14372 [ Item14372: ui-draggable got dropped from JQueryPlugin Config.spec ] [12:29]
MichaelDaumwhat does Foswiki::Attr look like? [12:29]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Attr [12:29]
cdotFoswiki::Attrs uses [#a-z0-9_]+ [12:30]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Attrs [12:30]
MichaelDaumgac410, not sure. Let's fix it.
cdot, maybe we should try to bring both parsers F:A and F:S:E in line ... a bit
stuff like %META:FOO{$="bar"}% is a bit off imho
[12:31]
cdotmaybe. The Attrs parser is a lot more functional than the META parser, which just needs to be fast.
for example, Attrs has "plain text"
and other "features".
[12:33]
gac410For F:A I added # as a valid charcter to support SCRIPTURL{ #=" " } for anchors [12:33]
MichaelDaum+1 on faster. de-serializing meta is _the_ no.1 performance killer atm.... as the meta cache that we have isnt being used most of the time [12:33]
cdoty. The app I found this problem with is the SQL cache (DBIStoreContrib). You can't have '#' in a column name in SQL :-(
so I think tightening even further to exclude the # is good business.
[12:34]
MichaelDaumah ok
y
still botching DBIQueryPlugin?
[12:34]
gac410cdot... Remove # ... From the Foswiki::Attr and macros. That breaks all the Canonical URL changes [12:35]
cdotno, leaving that to vrurg. I just needed it to work :-) [12:35]
MichaelDaumcdot, wrt your question "why did MD create SqlPlugin" [12:35]
cdotgac410: no, just disallow # in META [12:35]
gac410oh... okay phew... [12:35]
MichaelDaumat that time the only alternative was DatabasePlugin .... and as I opened it up I decided it is unfixable
SqlPlugin does one thing simple and easy: select
and then format the hell out of it
[12:36]
cdoty, I looked at the code. The app I helping with required DO, so that's why they used DBIQueryPlugin [12:37]
MichaelDaumthus anything which has got a dbd can be accessed [12:37]
cdotthey started with just SqlPlugin [12:37]
MichaelDaumokay. fair enuf. SP just wants to be read only. [12:37]
cdotDBIQueryPlugin is a bit of a performance hog too, makes a lot of use of commonTagsHandler [12:37]
MichaelDaumand non-standard syntax thus making it a problem writing wiki apps with nested macros
... which I detest with passion
[12:38]
cdoty. But I have no interest in rewriting it (or getting involved with SQL queries in any way, if I can avoid it ;-) )
I just need to use it, in one very limited app.
OK, changing the META parser to: $args =~ s/\s*([a-z][a-z0-9_]*)="([^"]*)"/.../gi
[12:38]
MichaelDaumthat might be too latin1 centric
and break people using MetaDataPlugin with unicode attribute names
in MetaDataPlugin DataForm field names become meta data key names...
[12:40]
cdot%META:汉语/漢語{中文="OMG"}% [12:43]
gac410Y. We support unicode fieldnames now ... I think. [12:43]
cdotif it were user facing I might worry about it. But this is hidden, system level stuff. [12:43]
MichaelDaumcdot, lets keep any [a-z][A-Z] type of regexes out of the code, please [12:44]
cdotI also don't want to start flinging unicode at SQL (self interest trumps all other concerns) [12:44]
MichaelDaumthen transliterate. try Text::Unidecode [12:44]
cdotall right, we can compromise on \w+ then [12:44]
MichaelDaumor something else [12:44]
cdottransliteration is fine, except for the edge cases.
like, when two codepoints have the same transliteration
[12:45]
MichaelDaum... which is the case by definition: transliterate(source) = target as well as transliterate(target) = target
as long as this is only within one table definition ....
MichaelDaum pfts
[12:46]
cdotgac410: System.Macros says "Parameter names may be upper or lower case, and may consist of the ascii alphas, numbers, and the symbol #, Other characters and Unicode extended alpha characters are not valid" [12:50]
gac410right. I'm mis-remembering someting now.
I did add the #. but that's all.
[12:50]
cdotAnd I documented what I reverse-engineered from the code, IIRC.
So you may want to add an Enhancement to support unicode in macro and parameter names. Or you might not ;-)
[12:52]
gac410Ah. It was template names. And data form names. In the release notes for 2.1.
DataForms also support Unicode field names. Before 2.1, any non-ascii was simply omitted from the acutal field name
As dataform fieldnames are stored in the META: then meta needs to support them.
[12:53]
..... (idle for 24mn)
cdot: The regex in Foswiki::Form::fieldTitle2FieldName() is now $text =~ s/[^\w\.]//g; unless LegacyFormfieldNames is enabled. I guess then that's what META needs to allow ?? [13:20]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Form [13:20]
cdotno, I think \w is fine. No need for .
keep it simple
META is not intended to be human-editable
[13:20]
gac410Then Form needs a fix as well, or a dataform can cause . to be added into the meta [13:21]
cdotno. It can add a . to a parameter value, it can't affect the %META: statement [13:22]
gac410Which then adds another backwards compat issue.
That's the field NAME regex, not value
[13:22]
cdote.g. %META:FORMFIELD{name="ICanHasA.Here"}% [13:22]
gac410Oh... okay
right, gotcha. It used to be s/[^A-Za-z0-9_\.]//g;
never mind... ;) I'll crawl back to my browsing
[13:23]
GithubBot[distro] cdot pushed 1 new commit to master: https://git.io/vS6cY
distro/master 12511db cdot: Item14375: limit meta parameter names to perl word characters, fix the doc
[13:28]
***GithubBot has left [13:28]
FoswikiBothttps://foswiki.org/Tasks/Item14375 [ Item14375: Embedded META reader allows spaces in parameter names ] [13:28]
cdotgac410: BTW I noticed when I did a merge out from master that copyright notices in some of the scripts got reverted back from 2017 to 2010
it worried me, because I was concerned something had gone wrong. compareauth, I think it was
[13:29]
gac410oh crap. I picked one bin script to copy to all the rest - as they are supposed to be identical.
(except for view, which needs an explicit action because of ancient advice to rename it to xview )
btw, If you want fixes to go into a 2.1.4 (assuming we build one)... please commit to Release02x01 first, and then merge into master. Otherwise it leaves me comparing commits and manually cherry picking.
Features -> master Bugfix -> Release02x01 -> master
Actually it looks like some of the copyrights went from 2010 -> 2017 but compareauth fell back from 2014 -> 2010.
And the rest stayed wherever they were :(
[13:29]
cdotgac410: MichaelDaum wrote"in MetaDataPlugin DataForm field names become meta data key names..." - which makes your previous comment more relevant. I still favour \w, though.
re: 2.1.4, ok, thanks for that heads-up
[13:36]
gac410Regardless this needs careful release notes, and instructions on how to fix up any lurking issues. Which in that case, probably is best to leave this a 2.2 (master) only fix. [13:37]
cdotok, fair point. I understand the issue now, which was my primary concern. [13:39]
......... (idle for 40mn)
***ChanServ sets mode: +o cdot [14:19]
................ (idle for 1h16mn)
foswiki_irc2I tried to add the NatSkin extension, but when I added it where I thought it should go it broke my web and I can't access the edit button again to change it back. Any ideas? [15:35]
.............. (idle for 1h6mn)
gac410foswiki_irc2: You can always use ?skin=pattern to override the skin back to the default when viewing the topic. That should bring back the buttons. [16:41]
***ChanServ sets mode: +o cdot [16:45]
.......... (idle for 47mn)
foswiki_irc2Thanks, that did the trick. I was in the preferences for the web, in the area where you can change the logo. Where do you put the code to use a different skin since that doesn't appear to be the right spot? [17:32]
......... (idle for 41mn)
gac410foswiki_irc2: Typically it's done site-wide in Main.SitePreferences, and is a Set SKIN = nat
nat-skin replaces pattern skin and natedit. Just need nat. But there are a lot of dependencies you need installed to get it all working. I don't use it, so I won't be much help :(
You can test the same way. view the page with ?skin=nat Or set it in your User topic, so only you get the alternate skin until it's all working.
[18:13]
...... (idle for 26mn)
foswiki_irc2Hmm, that's where I put it I thought, sounds like it was just in the preferences of one of the other webs though. Weird, the installation only mentions grabbing the extension and putting that line of code in place [18:41]
Never mind, I'm dumb. Need to realize dependencies = requirements [18:53]
Where do I go to add dependencies again? I remember running some sort of GUI before [19:01]
........ (idle for 39mn)
***GuilainC has quit IRC (Ping timeout: 240 seconds) [19:40]
gac410foswiki_irc2: bin/configure, in the Extensions tab, there is a sub-tab for searching for extensions. [19:46]
***stefan_slight has quit IRC (Quit: stefan_slight) [19:59]
................. (idle for 1h24mn)
vrurg has quit IRC (Ping timeout: 256 seconds) [21:23]
........ (idle for 38mn)
DeanSpicer has quit IRC (Read error: Connection reset by peer) [22:01]
........................ (idle for 1h56mn)
GithubBot[distro] gac410 pushed 1 new commit to master: https://git.io/vSPfF
distro/master f5cd4db George Clark: Item14070: add a more visible action required note
[23:57]
***GithubBot has left [23:57]
FoswikiBothttps://foswiki.org/Tasks/Item14070 [ Item14070: Improve "Create a link to the attached file" formatting options and defaults. ] [23:57]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)