#foswiki 2017-05-10,Wed

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
GithubBot[distro] gac410 pushed 3 new commits to master: https://git.io/v9PHh
distro/master 94f3f47 George Clark: Item13883: Clarify when the upgrade procedure is required.
distro/master 1772f30 George Clark: Item13883: Add some docs on checking the installation
distro/master 8e26f84 George Clark: Item14392: Comment out empty DENY rules...
[02:01]
***GithubBot has left [02:01]
FoswikiBothttps://foswiki.org/Tasks/Item13883 [ Item13883: Documentation changes for master and 2.1 ]
https://foswiki.org/Tasks/Item14392 [ Item14392: Sandbox WebPreferences topic contains an empty DENY rule which is ignored. ]
[02:01]
..................................... (idle for 3h2mn)
***GuilainC_away is now known as GuilainC [05:03]
............. (idle for 1h0mn)
ChanServ sets mode: +o MichaelDaum [06:03]
........... (idle for 54mn)
GuilainC is now known as GuilainC_away [06:57]
................................................... (idle for 4h14mn)
ChanServ sets mode: +o cdot [11:11]
................. (idle for 1h20mn)
ChanServ sets mode: +o Lynnwood [12:31]
...... (idle for 29mn)
ChanServ sets mode: +o gac410 [13:00]
....... (idle for 32mn)
gac410cdot ... the commit in error was the one I replied to. It was right in the message.
https://github.com/foswiki/distro/commit/b7d337100c088b83cf22da0c39665ac51640e51d#commitcomment-22080857 .... just scroll up to the top.
I noticed it first when the nightly test run for trunk started failing
[13:32]
....... (idle for 34mn)
cdotgac410: if that's the case, there is some seriously FU logic in that code :-( [14:08]
gac410I ran git bisect - it was pretty specific. Reverting that one change fixes bootstrap. [14:09]
cdotdoesn't matter how hard I stare at it, my change makes sense. Therefore something somewhere else doesn't :-( [14:09]
gac410remove you localsite.cfg and issue tools/configure -save It should bootstrap.
with your fix, it just says nothing to change.
[14:09]
cdotah, i see. Yes, that is a very delicate assumption. Nasty.
my change is correct; it was just lucky that !DEBUG must always have been true when bootstrapping
[14:10]
.... (idle for 15mn)
GithubBot[distro] cdot pushed 2 new commits to master: https://git.io/v9Xh3
distro/master e4ce81c cdot: Item14394: untangle messed-up logic
distro/master d80d49d cdot: Merge branch 'master' of https://github.com/foswiki/distro
[14:26]
***GithubBot has left [14:26]
FoswikiBothttps://foswiki.org/Tasks/Item14394 [ Item14394: Unparseable Config.spec causes a hard fail when DEBUG is on. ] [14:26]
***vrurg has quit IRC (Quit: vrurg) [14:27]
...... (idle for 26mn)
cdotgac410: I was just taking a stab at fixing the doc for form field "title" versus form field "name". I notice that 2.0 now uses $text =~ s/[^\w\.]//g;
to create the "name" from the "title". I feel an opportunity was missed here; the field *name* is derived from the *title* primarily to create a wikiword - a.k.a a topic name. So, rather than [\w.] the condition should have been the same as that used to constrain wikinames - viz. $Foswiki::cfg{NameFilter}
[14:53]
gac410cdot, btw, if you do a "git pull --rebase && git push" to push after commits, it avoids all the extra "Merge branch 'master' " commits. Only time that is not a good idea is after an explicit merge. ie. git merge Release02x01
There is a git setting to make it automatic. Don't recall now.
[14:54]
cdotok, I'll try to remember. Usually I'm in a hurry when I commit. [14:54]
gac410git config --global pull.rebase true makes it all automagic [14:57]
cdotBTW it was me that missed the opportunity, not you :-) [14:57]
gac410Oh... okay. ;)
or if your git version is older than 1.7.9, then do this to enable autorebase whenver you create a new branch: git config --global branch.autosetuprebase always
cdot we need to be really careful though - that we don't break forms already established under the old rules. :(
[14:57]
cdotI know. That's why I'm not raising it as a task. [15:01]
gac410btw if the intent was to create a wikiword from the title, then maybe the existing routine that will wikiword any arbitrary string would have been better.
I think there was even a proposal to add that to Func::
Foswiki:Development/AddFoswikiFuncWikifyWebTopicName
[15:10]
FoswikiBothttps://foswiki.org/Development/AddFoswikiFuncWikifyWebTopicName [ AddFoswikiFuncWikifyWebTopicName ] [15:13]
gac410anyway... leaving now. [15:13]
.............................. (idle for 2h27mn)
***GuilainC_away is now known as GuilainC [17:40]
...... (idle for 27mn)
GithubBot[distro] cdot pushed 1 new commit to master: https://git.io/v915C
distro/master 32a766a cdot: Item8728: doc improvements to DataForms, covering difference between title and name and reorganising some of the hacks added over time
[18:07]
***GithubBot has left [18:07]
FoswikiBothttps://foswiki.org/Tasks/Item8728 [ Item8728: edit form documentation enhancement ] [18:07]
gac410cdot ... have you run into people asking for sorting of the Group member lists? Someone asked me today about it. iirc there are performance concerns. [18:07]
............ (idle for 59mn)
***GuilainC has quit IRC (Ping timeout: 240 seconds) [19:06]
................... (idle for 1h33mn)
gac410cdot, Reading https://tools.ietf.org/html/rfc3875#section-6.2.2 the questioner is right. Location: header with a /local/path is *supposed* to be internally reprocessed by the server and NOT returned to the client.
It's a "Local redirect" as opposed to a Location containinng http... which is a "Client" side redirect.
No idea why nobody else has run into this. but the real fix is to probably force an absolute location in the Foswiki::Response->redirect() method.
[20:39]
FoswikiBothttps://trunk.foswiki.org/System/PerlDoc?module=Foswiki::Response [20:40]
gac410In all cases I can think of, we'd expect the 302 - Redirect to be handled by the client and not internally by the web server.
(Local redirect is the equivalent of the rewrite rule issued without the http absolute header, and is a server-side redirect, the client never knows about it.)
[20:41]
............................ (idle for 2h17mn)
***cdot has left [22:59]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)