#foswiki 2017-09-20,Wed

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
GithubBot[distro] gac410 pushed 1 new commit to Release02x01: https://git.io/v5pJQ
distro/Release02x01 8ea837c George Clark: Item14492: Use configured BCryptCost
[00:36]
***GithubBot has left [00:36]
FoswikiBothttps://foswiki.org/Tasks/Item14492 [ Item14492: HtPasswdUser implements bcrypt with a hard coded cost. {Htpasswd}{BCryptCost} is ignored. ] [00:36]
GithubBot[distro] gac410 pushed 2 new commits to master: https://git.io/v5pJN
distro/master 8d87480 MichaelDaum: Item14448: left behind changes on local disc
distro/master 5778516 George Clark: Item14492: Use configured BCryptCost
[00:36]
***GithubBot has left [00:36]
FoswikiBothttps://foswiki.org/Tasks/Item14448 [ Item14448: plugin list empty on page reload ] [00:36]
.... (idle for 15mn)
***ChanServ sets mode: +o Lynnwood [00:51]
................ (idle for 1h16mn)
GithubBot[distro] vrurg pushed 2 new commits to Item14237: https://git.io/v5pLK
distro/Item14237 1f0845b Vadim Belman: Item14237: Changed extensions initialization order...
distro/Item14237 41f2412 Vadim Belman: Item14237: More docs on extension manager...
[02:07]
***GithubBot has left [02:07]
FoswikiBothttps://foswiki.org/Tasks/Item14237 [ Item14237: Implement Development.OOConfigSpecsFormat proposal ] [02:07]
....................... (idle for 1h54mn)
***ChanServ sets mode: +o Lynnwood [04:01]
.................................... (idle for 2h55mn)
GithubBot[distro] MichaelDaum pushed 1 new commit to Release02x01: https://git.io/v5pC5
distro/Release02x01 3d8eb80 MichaelDaum: Item14448: don't use numbered args in MAKETEXT yet
[06:56]
***GithubBot has left [06:56]
FoswikiBothttps://foswiki.org/Tasks/Item14448 [ Item14448: plugin list empty on page reload ] [06:56]
GithubBot[distro] MichaelDaum pushed 1 new commit to master: https://git.io/v5pWf
distro/master 3a3dbdf MichaelDaum: Item14448: don't use numbered args in MAKETEXT yet
[06:58]
***GithubBot has left [06:58]
GithubBot[distro] MichaelDaum pushed 1 new commit to Item14288: https://git.io/v5pWT
distro/Item14288 b635eb4 MichaelDaum: Item14288: Merge origin/master
[06:59]
***GithubBot has left [06:59]
FoswikiBothttps://foswiki.org/Tasks/Item14288 [ Item14288: rewrite to support pluggable edit engines ] [06:59]
.......................................................................... (idle for 6h6mn)
***ChanServ sets mode: +o gac410 [13:05]
ChanServ sets mode: +o Lynnwood
gac410 sets mode: +v FoswikiBot
[13:13]
...... (idle for 26mn)
zak256Hi! I just tried creating a new template page for defining our customized icons. I followed System/DocumentGraphics#Create_a_Skin_Template_for_your_icons but it seems the template is not read. [13:40]
***ChanServ sets mode: +o cdot [13:41]
zak256It says "create a topic called IconsMybookSkinTemplate in the System web". I created System/IconsExtraSkinTemplate
Then in my testpage I wrote "Set SKIN = extra, pattern"
But I think I am missing something?
When I add my template code into templates/icons.tmpl it works, but I would prefer to include the code in a new topic instead.
[13:41]
gac410The search path template for topic skins is: $web.$skinSkin$nameTemplate [13:45]
zak256Yes, I read that. So $skin is "extra" in my case? and what is $name ? [13:45]
gac410So its ExtraSkin<templatename>Template [13:45]
zak256Can I use anything I want as templatename? [13:46]
gac410ExtraSkinIconsTemplate maybe? [13:46]
zak256Well... the doc says as example "IconsMybookSkinTemplate" ... but I will try... [13:47]
gac410hm Maybe the docs are wrong. I've never tried to override the icons template from a topic template. [13:47]
zak256Ahh... so the template name must be something that already exists in TemplateDir?
like icons.tmpl
[13:49]
gac410Sort of. It's whatever name the extension uses when it tries to read or include the template. For ex, on the search path, it's finding the template via "/var/www/foswiki/distro/core/templates/$name.tmpl"
(or whatever path you are using for templates directory)
[13:51]
zak256yes, the path is clear to me. [13:52]
gac410It's listed out in https://foswiki.org/System/SkinTemplates#Finding_Skin_Templates [13:52]
zak256It's $name that confuses me. [13:52]
gac410Plugin says "read template icons" so icons is the name. Then the path is searched for all the possible places Icons template can be found. [13:53]
zak256Ok... ExtraSkinIconsTemplate works. [13:57]
gac410Great. So documentation bug in Foswiki:System/DocumentGraphics#Create_a_Skin_Template_for_your_icons [13:58]
FoswikiBothttps://foswiki.org/System/DocumentGraphics#Create_a_Skin_Template_for_your_icons [ DocumentGraphics ] [13:58]
gac410Hm Actually the docs are right. Says to create MybookSkinIconsTemplate [13:59]
zak256Argh... I should look at foswiki.org docs and not our outdated docs :( [14:00]
gac410Ah... so it *was* a bug at one point. [14:00]
zak256Yes...
But I am still trying to figure out the "Icons"=$name thing here...
Does $name have to be something specific here? Or could I write MybookSkinFoobarTemplate as well?
[14:00]
gac410No, it has to be "icons" (capitalized in the topic format)
the macro executes: $this->{_ICONSTEMPLATE} = $this->templates->readTemplate('icons');
[14:03]
zak256Which macro? [14:04]
gac410The template name "icons" is fundamental to the implementation. All the other combinations are expanded from that search path. %ICONS
er. %ICON ... Implemented in lib/Foswiki/Macros/ICON.pm
[14:04]
zak256Ah, okay. So this skin template can only be used for %TMPL:DEF{"icon:..."}% definitions. [14:06]
gac410Yes [14:06]
zak256One last question: Can I write wiki syntax in this SkinTemplate topic? [14:07]
gac410yes, but with limitations. Templates are expanded before the rendering to HTML runs. So you can put Wiki syntax inside of a %TMPL:DEF but you cannot put it outside a template. [14:08]
zak256Yeah... I meant for writing some explanation to the people who might edit this template, or to write a verbatim section around the template definitions. [14:09]
gac410Oh. That can be put inside template comments. ... I think there are some examples. Let me look.
Look at System.FAQViewTemplate
Ah crap no. that's not a good example.
Someone added a view template setting that was not needed.
gac410 looking for another
[14:10]
FAQViewTemplate is the best example I can find. Look at it in raw mode. The META setting for VIEW_TEMPLATE should be removed, since this topic uses %{ template comments to properly render when viewed. [14:18]
zak256Ah, I think I understand... let me try... [14:20]
gac410You must not have any content outside of %{ template comments }% or that will really break things. [14:22]
zak256Can you give me an example what to write if I just want to insert <verbatim> before and </verbatim> after my template definitions?
Without breaking the template of course.
Something linke %TMPL:INCLUDE{"view"}%%{<verbatim>}%
?
[14:25]
gac410You can start right off with %{<verbatim class="tml">}% ... then all your defs ... then %{</verbatimm>}%
but spelled with one m. My keyboard stutters sometimes.
Your template for icons should not include view
[14:27]
zak256Yes, I tried that...
When viewing the template topic I get:
%{
Then in verbatim:
}%
...then the definitions...
and afterwards:
%{
then non-verbatim:
}%
[14:28]
gac410Yes it's a bit ugly. [14:30]
zak256Ah, I cannot get rid of the %{...}% in the topic then. Ok. [14:30]
gac410Right.
hm This ICON.pm / icons.tmpl tie-in is awful... very bad violation of boundaries. Core "icon.pm" tries to load icons.tmpl which is part of FamFamFamContrib. icons.tmpl really ought to be part of core. Not a contrib.
[14:31]
................... (idle for 1h31mn)
***ChanServ sets mode: +o MichaelDaum [16:06]
zak256Hmm... I just found a place where an Icon is not referenced by %ICON{...}% but by %ICONURLPATH{...}% ...
This does not work with my ExtraSkinIconsTemplate :(
How do those two work together? Can I support ICONURLPATH for my customized icons as well?
[16:07]
I added %TMPL:DEF{"iconurlpath:myicon"}%%PUBURLPATH%/%SYSTEMWEB%/ExtraSkinIconsTemplate/myicon.png%TMPL:END% but id doesn't help [16:15]
gac410That macro uses the setting of ICONTOPIC to find it's icons.
Which by default points to System.DocumentGraphics
[16:18]
zak256Okay. Can I do something about it? [16:20]
gac410TBH you are deep into territory that I have no idea about. I'm just looking at code for what you mention. I suppose you could try setting ICONTOPIC in your SitePreferences to something other than System.DocumentGraphics. But I have no idea what havoc that might cause. [16:21]
zak256hmm... havoc is something I really want to avoid. :-/ [16:22]
gac410Copy System.DocumentGraphics to Main.MyDocumentGraphics. Modify any attachments you want to change, and then set ICONTOPIC = Main.MyDocumentGraphics
I suppose you could even test this in a single web or topic.
Rather than changing it in SitePreferences
[16:23]
zak256But then I could as well stick to the current solution and just add our icons to DocumentGraphics. [16:24]
gac410I expect the reason ICONURLPATH is used, is because the template rendereing of ICON would generate conflicting html. [16:24]
zak256Yes, it's used in a %TWISTY{... showimgleft="%ICONURLPATH{...}%"... [16:25]
gac410ahh.... There is another template defn iconurl:book which would correspond to icon:book Maybe you could try creating an iconurl:image override. [16:29]
zak256You mean the part in icons.tmpl at the beginning?
I think this is just used within the template?
I changed iconurl to iconurlpath, but that didn't work.
[16:30]
gac410Y, reading the code in ICON getIconUrl, it is absolute doesn't use a template.
This needs a design proposal, and some further rework. The template generation of ICON doesn't support ICONURL and ICONURLPATH as far as I can tell.
[16:31]
zak256Maybe I could just patch the function somewhere to make 'iconurlpath' work besides just 'icon'? [16:32]
gac410It's probably more complex than that. Really beyond where I've explored [16:33]
zak256My other thought right now is to add these two graphics into our style and reference them completely different. But then it would still not be possible to use other iconpaths later in similar situations. [16:33]
gac410And MichaelDaum was just the person I was going to hook. :( [16:33]
zak256But at least it would work for now.
Hmm
Maybe he suspected... ;)
[16:33]
gac410I think that this needs a task, and probably a proposal ... to explore how generation of ICON, ICONURL and ICONURLPATH integrate together. Really it should be universally extended. Not the current hodgepodge [16:35]
zak256Should I open one? But I don't really know if it is worth the effort... [16:36]
gac410Well it is certainly an inconsistency. So a legitimate issue. But we really need developers to be willing to work on this stuff.
Lots of users ... but we've gotten rather thin on the "fixers" ;)
[16:37]
zak256I just wrote "%PUBURLPATH%/%SYSTEMWEB%/ExtraSkinIconsTemplate/myicon.gif" instead of "%ICONURLPATH{myicon}%" and it works... so I think other issues should have more priority.
Yeah, I know the problem. :(
[16:38]
gac410y.
heya cdot. Before you drift away. I made a proposal in Foswiki:Development.TinyMCEPlugin To delete tinymce_dev and replace it with a git submodule pointing to the tinymce development repo.
[16:39]
FoswikiBothttps://foswiki.org/Development.TinyMCEPlugin [ TinyMCEPlugin ] [16:39]
zak256If there will ever be something I can contribute I will do so of course. But the current migration has to go first. [16:39]
gac410understood. Must keep the hands with the $$$ happy :D [16:39]
zak256Exactly... [16:39]
gac410hm It is possible to replace system macros. So in theory you could redefine ICONURLPATH with a %PUBURLPATH% replacement
But you'd have to make sure your location has all the icons that would be refrenced with PUBURLPATH
[16:40]
zak256But then I would break all the DocumenGraphics-icons. [16:41]
gac410y. true. [16:41]
zak256The idea in the first place is to seperate Foswiki graphics with userdefined graphics. [16:41]
gac410exactly.
So the right solution is probably an extension to ICON code, allowing it to generate a url or a relative urlpath. Or change ICON code to make sure ICONURL / ICONURLPATH all can expand a template version if it exists.
[16:42]
zak256yes. I will put it on my list, maybe if there is some time after all the other things are done [16:45]
gac410I'm going to open a Task. Nothing yet reporting that ICONURL / ICONURLPATH have issues. [16:57]
zak256Ok, good. I will bookmark it then. [16:57]
gac410Item14493 [17:08]
FoswikiBothttps://foswiki.org/Tasks/Item14493 [ Item14493: ICONURL and ICONURLPATH do not work with skin based ICONs. ] [17:08]
zak256Ok, saved. Great!
Now let those developers come ;)
[17:09]
gac410mirror mirror on the wall ... show me a developer :D [17:10]
zak256When I ever will be a billionaire, I will do so much for opensource...
Tomorrow I need to separate our custom smileys.
[17:10]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)