#foswiki-release 2018-03-19,Mon

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)

WhoWhatWhen
gac410Hi everyone Good morning / day ... Ready for a release meeting? [12:00]
....... (idle for 30mn)
MichaelDaumHi George. Bit early, isnt it. We still did not switch over to daylight saving times over here ;) [12:30]
gac4101300Z That never changes. Everyone else switches around it.
So it's an hour earlier for me too :( (Which I really hate)
[12:30]
MichaelDaumatm it is 12:31 utc [12:31]
gac410crap. I calculated it backwards. And I should know better. I'm a pilot and have to do all flight planning etc. on UTC [12:33]
MichaelDaumthere goes your license :D [12:35]
gac410And to think I could have gotten another hour of sleep. ;) [12:36]
...... (idle for 26mn)
Hi everyone ... let's try this again now that I'm in the right timezone. Good Morning / good day. Time for a release meeting? [13:02]
MichaelDaumMichaelDaum on a phone call ... give me a sec [13:04]
Hi gac410
sorry for the delay
[13:11]
gac410Hi MichaelDaum No problem. [13:12]
MichaelDaumhad a discussion about TinyMCE/WysiwygPlugin and ExplicitNumberingPlugin [13:12]
vrurgHi all [13:12]
gac410I saw some of that in a task IIRC
Hi vrurg
[13:12]
MichaelDaumIve added my analysis to this bug report: https://foswiki.org/Tasks/Item11751
which is ... yikes ... 6 years old
[13:13]
gac410y, time flies [13:13]
MichaelDaumI'll investigate a new plugin to cover this feature, called ImplicitNumberingPlugin. [13:14]
gac410hm Another new one vs, just fixing the old?? [13:14]
MichaelDaumit leaves heading notation untouched and just changes rendering of headings as they occur. [13:14]
gac410Ah... [13:14]
MichaelDaumExplicitNumberingPlugin is just fine in its own... however bugs are in the core as well as in WysiwygPlugin
the latter is broken by design and wont cut it as it is now
for more details see Item11751
[13:15]
gac410y, and when bugs cross over between core, default extensions and others, it make it challenging. [13:16]
MichaelDaumthere are two approaches we could take wrt core and core plugins: (1) remove the broken and incomplete support for explicit numberiung (2) embrace ExplicitNumberingPlugin and extend TML
thats why I bring it up here
[13:17]
gac410Numbering headers is a very nice feature. So trying to clean up and extend what we've got makes good sese.
sense
[13:18]
MichaelDaumwe can compare two sets of efforts to implement and fix numbering headers
(1) implement an ImplicitNumberingPlugin that has got a makro to influence how headings are rendered
(2) fix core and WysiwygPlugin thus making ExplicitNumberingPlugin's heading notation a first class TML citizen
[13:19]
gac410I somewhat lean towards #2, as it (hopefully) preserves what people have been doing with the old plugin. [13:21]
MichaelDaummy guts say #1 is less effort [13:21]
gac410Would #1 allow existing deployments of the ENP survive, or would people have to go back and edit existing topics? [13:23]
MichaelDaumENP can still be used as buggy as WysiwygPlugin is atm
means HTML2TML & TML2HTML destroy heading notations on the roundtrip
if you dont wysiwyg ENP is a fine solution today
[13:23]
gac410hm I wonder if there is some easy way to have Wysiwyg detect ENP syntax, and just refused to Wisywigy
IIRC there is a setting to cause certain html tags / attributes to block wysiwyg.
I wonder if a beforeEditHandler could do something.
[13:24]
MichaelDaumyea, well [13:26]
gac410ENP has some nice features. Separate numbered sequences, divided sequences, etc. [13:26]
MichaelDaumI know. I regularly install it for all of my clients.
but they want wysiwyg with it
[13:27]
gac410would your Option (1) would lose some of the ENP features? [13:28]
MichaelDaumnot sure. I didnt investigate yet.
the idea is to have some macro, say %HEADINGFORMAT{start="..." type="alpha/numeric/..." digits="1/2/3/..."}% and have it alter headings as a sideeffect ... if possible#
[13:28]
gac410With wide deployments of ENP, I think that making it's syntax fully supported part of TML makes a lot of sense. [13:29]
MichaelDaum%HEADINGFORMAT{pattern="##5..."}% for compatibility
just brainstorming ... not sure whether it is feasible at all to change heading format easily
[13:31]
gac410Render.pm doesn't have a callback to allow custom formatting. Maybe another handler is in order.
Another area that a would improve a handler is a true link handler instead of just the title handler that we currently have.
[13:32]
MichaelDaummy point of even think about implenenting an implicit numbering is that extending TML, WysiwygPlugin as well as TinyMCEPlugin ( we need a ui to alter formats ) is A LOT of work [13:33]
gac410Y, if you want true wysiwgy, where the heading shows the numbers and not the markup, that would be huge. [13:34]
MichaelDaumpreRenderingHandler seems to be the obvious place were to hook in
it would prefix numbers to the original heading text and then let it go down the pipe
something like %HEADINGFORMAT{start="1"}% ---+ foo -> ---+ 1. foo -> <h1> 1. foo </h1>
does that make sense?
[13:35]
gac410I think al %MACROS% would be expanded by the time the PreRenddering hander gets control. So %HEADINGFORMAT probably has to expand to some marker so that preRendering handler can process it in a line loop [13:41]
MichaelDaumah true [13:42]
gac410Render.pm processes the ---+ (and <hn...> headers calling a subroutine that creates the anchor.
Render::_makeAnchorHeading
[13:43]
MichaelDaumMichaelDaum has to leave in 15 minutes [13:45]
gac410maybe _makeAnchorHeading could have a callout to a renderHeadingHandler [13:45]
MichaelDaumcool idea
still difficult to properly create sideeffects from macros into the rendering process ...
[13:45]
gac410Okay. Other release meeting topics. I started some work on https://foswiki.org/Development/AddDefaultWebName [13:46]
MichaelDaumhow did things work out? [13:47]
gac410re side effects. Yes, I ran into this difficulty trying to figure out how to implement a macro based control of verbatim, hidden, redacted or whatever.
Didn't get very far,. I created an item branch (not pushed yet), and just the one {ConfigWebname} spec entry.
went down a rathole fixing unit tests I broke with an accidental spec file change a while back.
[13:47]
MichaelDaumyikes
it seemed to be such as straight forward enhancment ...
[13:48]
gac410I was thinking... (dangerous, I know) Maybe the System/Config web should not be in our distribution. but ship it as a template web (admin only). Then bin/configure, in a "onSave" handler for the {ConfigWebName} would create/populate, or rename the config web whever the key changes. [13:50]
MichaelDaumbooya [13:51]
gac410I'm going to start with just a staic populated ConfigWeb, and work in the %CONFIGWEB% macro. Then we can look at how to make this easier.
If that concept (create on config save), maybe we could even do that for the UsersWeb so we don't have to ship that either.
To get really radical. What if ... if the "Main" web did not exist, foswiki would redirect to the System/WebHome. So after bootstrap, on first save, HomeWeb, UsersWeb and ConfigWeb all get created on the fly.
[13:51]
vrurgThat's a huge change. Too huge. [13:54]
gac410hm, anyway, how to eat an elephant... one small bite at a time. :D First step. Separate out the ConfigWeb concept. Then play with dynamically populating it. I think the Checker "onSave" handler is a perfect spot for that.
*if* that experiment works, then some of the other webs have a possibility of handling them the same way.
That's how we create / move the workingDir automatically.
So that's been handled dynamically for a long time.
[13:56]
vrurgLooks like a promising feature, but I'd expect too much efforts been wasted on it. Does it worth it? [14:02]
gac410I've always hated that we ship topics that users have to edit, so we have to build a 2nd "upgrade" package with omitted files. [14:02]
MichaelDaumguys, have to run. back laters. will read logs. [14:03]
gac410Well, the concept has been proven with the workingDir. as a utiliy function, it knows how to populate, and/or move a missing/renamed directory. The idea of doing that to a web is not that much of a leap.
MichaelDaum: Thanks. I won't last much longer either.
I think for 2.2, separating Home, Config and Users webs into separate concepts is a very small leap. That needs to be the priority mainly to help finish addressing some of the security concerns we patched in 2.1.6
The next nibble of the elephant. will Foswiki function in bootstrap mode with any of those 3 webs missing. I'm not sure.
[14:03]
vrurgI'm not talking about the separation which was accepted already. But templating them too? Too many changes, to high risk of new bugs. You've just mentioned just one possible area for them. [14:07]
gac410y, well maybe template is too complicated a word. What I was thinking of is just copying a "distribution" version of what we ship today into a different location. [14:08]
vrurgI would leave templating for later, when all the hype around separation would settle down and the code would stabilize.
Something I miss here then. What is the advantage of just copying them? What problem does it solve?
[14:09]
gac410I come at that from the packaging side. If they are in the tarball, and you change anythig, you get them reverted if you upgrade.
I made a proposal for this years ago, but before we had bootstrap, and config onSave handlers.
[14:11]
vrurgReasonable wether it's packaging or manual installation – both would suffer same issue. [14:14]
gac410https://foswiki.org/Development/ShipCommonlyTailoredTopicsInConfigure It got rejected.
well I rejected it myself
[14:14]
vrurgYet, I'd postpone it – simply because I know very well how hard is it to balance a couple of changes made at once.
vrurg remembers that proposal.
[14:14]
gac410y. I agree. Maybe an initial concept would be a rename capability in an onSave handler for those webnames. So if you want your UsersWeb named "Shareholders" it can be done from the Configure UI rather than requireing a CLI rename.
Right now we have all these configurable names with a warning that if you change them you break your site.
But, really the priority needs to be splitting out the 3 web concepts. So I won't go any further than that.
[14:16]
vrurgSo, let's chunk up the elephant then. [14:18]
gac410The challenge is sites that want to upgrade. New installs need to default to 3 separate webs (Which is what would be in the Config.spec) but existing sites need to recognize Main as the name for all 3 webs.
So Configure::Load() probably needs to decide that if the HomeWeb and ConfigWeb are undefined, set them based upon the value of UsersWeb
[14:19]
vrurgSome of the things discussed today would be easier to implement in 3.0 with new dedicated support for callbacks – if the callbacks themselve are properly planned and planted. [14:20]
gac410y. We *really* need to make 2.2 our last hurray for the 2.x stream and focus on trying to catch 3.x up with the 2.x features.
And tackle the really ugly questions on backwards compatiblitiy of plugins, etc.
[14:22]
vrurgWith regard to upgrade – how does upgrade package deal with specs? Would it be capable of distinguishing whether HomeWeb/ConfigWeb come from LSC or from spec defaults? [14:23]
gac410Once the LSC exists, the only thing copied from .spec files are keys missing from LSC. And in most cases the default is sufficient.
There is a poorly known config upgrade part of Configure::Load() which does a forEach over a list of keys, to convert older deprecated keys into a new value.
[14:24]
vrurgBut these two are missing in LSC, aren't they? So, when configure loads it fetches and merges specs, if memory serves me right. [14:26]
gac410Right. It's the same issue for the new RootDir setting in 2.2.
So Load needs an exception ... don't just merge, but make an intelligent setting.
[14:26]
vrurgOk, anyway – it's a minor technical issue. As far as I remember, readConfig can load LSC only without specs – so, additional check is possible. BTW, in the new specs model I addressed this issue by allowing loading LSC into a separate hash – on way. And another: when LSC is in specs mode it possible to find out if actual key value is set or default is used. Just boasting of myself... ;) [14:29]
gac410;) [14:30]
vrurgLooks like it's all for today? [14:34]
gac410I think so.
I need to get going anyway
[14:34]
vrurgThank you! [14:35]
gac410Thank you too. [14:35]

↑back Search ←Prev date Next date→ Show only urls(Click on time to select a line by its url)