#foswiki 2018-04-24,Tue

↑back Search ←Prev date (last date) Show only urls(Click on time to select a line by its url)

WhoWhatWhen
gac410MichaelDaum - I opened Item14684. Looks when the diff.nat.tmpl was removed from DiffPlugin, it was not added into NatSkin. [00:52]
FoswikiBothttps://foswiki.org/Tasks/Item14684 [ Item14684: diff.nat.tmpl is missing, bin/diff command returns 0 length page. ] [00:52]
.............................................. (idle for 3h49mn)
***gac410 has left [04:41]
.................................. (idle for 2h48mn)
ChanServ sets mode: +o MichaelDaum [07:29]
............................................................. (idle for 5h2mn)
ChanServ sets mode: +o gac410 [12:31]
.................... (idle for 1h38mn)
ChanServ sets mode: +o Lynnwood [14:09]
............................. (idle for 2h23mn)
gac410MichaelDaum: Something strange is going on in the Support web on foswiki.org. I have not been able to figure it out.
If Support.WebCreateNewTopic is used to create a new topic. there are ACLs applied. But they don't seem to be in the template.
It sets ALLOWTOPICCHANGE to type="Set" value="AdminGroup, DevelopersGroup, InfrastructureTaskTeamGroup"
So users get locked out of new support topics.
[16:32]
gac410 is stumped. Definitely coming from the "Default template" There are no ACLs in the WebTopicEditTemplate, or the WebCreateNewTopicTemplate.
I wonder if it's a bug in the NatEdit permissions code. In the Community web, new topics are set to ALLOWCHANGE = Admin Group
[16:41]
MichaelDaumHm can't see it at https://foswiki.org/Support/Question1937 just created [16:54]
gac410It only happens if you use the default template.
Try just going to a Support/FooFoo or other missing topic and click create this topic? then visit the permissions tab
[16:54]
MichaelDaumokay I see [16:56]
gac410I've searched for those groups, and looked at all the templates. I'm at a loss as to where it's coming from.
Magic :D
A user just reported the issue via email to webmaster. Created a new InstallOnCiviHosting topic and was locked out. Other note, is when I removed the setting using the NatEdit Permissions tab and saved the topic. the Permset details still showed the restriction.
[16:57]
MichaelDaumis there any other topic in the Community topic with ALLOWTOPIC.*Main.AdminGroup? [17:04]
gac410Yes, at least a few from WebSearch [17:05]
MichaelDaumThis code here might cause the problems: %QUERY{"'%URLPARAM{"templatetopic" default="%WEB%.%TOPIC%"}%'/preferences[name='%name%'].value" }%
it might fetch its acls from here: https://foswiki.org/Community/WebHome?raw=all
[17:05]
gac410Ohh default %WEB%.%TOPIC% ... or the WebCreateNewTopic page?
no, not WebCreateNewTopic. That topic is not restricted.
[17:06]
MichaelDaumit is WebHome [17:08]
gac410Hm I assume changing it to a * Set ALLOW... style restriction in a <!-- comment will bypass the issue.
This is definitely broken though :(
[17:10]
MichaelDaumhttps://foswiki.org/Support/TestTopic?templatetopic=
the error is happening in %QUERY{"''/preferences[name='ALLOWTOPICCHANGE'].value" }%
this will query the WebHome of the current web
it does not behave like %QUERY{"preferences[name='ALLOWTOPICCHANGE'].value" }%
[17:12]
gac410hm I don't do enough with the QUERY language to know if / where the bug is. :( [17:17]
MichaelDaumtwo ways to fix this:
(1) make better use of %IF to query the url param in a more robust way
(2) fix %QUERY{"''/foobar}%
[17:17]
gac410I suspect (2) is probably hard - for sure, I try not to go too deeply into the query language / parsers But I assume it does seem to be a legit bug Empty topic specification vs missing topic specification should behave the same I think. [17:19]
Another maybe bug? Search doesn't search the meta, so search MaintainGroup doesn't find WebHome which has it in the meta ACLs rather than the text. :( [17:25]
Never mind on that one. I was searching for the wrong string :P [17:30]
MichaelDaumI've created a patch for edit.natedit.tmpl at https://foswiki.org/Tasks/Item14685 [17:41]
gac410Thanks! [17:41]
MichaelDaumto be tested before releasing [17:42]
gac410okay
I'll poke at it a bit later today.
[17:42]

↑back Search ←Prev date (last date) Show only urls(Click on time to select a line by its url)